From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5F14C36002 for ; Mon, 24 Mar 2025 07:22:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5DA3510E1D9; Mon, 24 Mar 2025 07:22:13 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="co4hRIRG"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 37AB910E1B6; Mon, 24 Mar 2025 07:22:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1742800932; x=1774336932; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Bi0VOtxBb5PPiHhSEn+o+czd1m/PRweXqLBe9D7NXXo=; b=co4hRIRG6MqXG4aGn90ZnMsrMPAHBWQXP88KL5eEmyrGxa8aSZEwgUYc f+PAD7b2F2cTiYI7sH79RU9Eu+VbVrxsUAqyX8DHo18DR2L6OPDphF9pm EVFBpEuzgbHi7UQhb1DV7jesmxT1+KKTITvTw8VZ1at5tv2S+0I964gEP j1ae7FHmc1WjlqllgIfV06hVS2X791GlBBTMNQ+GP/YMImqD8k/KDFPJl k2KEmtKt+u2fcZ5xa691etCresbQVlWNxwJOpnMWVfQHItHifLqyc/NGG swjtjxRBKxBndilQWzejkcaY5j1Z3WmQ09PoQfHRuVdBDU3u+QAkpzG3U g==; X-CSE-ConnectionGUID: M0FIZIblR2iMpr4Zz0ZyPA== X-CSE-MsgGUID: plKGUOayTCSm9bj1Ala5KA== X-IronPort-AV: E=McAfee;i="6700,10204,11382"; a="43867249" X-IronPort-AV: E=Sophos;i="6.14,271,1736841600"; d="scan'208";a="43867249" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2025 00:22:12 -0700 X-CSE-ConnectionGUID: sUVwKoHDQxyIOIn75Tj2xw== X-CSE-MsgGUID: 4tE2DzzsS9mDO64YU8DZ3g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,271,1736841600"; d="scan'208";a="124916036" Received: from smile.fi.intel.com ([10.237.72.58]) by orviesa008.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2025 00:22:08 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1twc8K-00000005Gbk-2ZyD; Mon, 24 Mar 2025 09:22:04 +0200 Date: Mon, 24 Mar 2025 09:22:04 +0200 From: Andy Shevchenko To: mailhol.vincent@wanadoo.fr Cc: Yury Norov , Lucas De Marchi , Rasmus Villemoes , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Andrew Morton , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Andi Shyti , David Laight , Jani Nikula Subject: Re: [PATCH v7 1/5] bits: introduce fixed-type GENMASK_U*() Message-ID: References: <20250322-fixed-type-genmasks-v7-0-da380ff1c5b9@wanadoo.fr> <20250322-fixed-type-genmasks-v7-1-da380ff1c5b9@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250322-fixed-type-genmasks-v7-1-da380ff1c5b9@wanadoo.fr> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sat, Mar 22, 2025 at 06:23:12PM +0900, Vincent Mailhol via B4 Relay wrote: > > Add GENMASK_TYPE() which generalizes __GENMASK() to support different > types, and implement fixed-types versions of GENMASK() based on it. > The fixed-type version allows more strict checks to the min/max values > accepted, which is useful for defining registers like implemented by > i915 and xe drivers with their REG_GENMASK*() macros. > > The strict checks rely on shift-count-overflow compiler check to fail > the build if a number outside of the range allowed is passed. > Example: > > #define FOO_MASK GENMASK_U32(33, 4) > > will generate a warning like: > > include/linux/bits.h:51:27: error: right shift count >= width of type [-Werror=shift-count-overflow] > 51 | type_max(t) >> (BITS_PER_TYPE(t) - 1 - (h))))) > | ^~ > > While GENMASK_TYPE() is crafted to cover all variants, including the > already existing GENMASK(), GENMASK_ULL() and GENMASK_U128(), for the > moment, only use it for the newly introduced GENMASK_U*(). The > consolidation will be done in a separate change. ... > #if !defined(__ASSEMBLY__) > + > -#else > +#else /* defined(__ASSEMBLY__) */ > -#endif > + > +#endif /* !defined(__ASSEMBLY__) */ Up to you, but if new version is needed or maintainer require, I would move the above changes either to a separate patch (prerequisite) or dropped them at all. These are not big but unneeded churn, -- With Best Regards, Andy Shevchenko