From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1CBD0C36002 for ; Mon, 24 Mar 2025 14:33:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AFF7210E3E0; Mon, 24 Mar 2025 14:33:07 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Wf4MTUKn"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by gabe.freedesktop.org (Postfix) with ESMTPS id EB33F10E3E0; Mon, 24 Mar 2025 14:33:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1742826786; x=1774362786; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=VH2tuyab+QykS7q6ZLU70B5b2xpyt97ECrYqMIdjZrY=; b=Wf4MTUKnvP8UpHWxgCcO6mAVQETKhUqWHHhMsdeK3MGndYSXdjZNF+v5 u1jo3oBuJz95A2zo8USzlOOrCB3CUul6oVBEdF1w+SU1fBb/Ej5c/r0g6 Hpp6+1nRfoI9jSBWhEQDtVDVideZ3S1MAPACoWax+my/7CGVpjBT8Gbql /m5C9O1lpyipdX02KZUYgbXtsl7soux4Gej5ltavpzyrJzW5qC4e/jSTE 70fTc0/Fz1L+0NtyDpz7a3Kbgt9ctNfSD4XFwG95qX+WLYfFmFjc0JAcN YFMfJrg3u11Mn9EbNVMs4iMKPe4q6sVMdtor35TIOKl/NCNV/NNgw2wa5 g==; X-CSE-ConnectionGUID: nu+HvswmSWq13NWxsC8apg== X-CSE-MsgGUID: ZhLXfG3OSCmgvG5Cophq/Q== X-IronPort-AV: E=McAfee;i="6700,10204,11383"; a="61556087" X-IronPort-AV: E=Sophos;i="6.14,272,1736841600"; d="scan'208";a="61556087" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2025 07:33:04 -0700 X-CSE-ConnectionGUID: Nc+1BQxqQY6caLjtA886Qg== X-CSE-MsgGUID: pzpRK6j1RkGUBCQeVKiV6A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,272,1736841600"; d="scan'208";a="147262484" Received: from smile.fi.intel.com ([10.237.72.58]) by fmviesa002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2025 07:32:54 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1twirD-00000005T9T-0HyN; Mon, 24 Mar 2025 16:32:51 +0200 Date: Mon, 24 Mar 2025 16:32:50 +0200 From: Andy Shevchenko To: Vincent Mailhol Cc: Yury Norov , Lucas De Marchi , Rasmus Villemoes , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Andrew Morton , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Andi Shyti , David Laight , Jani Nikula Subject: Re: [PATCH v7 2/5] bits: introduce fixed-type BIT_U*() Message-ID: References: <20250322-fixed-type-genmasks-v7-0-da380ff1c5b9@wanadoo.fr> <20250322-fixed-type-genmasks-v7-2-da380ff1c5b9@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Mar 24, 2025 at 11:16:30PM +0900, Vincent Mailhol wrote: > On 24/03/2025 at 22:41, Andy Shevchenko wrote: > > On Sat, Mar 22, 2025 at 06:23:13PM +0900, Vincent Mailhol via B4 Relay wrote: ... > >> +/* > >> + * Fixed-type variants of BIT(), with additional checks like GENMASK_TYPE(). The > >> + * following examples generate compiler warnings due to shift-count-overflow: > > > > "...due to -Wshift-count-overflow:" ? > > > > Same idea — if you need a new version, since it's just a nit-pick. > > If you want. I staged this change locally, so if there is a v8, it will > be addressed. I applied the same to the previous patch which also > mentioned shift-count-overflow without the -W prefix. > > But honestly, I am not convinced of the added value. This is from Lucas > original patch one year ago, and no one was bothered by this. IMHO, when > writing: > > (...) generate compiler warnings due to shift-count-overflow: > > I do not see where the ambiguity is. The sentence clearly say that this > is a compiler warning, so with or without the -W prefix, the sentence is > equally understandable. As I marked, it's a nit-pick, but from my point of view the added value is immediate: The reader can be sure that we are talking about a compiler warning and not something else (C standard? some special term?). So it adds more context and makes it clearer. -- With Best Regards, Andy Shevchenko