From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D0CCC36010 for ; Mon, 31 Mar 2025 15:46:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F0A2910E42A; Mon, 31 Mar 2025 15:46:47 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Ko0gHXqH"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0A29D10E429; Mon, 31 Mar 2025 15:46:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1743436007; x=1774972007; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=kn6FKGLPCY3HK247j1puMCT9n9cVqCpcXbmtpbdRBKw=; b=Ko0gHXqHjwt6kMo06+D3E1LoIbu7jEp3+4CWYJB2DvQNpRBabmFxe1gN lVeD5AxWxfWPifSp+UqCo9vE+D8slpgeljtXwLW028kHsJfri/T1NImiH ZTIEguk+7sQQaifuFtjBLl0yjk30r4hl+KLjndPm2wBOJa/C4jxBLgMAQ BXioMYqTm0ceARf37S/5Yh50PNWFIjuPHkm9BY4+dD7i7g+rqcSKvzXJp G35DGgG3sPX/xF8Oz+gi2pr1glB5ZQ8Afrw0uX/9NpKht6XACuDt+N7el nV1FiwWXOCYoU4C8MA5Dn1T92APzuoCaTYKtG2RraWVfnVU02eankt+Wf w==; X-CSE-ConnectionGUID: 9taZBNpTQayqzzIwsFSwww== X-CSE-MsgGUID: VFcn3PiNQKq2YwRTLMHUIA== X-IronPort-AV: E=McAfee;i="6700,10204,11390"; a="43979469" X-IronPort-AV: E=Sophos;i="6.14,290,1736841600"; d="scan'208";a="43979469" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2025 08:46:47 -0700 X-CSE-ConnectionGUID: sEWis2oXRxe934bTAyyw/Q== X-CSE-MsgGUID: ZN9Nx08CQ52tCbBc4dTpBw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,290,1736841600"; d="scan'208";a="131338922" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.74]) by orviesa005.jf.intel.com with SMTP; 31 Mar 2025 08:46:44 -0700 Received: by stinkbox (sSMTP sendmail emulation); Mon, 31 Mar 2025 18:46:42 +0300 Date: Mon, 31 Mar 2025 18:46:42 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Arun R Murthy Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, Jani Nikula , chaitanya.kumar.borah@intel.com, ville.syrjala@intel.com Subject: Re: [PATCH v11 4/5] drm/i915/display: Add i915 hook for format_mod_supported_async Message-ID: References: <20250328-asyn-v11-0-a50d13bfea0d@intel.com> <20250328-asyn-v11-4-a50d13bfea0d@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250328-asyn-v11-4-a50d13bfea0d@intel.com> X-Patchwork-Hint: comment X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Mar 28, 2025 at 09:26:23PM +0530, Arun R Murthy wrote: > Hook up the newly added plane function pointer > format_mod_supported_async to populate the modifiers/formats supported > by asynchronous flips. > > v5: Correct the if condition for modifier support check (Chaitanya) > v6: Replace uint32_t/uint64_t with u32/u64 (Jani) > v7: Move plannar check from intel_async_flip_check_hw() to > intel_plane_format_mod_supported_async() (Ville) > v8: In case of error print format/modifier (Chaitanya) > v9: Exclude C8 format as its not supported by hardware > v10: filter only planar formats > move changes in can_async_flip to new patch (Ville) > > Signed-off-by: Arun R Murthy Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/i9xx_plane.c | 2 ++ > drivers/gpu/drm/i915/display/intel_atomic_plane.c | 11 +++++++++++ > drivers/gpu/drm/i915/display/intel_atomic_plane.h | 3 +++ > drivers/gpu/drm/i915/display/skl_universal_plane.c | 3 +++ > 4 files changed, 19 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/i9xx_plane.c b/drivers/gpu/drm/i915/display/i9xx_plane.c > index 20c47de6d8bfd1d8ddafae02ed68370df799e22b..75780fefe0ce98fe79e8bf8e118f5cf0d0b96e55 100644 > --- a/drivers/gpu/drm/i915/display/i9xx_plane.c > +++ b/drivers/gpu/drm/i915/display/i9xx_plane.c > @@ -897,6 +897,7 @@ static const struct drm_plane_funcs i965_plane_funcs = { > .atomic_duplicate_state = intel_plane_duplicate_state, > .atomic_destroy_state = intel_plane_destroy_state, > .format_mod_supported = i965_plane_format_mod_supported, > + .format_mod_supported_async = intel_plane_format_mod_supported_async, > }; > > static const struct drm_plane_funcs i8xx_plane_funcs = { > @@ -906,6 +907,7 @@ static const struct drm_plane_funcs i8xx_plane_funcs = { > .atomic_duplicate_state = intel_plane_duplicate_state, > .atomic_destroy_state = intel_plane_destroy_state, > .format_mod_supported = i8xx_plane_format_mod_supported, > + .format_mod_supported_async = intel_plane_format_mod_supported_async, > }; > > struct intel_plane * > diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c b/drivers/gpu/drm/i915/display/intel_atomic_plane.c > index 1ec730047759cb22b3e0fabfd2eaddbc1bc865af..3b9d3e1620cd882b8a7f9b4c96640e42367248bb 100644 > --- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c > +++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c > @@ -183,6 +183,17 @@ bool intel_plane_can_async_flip(struct intel_plane *plane, u32 format, > return plane->can_async_flip && plane->can_async_flip(modifier); > } > > +bool intel_plane_format_mod_supported_async(struct drm_plane *plane, > + u32 format, > + u64 modifier) > +{ > + if (!plane->funcs->format_mod_supported(plane, format, modifier)) > + return false; > + > + return intel_plane_can_async_flip(to_intel_plane(plane), > + format, modifier); > +} > + > unsigned int intel_adjusted_rate(const struct drm_rect *src, > const struct drm_rect *dst, > unsigned int rate) > diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.h b/drivers/gpu/drm/i915/display/intel_atomic_plane.h > index 772a12aa9c6997d77b9393f964e91f3e8747d149..317320c32285db7edf1aaa5eced3cfbad59a37ff 100644 > --- a/drivers/gpu/drm/i915/display/intel_atomic_plane.h > +++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.h > @@ -90,5 +90,8 @@ int intel_atomic_add_affected_planes(struct intel_atomic_state *state, > int intel_atomic_check_planes(struct intel_atomic_state *state); > > u32 intel_plane_ggtt_offset(const struct intel_plane_state *plane_state); > +bool intel_plane_format_mod_supported_async(struct drm_plane *plane, > + u32 format, > + u64 modifier); > > #endif /* __INTEL_ATOMIC_PLANE_H__ */ > diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c > index 8f6170a5c108a000582f3415f78bad279254d8cf..f7c3ee1f8664eea7917a531b108aeac123cb1add 100644 > --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c > +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c > @@ -2666,6 +2666,7 @@ static const struct drm_plane_funcs skl_plane_funcs = { > .atomic_duplicate_state = intel_plane_duplicate_state, > .atomic_destroy_state = intel_plane_destroy_state, > .format_mod_supported = skl_plane_format_mod_supported, > + .format_mod_supported_async = intel_plane_format_mod_supported_async, > }; > > static const struct drm_plane_funcs icl_plane_funcs = { > @@ -2675,6 +2676,7 @@ static const struct drm_plane_funcs icl_plane_funcs = { > .atomic_duplicate_state = intel_plane_duplicate_state, > .atomic_destroy_state = intel_plane_destroy_state, > .format_mod_supported = icl_plane_format_mod_supported, > + .format_mod_supported_async = intel_plane_format_mod_supported_async, > }; > > static const struct drm_plane_funcs tgl_plane_funcs = { > @@ -2684,6 +2686,7 @@ static const struct drm_plane_funcs tgl_plane_funcs = { > .atomic_duplicate_state = intel_plane_duplicate_state, > .atomic_destroy_state = intel_plane_destroy_state, > .format_mod_supported = tgl_plane_format_mod_supported, > + .format_mod_supported_async = intel_plane_format_mod_supported_async, > }; > > static void > > -- > 2.25.1 -- Ville Syrjälä Intel