From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FED6C282D1 for ; Thu, 6 Mar 2025 13:05:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B117A10E1FD; Thu, 6 Mar 2025 13:05:32 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="a3tOFI9a"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id 398E110E1E1; Thu, 6 Mar 2025 13:05:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741266332; x=1772802332; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=vyXzzdl7CTsDjVwKAXKtkmRpCQPPSn+DOaj/Y6vgm5c=; b=a3tOFI9avEb9IOhLAJkHd3wvPanOqgTZkl91zBKF2VvYITxYW/8bh5um 2gdY9r8AqlNKYPW8fZxMna1FRrSi/QoobLEvujNUfdS4SNY8BkI8v9tNT D5e8dLwflqeM+oCdpSSu2QDl/PuozkBiIwWx8KmL5Yqk1Lfnm3dv8y5Qc Rs2cw1L6SZ8L6UaMrAtk11imfrwTvvEXUXamQNTV4QL85QOj8dKS1eGYv t0DMA4TvK5CnO7xJi++NH337slp9FgA+idkVCPzwJJyU/t9ulNy8S3fdQ 7zbtWUXmdcxD7zq7TzMSDi4ghYFrF9Y+63ZKMz8QR9Kod6NYPJqg8Etim Q==; X-CSE-ConnectionGUID: UACTI1VeT7+2KOWan9BMiw== X-CSE-MsgGUID: CRb1lHCtRWSxjVjp6mSGCg== X-IronPort-AV: E=McAfee;i="6700,10204,11365"; a="29854922" X-IronPort-AV: E=Sophos;i="6.14,226,1736841600"; d="scan'208";a="29854922" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2025 05:05:31 -0800 X-CSE-ConnectionGUID: tGyxdRHFS1GZCBhj4zJIPw== X-CSE-MsgGUID: 6lw2cuyCTZGMzTXLnX9+LQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,226,1736841600"; d="scan'208";a="119210793" Received: from smile.fi.intel.com ([10.237.72.58]) by fmviesa008.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2025 05:05:28 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1tqAuh-000000007eh-3UPW; Thu, 06 Mar 2025 15:05:23 +0200 Date: Thu, 6 Mar 2025 15:05:23 +0200 From: Andy Shevchenko To: mailhol.vincent@wanadoo.fr Cc: Yury Norov , Lucas De Marchi , Rasmus Villemoes , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Andrew Morton , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Andi Shyti , David Laight , Dmitry Baryshkov Subject: Re: [PATCH v5 1/7] bits: split the definition of the asm and non-asm GENMASK() Message-ID: References: <20250306-fixed-type-genmasks-v5-0-b443e9dcba63@wanadoo.fr> <20250306-fixed-type-genmasks-v5-1-b443e9dcba63@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250306-fixed-type-genmasks-v5-1-b443e9dcba63@wanadoo.fr> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Mar 06, 2025 at 08:29:52PM +0900, Vincent Mailhol via B4 Relay wrote: > From: Vincent Mailhol > > In an upcoming change, GENMASK() and its friends will indirectly > depend on sizeof() which is not available in asm. > > Instead of adding further complexity to __GENMASK() to make it work > for both asm and non asm, just split the definition of the two > variants. ... > -/* > - * BUILD_BUG_ON_ZERO is not available in h files included from asm files, > - * disable the input check if that is the case. > - */ I believe this comment is still valid... > +#else /* defined(__ASSEMBLY__) */ ...here. Otherwise justify its removal in the commit message. > +#define GENMASK(h, l) __GENMASK(h, l) > +#define GENMASK_ULL(h, l) __GENMASK_ULL(h, l) > + > +#endif /* !defined(__ASSEMBLY__) */ -- With Best Regards, Andy Shevchenko