From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85208C282EC for ; Wed, 19 Mar 2025 00:34:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1F30B10E0C6; Wed, 19 Mar 2025 00:34:27 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="mHZLh8Zz"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 97C2F10E0C6 for ; Wed, 19 Mar 2025 00:34:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1742344465; x=1773880465; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=l7qx0fzjh5+fPeFdopZV6FhkSP/1qkS6HzhJYjxttmw=; b=mHZLh8ZzNkk9mZJxQlQuqUZHBl+vFJ9jKiTQ9fJNccoA6T8LznnO/Dus cjzVOyQ2IDqRNP+QSt22+7kK76SxuvqMyJ8IqAIaNytoobXr/oPOvoeoY gi19vK2CVsDDxl7vqrvmTNsA5nR1vNgUGfJb5oSJgV94FC3jzoYSyNy99 /WBgeD8jDRMUm0HpofPMh6V7gwpbn8GmmTmy8EewKVDy5Ynzwz+9JXpCl 9CphkU5qLqFnGCvvhQdNEhfzABHCCwWtQ5q8mwS8t7EOwdSfee1mMRTbS FIA+SaezSzQ25tqmVnjPVdpE6tbVCm2o46oDIezRxBS+PzgX0F4ixj8E0 Q==; X-CSE-ConnectionGUID: F2Opq1UvTSuj02LvV901eg== X-CSE-MsgGUID: sqHN+E7NQCSMR0zgd1zrSg== X-IronPort-AV: E=McAfee;i="6700,10204,11377"; a="54892737" X-IronPort-AV: E=Sophos;i="6.14,258,1736841600"; d="scan'208";a="54892737" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2025 17:34:25 -0700 X-CSE-ConnectionGUID: i7q3e5NxTF+KBcz+hYbelA== X-CSE-MsgGUID: wKYhAleQSmGAoR21+h4UNA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,258,1736841600"; d="scan'208";a="153425536" Received: from kniemiec-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.246.185]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2025 17:34:23 -0700 Date: Wed, 19 Mar 2025 01:34:20 +0100 From: Andi Shyti To: Krzysztof Karas Cc: Andi Shyti , intel-gfx , Andi Shyti Subject: Re: [PATCH 2/4] drm/i915/gt: Fix SPDX license format Message-ID: References: <20250314021225.11813-1-andi.shyti@linux.intel.com> <20250314021225.11813-3-andi.shyti@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Mar 18, 2025 at 10:55:03AM +0000, Krzysztof Karas wrote: > > Header files need to declare the SPDX under /* ... */ style > All files modified in this patch series start with: > // SPDX-License-Identifier: MIT > rather than: > /* SPDX-License-Identifier: MIT */ > > As a note: > :~/linux/drm-tip/drivers/gpu/drm/i915$ rg "// SPDX-License-Identifier: " | wc -l > 242 > :~/linux/drm-tip/drivers/gpu/drm/i915$ rg "/* SPDX-License-Identifier: " | wc -l > 696 > > are those styles interchangable or is one preferred over the > other? I am just curious seeing both are being used. It's an ugly mess that for some reason people have accepted from the beginning. The SPDX license has a different format for .c and .h file :/ Andi