* [Intel-gfx] [PATCH 1/3] drm/i915: Remove redundant check for DG1
@ 2023-03-06 20:49 Lucas De Marchi
2023-03-06 20:49 ` [Intel-gfx] [PATCH 2/3] drm/i915: Move DG2 tuning to the right function Lucas De Marchi
` (5 more replies)
0 siblings, 6 replies; 12+ messages in thread
From: Lucas De Marchi @ 2023-03-06 20:49 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi, dri-devel
dg1_gt_workarounds_init() is only ever called for DG1, so there is no
point checking it again.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 32aa1647721a..eb6cc4867d67 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -1472,21 +1472,15 @@ gen12_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
static void
dg1_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
{
- struct drm_i915_private *i915 = gt->i915;
-
gen12_gt_workarounds_init(gt, wal);
/* Wa_1409420604:dg1 */
- if (IS_DG1(i915))
- wa_mcr_write_or(wal,
- SUBSLICE_UNIT_LEVEL_CLKGATE2,
- CPSSUNIT_CLKGATE_DIS);
+ wa_mcr_write_or(wal, SUBSLICE_UNIT_LEVEL_CLKGATE2,
+ CPSSUNIT_CLKGATE_DIS);
/* Wa_1408615072:dg1 */
/* Empirical testing shows this register is unaffected by engine reset. */
- if (IS_DG1(i915))
- wa_write_or(wal, UNSLICE_UNIT_LEVEL_CLKGATE2,
- VSUNIT_CLKGATE_DIS_TGL);
+ wa_write_or(wal, UNSLICE_UNIT_LEVEL_CLKGATE2, VSUNIT_CLKGATE_DIS_TGL);
}
static void
--
2.39.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Intel-gfx] [PATCH 2/3] drm/i915: Move DG2 tuning to the right function
2023-03-06 20:49 [Intel-gfx] [PATCH 1/3] drm/i915: Remove redundant check for DG1 Lucas De Marchi
@ 2023-03-06 20:49 ` Lucas De Marchi
2023-03-06 23:16 ` Matt Roper
2023-03-06 20:49 ` [Intel-gfx] [PATCH 3/3] drm/i915/dg1: Move Wa_1806527549 " Lucas De Marchi
` (4 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Lucas De Marchi @ 2023-03-06 20:49 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi, dri-devel
Use gt_tuning_settings() for the recommended tunings rather than the one
for workarounds.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index eb6cc4867d67..389bfcd299af 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -1653,13 +1653,6 @@ dg2_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
/* Wa_14014830051:dg2 */
wa_mcr_write_clr(wal, SARB_CHICKEN1, COMP_CKN_IN);
- /*
- * The following are not actually "workarounds" but rather
- * recommended tuning settings documented in the bspec's
- * performance guide section.
- */
- wa_mcr_write_or(wal, XEHP_SQCM, EN_32B_ACCESS);
-
/* Wa_14015795083 */
wa_write_clr(wal, GEN7_MISCCPCTL, GEN12_DOP_CLOCK_GATE_RENDER_ENABLE);
@@ -1752,8 +1745,10 @@ static void gt_tuning_settings(struct intel_gt *gt, struct i915_wa_list *wal)
wa_mcr_masked_en(wal, XEHPC_LNCFMISCCFGREG0, XEHPC_HOSTCACHEEN);
}
- if (IS_DG2(gt->i915))
+ if (IS_DG2(gt->i915)) {
wa_mcr_write_or(wal, XEHP_L3SCQREG7, BLEND_FILL_CACHING_OPT_DIS);
+ wa_mcr_write_or(wal, XEHP_SQCM, EN_32B_ACCESS);
+ }
}
static void
--
2.39.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Intel-gfx] [PATCH 3/3] drm/i915/dg1: Move Wa_1806527549 to the right function
2023-03-06 20:49 [Intel-gfx] [PATCH 1/3] drm/i915: Remove redundant check for DG1 Lucas De Marchi
2023-03-06 20:49 ` [Intel-gfx] [PATCH 2/3] drm/i915: Move DG2 tuning to the right function Lucas De Marchi
@ 2023-03-06 20:49 ` Lucas De Marchi
2023-03-06 23:17 ` Matt Roper
2023-03-06 23:11 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Remove redundant check for DG1 Patchwork
` (3 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Lucas De Marchi @ 2023-03-06 20:49 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi, dri-devel
dg1_ctx_workarounds_init() is DG1-only, while
gen12_ctx_workarounds_init() is shared with other platforms. Move the
workaround to the former so there is no additional platform check
needed.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 389bfcd299af..f68fe64f63a6 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -707,8 +707,6 @@ static void gen12_ctx_gt_tuning_init(struct intel_engine_cs *engine,
static void gen12_ctx_workarounds_init(struct intel_engine_cs *engine,
struct i915_wa_list *wal)
{
- struct drm_i915_private *i915 = engine->i915;
-
gen12_ctx_gt_tuning_init(engine, wal);
/*
@@ -742,10 +740,6 @@ static void gen12_ctx_workarounds_init(struct intel_engine_cs *engine,
FF_MODE2_GS_TIMER_MASK,
FF_MODE2_GS_TIMER_224,
0, false);
-
- if (!IS_DG1(i915))
- /* Wa_1806527549 */
- wa_masked_en(wal, HIZ_CHICKEN, HZ_DEPTH_TEST_LE_GE_OPT_DISABLE);
}
static void dg1_ctx_workarounds_init(struct intel_engine_cs *engine,
@@ -760,6 +754,9 @@ static void dg1_ctx_workarounds_init(struct intel_engine_cs *engine,
/* Wa_22010493298 */
wa_masked_en(wal, HIZ_CHICKEN,
DG1_HZ_READ_SUPPRESSION_OPTIMIZATION_DISABLE);
+
+ /* Wa_1806527549 */
+ wa_masked_en(wal, HIZ_CHICKEN, HZ_DEPTH_TEST_LE_GE_OPT_DISABLE);
}
static void dg2_ctx_workarounds_init(struct intel_engine_cs *engine,
--
2.39.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Remove redundant check for DG1
2023-03-06 20:49 [Intel-gfx] [PATCH 1/3] drm/i915: Remove redundant check for DG1 Lucas De Marchi
2023-03-06 20:49 ` [Intel-gfx] [PATCH 2/3] drm/i915: Move DG2 tuning to the right function Lucas De Marchi
2023-03-06 20:49 ` [Intel-gfx] [PATCH 3/3] drm/i915/dg1: Move Wa_1806527549 " Lucas De Marchi
@ 2023-03-06 23:11 ` Patchwork
2023-03-06 23:15 ` [Intel-gfx] [PATCH 1/3] " Matt Roper
` (2 subsequent siblings)
5 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-03-06 23:11 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4999 bytes --]
== Series Details ==
Series: series starting with [1/3] drm/i915: Remove redundant check for DG1
URL : https://patchwork.freedesktop.org/series/114735/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12818 -> Patchwork_114735v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/index.html
Participating hosts (35 -> 35)
------------------------------
Additional (1): fi-kbl-soraka
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_114735v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3@smem:
- bat-rpls-1: NOTRUN -> [ABORT][1] ([i915#6687] / [i915#7978])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/bat-rpls-1/igt@gem_exec_suspend@basic-s3@smem.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#2190])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@i915_selftest@live@execlists:
- fi-bsw-nick: [PASS][4] -> [INCOMPLETE][5] ([i915#7913])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12818/fi-bsw-nick/igt@i915_selftest@live@execlists.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/fi-bsw-nick/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gem_contexts:
- fi-kbl-soraka: NOTRUN -> [INCOMPLETE][6] ([i915#7913])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/fi-kbl-soraka/igt@i915_selftest@live@gem_contexts.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][7] ([i915#1886])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@hangcheck:
- bat-dg1-5: [PASS][8] -> [ABORT][9] ([i915#4983])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12818/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@reset:
- bat-rpls-2: [PASS][10] -> [ABORT][11] ([i915#4983] / [i915#7913])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12818/bat-rpls-2/igt@i915_selftest@live@reset.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/bat-rpls-2/igt@i915_selftest@live@reset.html
* igt@kms_chamelium_frames@hdmi-crc-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][12] ([fdo#109271]) +16 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html
#### Possible fixes ####
* igt@i915_selftest@live@requests:
- bat-rpls-1: [ABORT][13] ([i915#7694] / [i915#7911] / [i915#7982]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12818/bat-rpls-1/igt@i915_selftest@live@requests.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/bat-rpls-1/igt@i915_selftest@live@requests.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7694]: https://gitlab.freedesktop.org/drm/intel/issues/7694
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
Build changes
-------------
* Linux: CI_DRM_12818 -> Patchwork_114735v1
CI-20190529: 20190529
CI_DRM_12818: fe02c0851ac36ad0d4e8c2a66a4dc2f45e49b91e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7181: f44a24fe9f1948a117daf3162db53df7820f9923 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_114735v1: fe02c0851ac36ad0d4e8c2a66a4dc2f45e49b91e @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
5ecebc8696d9 drm/i915/dg1: Move Wa_1806527549 to the right function
a534c052fdd5 drm/i915: Move DG2 tuning to the right function
3ad15897e2da drm/i915: Remove redundant check for DG1
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/index.html
[-- Attachment #2: Type: text/html, Size: 6182 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH 1/3] drm/i915: Remove redundant check for DG1
2023-03-06 20:49 [Intel-gfx] [PATCH 1/3] drm/i915: Remove redundant check for DG1 Lucas De Marchi
` (2 preceding siblings ...)
2023-03-06 23:11 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Remove redundant check for DG1 Patchwork
@ 2023-03-06 23:15 ` Matt Roper
2023-03-07 12:01 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] " Patchwork
2023-03-13 9:10 ` [Intel-gfx] [PATCH 1/3] " Ville Syrjälä
5 siblings, 0 replies; 12+ messages in thread
From: Matt Roper @ 2023-03-06 23:15 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx, dri-devel
On Mon, Mar 06, 2023 at 12:49:52PM -0800, Lucas De Marchi wrote:
> dg1_gt_workarounds_init() is only ever called for DG1, so there is no
> point checking it again.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> index 32aa1647721a..eb6cc4867d67 100644
> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> @@ -1472,21 +1472,15 @@ gen12_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
> static void
> dg1_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
> {
> - struct drm_i915_private *i915 = gt->i915;
> -
> gen12_gt_workarounds_init(gt, wal);
>
> /* Wa_1409420604:dg1 */
> - if (IS_DG1(i915))
> - wa_mcr_write_or(wal,
> - SUBSLICE_UNIT_LEVEL_CLKGATE2,
> - CPSSUNIT_CLKGATE_DIS);
> + wa_mcr_write_or(wal, SUBSLICE_UNIT_LEVEL_CLKGATE2,
> + CPSSUNIT_CLKGATE_DIS);
>
> /* Wa_1408615072:dg1 */
> /* Empirical testing shows this register is unaffected by engine reset. */
> - if (IS_DG1(i915))
> - wa_write_or(wal, UNSLICE_UNIT_LEVEL_CLKGATE2,
> - VSUNIT_CLKGATE_DIS_TGL);
> + wa_write_or(wal, UNSLICE_UNIT_LEVEL_CLKGATE2, VSUNIT_CLKGATE_DIS_TGL);
> }
>
> static void
> --
> 2.39.0
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH 2/3] drm/i915: Move DG2 tuning to the right function
2023-03-06 20:49 ` [Intel-gfx] [PATCH 2/3] drm/i915: Move DG2 tuning to the right function Lucas De Marchi
@ 2023-03-06 23:16 ` Matt Roper
0 siblings, 0 replies; 12+ messages in thread
From: Matt Roper @ 2023-03-06 23:16 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx, dri-devel
On Mon, Mar 06, 2023 at 12:49:53PM -0800, Lucas De Marchi wrote:
> Use gt_tuning_settings() for the recommended tunings rather than the one
> for workarounds.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> index eb6cc4867d67..389bfcd299af 100644
> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> @@ -1653,13 +1653,6 @@ dg2_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
> /* Wa_14014830051:dg2 */
> wa_mcr_write_clr(wal, SARB_CHICKEN1, COMP_CKN_IN);
>
> - /*
> - * The following are not actually "workarounds" but rather
> - * recommended tuning settings documented in the bspec's
> - * performance guide section.
> - */
> - wa_mcr_write_or(wal, XEHP_SQCM, EN_32B_ACCESS);
> -
> /* Wa_14015795083 */
> wa_write_clr(wal, GEN7_MISCCPCTL, GEN12_DOP_CLOCK_GATE_RENDER_ENABLE);
>
> @@ -1752,8 +1745,10 @@ static void gt_tuning_settings(struct intel_gt *gt, struct i915_wa_list *wal)
> wa_mcr_masked_en(wal, XEHPC_LNCFMISCCFGREG0, XEHPC_HOSTCACHEEN);
> }
>
> - if (IS_DG2(gt->i915))
> + if (IS_DG2(gt->i915)) {
> wa_mcr_write_or(wal, XEHP_L3SCQREG7, BLEND_FILL_CACHING_OPT_DIS);
> + wa_mcr_write_or(wal, XEHP_SQCM, EN_32B_ACCESS);
> + }
> }
>
> static void
> --
> 2.39.0
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915/dg1: Move Wa_1806527549 to the right function
2023-03-06 20:49 ` [Intel-gfx] [PATCH 3/3] drm/i915/dg1: Move Wa_1806527549 " Lucas De Marchi
@ 2023-03-06 23:17 ` Matt Roper
2023-03-06 23:53 ` Lucas De Marchi
0 siblings, 1 reply; 12+ messages in thread
From: Matt Roper @ 2023-03-06 23:17 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx, dri-devel
On Mon, Mar 06, 2023 at 12:49:54PM -0800, Lucas De Marchi wrote:
> dg1_ctx_workarounds_init() is DG1-only, while
> gen12_ctx_workarounds_init() is shared with other platforms. Move the
> workaround to the former so there is no additional platform check
> needed.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> index 389bfcd299af..f68fe64f63a6 100644
> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> @@ -707,8 +707,6 @@ static void gen12_ctx_gt_tuning_init(struct intel_engine_cs *engine,
> static void gen12_ctx_workarounds_init(struct intel_engine_cs *engine,
> struct i915_wa_list *wal)
> {
> - struct drm_i915_private *i915 = engine->i915;
> -
> gen12_ctx_gt_tuning_init(engine, wal);
>
> /*
> @@ -742,10 +740,6 @@ static void gen12_ctx_workarounds_init(struct intel_engine_cs *engine,
> FF_MODE2_GS_TIMER_MASK,
> FF_MODE2_GS_TIMER_224,
> 0, false);
> -
> - if (!IS_DG1(i915))
I think you missed the "!" here. I.e., this workaround applies to all
the "gen12" platforms *except* DG1.
Matt
> - /* Wa_1806527549 */
> - wa_masked_en(wal, HIZ_CHICKEN, HZ_DEPTH_TEST_LE_GE_OPT_DISABLE);
> }
>
> static void dg1_ctx_workarounds_init(struct intel_engine_cs *engine,
> @@ -760,6 +754,9 @@ static void dg1_ctx_workarounds_init(struct intel_engine_cs *engine,
> /* Wa_22010493298 */
> wa_masked_en(wal, HIZ_CHICKEN,
> DG1_HZ_READ_SUPPRESSION_OPTIMIZATION_DISABLE);
> +
> + /* Wa_1806527549 */
> + wa_masked_en(wal, HIZ_CHICKEN, HZ_DEPTH_TEST_LE_GE_OPT_DISABLE);
> }
>
> static void dg2_ctx_workarounds_init(struct intel_engine_cs *engine,
> --
> 2.39.0
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915/dg1: Move Wa_1806527549 to the right function
2023-03-06 23:17 ` Matt Roper
@ 2023-03-06 23:53 ` Lucas De Marchi
0 siblings, 0 replies; 12+ messages in thread
From: Lucas De Marchi @ 2023-03-06 23:53 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx, dri-devel
On Mon, Mar 06, 2023 at 03:17:50PM -0800, Matt Roper wrote:
>On Mon, Mar 06, 2023 at 12:49:54PM -0800, Lucas De Marchi wrote:
>> dg1_ctx_workarounds_init() is DG1-only, while
>> gen12_ctx_workarounds_init() is shared with other platforms. Move the
>> workaround to the former so there is no additional platform check
>> needed.
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>> ---
>> drivers/gpu/drm/i915/gt/intel_workarounds.c | 9 +++------
>> 1 file changed, 3 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> index 389bfcd299af..f68fe64f63a6 100644
>> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> @@ -707,8 +707,6 @@ static void gen12_ctx_gt_tuning_init(struct intel_engine_cs *engine,
>> static void gen12_ctx_workarounds_init(struct intel_engine_cs *engine,
>> struct i915_wa_list *wal)
>> {
>> - struct drm_i915_private *i915 = engine->i915;
>> -
>> gen12_ctx_gt_tuning_init(engine, wal);
>>
>> /*
>> @@ -742,10 +740,6 @@ static void gen12_ctx_workarounds_init(struct intel_engine_cs *engine,
>> FF_MODE2_GS_TIMER_MASK,
>> FF_MODE2_GS_TIMER_224,
>> 0, false);
>> -
>> - if (!IS_DG1(i915))
>
>I think you missed the "!" here. I.e., this workaround applies to all
>the "gen12" platforms *except* DG1.
oops, thanks for catching that. I'll drop this last patch.
Lucas De Marchi
>
>
>Matt
>
>> - /* Wa_1806527549 */
>> - wa_masked_en(wal, HIZ_CHICKEN, HZ_DEPTH_TEST_LE_GE_OPT_DISABLE);
>> }
>>
>> static void dg1_ctx_workarounds_init(struct intel_engine_cs *engine,
>> @@ -760,6 +754,9 @@ static void dg1_ctx_workarounds_init(struct intel_engine_cs *engine,
>> /* Wa_22010493298 */
>> wa_masked_en(wal, HIZ_CHICKEN,
>> DG1_HZ_READ_SUPPRESSION_OPTIMIZATION_DISABLE);
>> +
>> + /* Wa_1806527549 */
>> + wa_masked_en(wal, HIZ_CHICKEN, HZ_DEPTH_TEST_LE_GE_OPT_DISABLE);
>> }
>>
>> static void dg2_ctx_workarounds_init(struct intel_engine_cs *engine,
>> --
>> 2.39.0
>>
>
>--
>Matt Roper
>Graphics Software Engineer
>Linux GPU Platform Enablement
>Intel Corporation
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915: Remove redundant check for DG1
2023-03-06 20:49 [Intel-gfx] [PATCH 1/3] drm/i915: Remove redundant check for DG1 Lucas De Marchi
` (3 preceding siblings ...)
2023-03-06 23:15 ` [Intel-gfx] [PATCH 1/3] " Matt Roper
@ 2023-03-07 12:01 ` Patchwork
2023-03-13 9:10 ` [Intel-gfx] [PATCH 1/3] " Ville Syrjälä
5 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-03-07 12:01 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 42179 bytes --]
== Series Details ==
Series: series starting with [1/3] drm/i915: Remove redundant check for DG1
URL : https://patchwork.freedesktop.org/series/114735/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12818_full -> Patchwork_114735v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (10 -> 11)
------------------------------
Additional (1): shard-tglu-9
Known issues
------------
Here are the changes found in Patchwork_114735v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@api_intel_bb@crc32:
- shard-tglu-10: NOTRUN -> [SKIP][1] ([i915#6230])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@api_intel_bb@crc32.html
* igt@device_reset@unbind-cold-reset-rebind:
- shard-tglu-10: NOTRUN -> [SKIP][2] ([i915#7701])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@device_reset@unbind-cold-reset-rebind.html
* igt@drm_buddy@all-tests:
- shard-tglu-10: NOTRUN -> [SKIP][3] ([i915#6433]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@drm_buddy@all-tests.html
* igt@drm_read@invalid-buffer:
- shard-tglu-9: NOTRUN -> [SKIP][4] ([i915#1845]) +17 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@drm_read@invalid-buffer.html
* igt@fbdev@eof:
- shard-tglu-9: NOTRUN -> [SKIP][5] ([i915#2582]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@fbdev@eof.html
* igt@feature_discovery@display-2x:
- shard-tglu-9: NOTRUN -> [SKIP][6] ([i915#1839])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@feature_discovery@display-2x.html
* igt@feature_discovery@display-3x:
- shard-tglu-10: NOTRUN -> [SKIP][7] ([i915#1839])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@feature_discovery@display-3x.html
* igt@gem_basic@multigpu-create-close:
- shard-tglu-10: NOTRUN -> [SKIP][8] ([i915#7697])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@gem_basic@multigpu-create-close.html
* igt@gem_ccs@block-copy-inplace:
- shard-tglu-9: NOTRUN -> [SKIP][9] ([i915#3555] / [i915#5325])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@gem_ccs@block-copy-inplace.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [PASS][10] -> [FAIL][11] ([i915#2842])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12818/shard-apl2/igt@gem_exec_fair@basic-none-solo@rcs0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-apl3/igt@gem_exec_fair@basic-none-solo@rcs0.html
- shard-tglu-10: NOTRUN -> [FAIL][12] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-tglu-9: NOTRUN -> [FAIL][13] ([i915#2842]) +4 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_exec_params@secure-non-master:
- shard-tglu-10: NOTRUN -> [SKIP][14] ([fdo#112283])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@gem_exec_params@secure-non-master.html
* igt@gem_exec_params@secure-non-root:
- shard-tglu-9: NOTRUN -> [SKIP][15] ([fdo#112283])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@gem_exec_params@secure-non-root.html
* igt@gem_lmem_swapping@heavy-verify-multi:
- shard-tglu-10: NOTRUN -> [SKIP][16] ([i915#4613]) +3 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@gem_lmem_swapping@heavy-verify-multi.html
* igt@gem_lmem_swapping@heavy-verify-random:
- shard-tglu-9: NOTRUN -> [SKIP][17] ([i915#4613])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@gem_lmem_swapping@heavy-verify-random.html
* igt@gem_lmem_swapping@parallel-multi:
- shard-glk: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#4613]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-glk1/igt@gem_lmem_swapping@parallel-multi.html
* igt@gem_mmap_gtt@coherency:
- shard-tglu-10: NOTRUN -> [SKIP][19] ([fdo#111656])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@gem_mmap_gtt@coherency.html
* igt@gem_pread@exhaustion:
- shard-tglu-9: NOTRUN -> [WARN][20] ([i915#2658])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@gem_pread@exhaustion.html
* igt@gem_pxp@create-protected-buffer:
- shard-tglu-9: NOTRUN -> [SKIP][21] ([i915#4270]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@gem_pxp@create-protected-buffer.html
* igt@gem_pxp@reject-modify-context-protection-on:
- shard-tglu-10: NOTRUN -> [SKIP][22] ([i915#4270]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@gem_pxp@reject-modify-context-protection-on.html
* igt@gem_userptr_blits@access-control:
- shard-tglu-10: NOTRUN -> [SKIP][23] ([i915#3297]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@gem_userptr_blits@access-control.html
* igt@gem_userptr_blits@create-destroy-unsync:
- shard-tglu-9: NOTRUN -> [SKIP][24] ([i915#3297])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@gem_userptr_blits@create-destroy-unsync.html
* igt@gem_userptr_blits@vma-merge:
- shard-tglu-10: NOTRUN -> [FAIL][25] ([i915#3318])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@gem_userptr_blits@vma-merge.html
* igt@gen7_exec_parse@basic-allowed:
- shard-tglu-9: NOTRUN -> [SKIP][26] ([fdo#109289]) +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@gen7_exec_parse@basic-allowed.html
* igt@gen9_exec_parse@basic-rejected-ctx-param:
- shard-tglu-10: NOTRUN -> [SKIP][27] ([i915#2527] / [i915#2856]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@gen9_exec_parse@basic-rejected-ctx-param.html
* igt@gen9_exec_parse@bb-chained:
- shard-tglu-9: NOTRUN -> [SKIP][28] ([i915#2527] / [i915#2856]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@gen9_exec_parse@bb-chained.html
* igt@i915_module_load@load:
- shard-tglu-10: NOTRUN -> [SKIP][29] ([i915#6227])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@i915_module_load@load.html
* igt@i915_pm_backlight@fade:
- shard-tglu-10: NOTRUN -> [SKIP][30] ([i915#7561])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@i915_pm_backlight@fade.html
* igt@i915_pm_lpsp@screens-disabled:
- shard-tglu-10: NOTRUN -> [SKIP][31] ([i915#1902])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@i915_pm_lpsp@screens-disabled.html
* igt@i915_pm_rc6_residency@media-rc6-accuracy:
- shard-tglu-10: NOTRUN -> [SKIP][32] ([fdo#109289]) +2 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@i915_pm_rc6_residency@media-rc6-accuracy.html
* igt@i915_pm_rpm@dpms-mode-unset-lpsp:
- shard-tglu-9: NOTRUN -> [SKIP][33] ([i915#1397])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
* igt@i915_pm_rpm@drm-resources-equal:
- shard-tglu-9: NOTRUN -> [SKIP][34] ([i915#3547])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@i915_pm_rpm@drm-resources-equal.html
* igt@i915_pm_rpm@i2c:
- shard-glk: NOTRUN -> [FAIL][35] ([i915#8275])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-glk1/igt@i915_pm_rpm@i2c.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress:
- shard-tglu-9: NOTRUN -> [SKIP][36] ([fdo#111644] / [i915#1397])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
* igt@i915_pm_rpm@pc8-residency:
- shard-tglu-10: NOTRUN -> [SKIP][37] ([fdo#109506])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@i915_pm_rpm@pc8-residency.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-tglu-10: NOTRUN -> [SKIP][38] ([i915#5286]) +3 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_big_fb@x-tiled-8bpp-rotate-90:
- shard-tglu-10: NOTRUN -> [SKIP][39] ([fdo#111614]) +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_big_fb@x-tiled-8bpp-rotate-90.html
* igt@kms_big_fb@yf-tiled-32bpp-rotate-0:
- shard-tglu-9: NOTRUN -> [SKIP][40] ([fdo#111615] / [i915#1845] / [i915#7651]) +9 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@kms_big_fb@yf-tiled-32bpp-rotate-0.html
* igt@kms_big_fb@yf-tiled-addfb-size-offset-overflow:
- shard-tglu-10: NOTRUN -> [SKIP][41] ([fdo#111615]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_big_fb@yf-tiled-addfb-size-offset-overflow.html
* igt@kms_big_joiner@2x-modeset:
- shard-tglu-9: NOTRUN -> [SKIP][42] ([i915#2705])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@kms_big_joiner@2x-modeset.html
* igt@kms_big_joiner@basic:
- shard-tglu-10: NOTRUN -> [SKIP][43] ([i915#2705])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_big_joiner@basic.html
* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#3886])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-apl6/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#3886]) +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-glk3/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_dg2_mc_ccs:
- shard-tglu-10: NOTRUN -> [SKIP][46] ([i915#6095]) +2 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_dg2_mc_ccs.html
* igt@kms_ccs@pipe-a-crc-primary-basic-yf_tiled_ccs:
- shard-tglu-10: NOTRUN -> [SKIP][47] ([fdo#111615] / [i915#3689])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_ccs@pipe-a-crc-primary-basic-yf_tiled_ccs.html
* igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_ccs:
- shard-tglu-10: NOTRUN -> [SKIP][48] ([i915#3689]) +7 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_ccs.html
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-tglu-10: NOTRUN -> [SKIP][49] ([i915#3689] / [i915#3886]) +3 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-random-ccs-data-4_tiled_dg2_rc_ccs:
- shard-tglu-9: NOTRUN -> [SKIP][50] ([i915#1845] / [i915#7651]) +60 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@kms_ccs@pipe-b-random-ccs-data-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs:
- shard-tglu-10: NOTRUN -> [SKIP][51] ([i915#3689] / [i915#6095]) +5 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][52] ([fdo#109271]) +12 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-apl6/igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_cdclk@mode-transition:
- shard-tglu-10: NOTRUN -> [SKIP][53] ([i915#3742])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_cdclk@mode-transition.html
* igt@kms_cdclk@mode-transition-all-outputs:
- shard-tglu-9: NOTRUN -> [SKIP][54] ([i915#3742]) +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@kms_cdclk@mode-transition-all-outputs.html
* igt@kms_chamelium_color@ctm-limited-range:
- shard-tglu-9: NOTRUN -> [SKIP][55] ([fdo#111827])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@kms_chamelium_color@ctm-limited-range.html
* igt@kms_chamelium_color@ctm-negative:
- shard-tglu-10: NOTRUN -> [SKIP][56] ([fdo#111827]) +2 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_chamelium_color@ctm-negative.html
* igt@kms_chamelium_hpd@dp-hpd-storm-disable:
- shard-tglu-9: NOTRUN -> [SKIP][57] ([i915#7828]) +6 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@kms_chamelium_hpd@dp-hpd-storm-disable.html
* igt@kms_chamelium_hpd@vga-hpd-enable-disable-mode:
- shard-tglu-10: NOTRUN -> [SKIP][58] ([i915#7828]) +3 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_chamelium_hpd@vga-hpd-enable-disable-mode.html
* igt@kms_color@ctm-0-25:
- shard-tglu-9: NOTRUN -> [SKIP][59] ([i915#3546])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@kms_color@ctm-0-25.html
* igt@kms_content_protection@atomic-dpms:
- shard-tglu-10: NOTRUN -> [SKIP][60] ([i915#6944] / [i915#7116] / [i915#7118])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_content_protection@atomic-dpms.html
* igt@kms_content_protection@dp-mst-lic-type-0:
- shard-tglu-10: NOTRUN -> [SKIP][61] ([i915#3116] / [i915#3299])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_content_protection@dp-mst-lic-type-0.html
* igt@kms_cursor_crc@cursor-sliding-512x512:
- shard-tglu-10: NOTRUN -> [SKIP][62] ([i915#3359])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_cursor_crc@cursor-sliding-512x512.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- shard-tglu-10: NOTRUN -> [SKIP][63] ([i915#4103])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-toggle:
- shard-tglu-10: NOTRUN -> [SKIP][64] ([fdo#109274]) +4 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_cursor_legacy@cursorb-vs-flipa-toggle.html
* igt@kms_dp_tiled_display@basic-test-pattern:
- shard-tglu-10: NOTRUN -> [SKIP][65] ([i915#426])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_dp_tiled_display@basic-test-pattern.html
* igt@kms_dp_tiled_display@basic-test-pattern-with-chamelium:
- shard-tglu-9: NOTRUN -> [SKIP][66] ([i915#3528])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@kms_dp_tiled_display@basic-test-pattern-with-chamelium.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][67] -> [FAIL][68] ([i915#4767])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12818/shard-apl4/igt@kms_fbcon_fbt@fbc-suspend.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-apl1/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_fbcon_fbt@psr-suspend:
- shard-tglu-9: NOTRUN -> [SKIP][69] ([i915#3469])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@kms_fbcon_fbt@psr-suspend.html
* igt@kms_flip@2x-absolute-wf_vblank-interruptible:
- shard-tglu-10: NOTRUN -> [SKIP][70] ([fdo#109274] / [i915#3637]) +8 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_flip@2x-absolute-wf_vblank-interruptible.html
* igt@kms_flip@2x-flip-vs-panning-vs-hang:
- shard-tglu-9: NOTRUN -> [SKIP][71] ([fdo#109274] / [i915#3637]) +5 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@kms_flip@2x-flip-vs-panning-vs-hang.html
* igt@kms_flip@plain-flip-fb-recreate:
- shard-tglu-9: NOTRUN -> [SKIP][72] ([i915#3637]) +6 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@kms_flip@plain-flip-fb-recreate.html
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-upscaling@pipe-a-valid-mode:
- shard-tglu-10: NOTRUN -> [SKIP][73] ([i915#2587] / [i915#2672]) +2 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-upscaling:
- shard-tglu-9: NOTRUN -> [SKIP][74] ([i915#3555]) +11 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-upscaling.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-tglu-9: NOTRUN -> [SKIP][75] ([i915#1849]) +54 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-mmap-wc:
- shard-tglu-10: NOTRUN -> [SKIP][76] ([fdo#109280]) +27 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-tglu-10: NOTRUN -> [SKIP][77] ([fdo#110189]) +23 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_plane@pixel-format-source-clamping@pipe-a-planes:
- shard-tglu-9: NOTRUN -> [SKIP][78] ([i915#1849] / [i915#3558]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@kms_plane@pixel-format-source-clamping@pipe-a-planes.html
* igt@kms_plane_alpha_blend@alpha-basic:
- shard-tglu-9: NOTRUN -> [SKIP][79] ([i915#7128] / [i915#7294])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@kms_plane_alpha_blend@alpha-basic.html
* igt@kms_plane_alpha_blend@alpha-transparent-fb@pipe-a-hdmi-a-1:
- shard-glk: NOTRUN -> [FAIL][80] ([i915#4573]) +1 similar issue
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-glk1/igt@kms_plane_alpha_blend@alpha-transparent-fb@pipe-a-hdmi-a-1.html
* igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-c-hdmi-a-1:
- shard-tglu-10: NOTRUN -> [SKIP][81] ([i915#5176]) +3 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-c-hdmi-a-1.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-75:
- shard-tglu-9: NOTRUN -> [SKIP][82] ([i915#3555] / [i915#6953]) +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-75.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-c-hdmi-a-1:
- shard-glk: NOTRUN -> [SKIP][83] ([fdo#109271]) +96 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-glk3/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-c-hdmi-a-1.html
* igt@kms_prime@basic-modeset-hybrid:
- shard-tglu-9: NOTRUN -> [SKIP][84] ([i915#6524]) +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@kms_prime@basic-modeset-hybrid.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf:
- shard-tglu-9: NOTRUN -> [SKIP][85] ([i915#658])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf.html
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-glk: NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#658]) +1 similar issue
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-glk1/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-tglu-10: NOTRUN -> [SKIP][87] ([fdo#111068] / [i915#658])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-tglu-9: NOTRUN -> [SKIP][88] ([fdo#111068] / [i915#658])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb:
- shard-tglu-10: NOTRUN -> [SKIP][89] ([i915#658])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb.html
* igt@kms_psr@cursor_mmap_cpu:
- shard-tglu-9: NOTRUN -> [SKIP][90] ([fdo#110189]) +3 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@kms_psr@cursor_mmap_cpu.html
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0:
- shard-tglu-10: NOTRUN -> [SKIP][91] ([fdo#111615] / [i915#5289])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0.html
* igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-b:
- shard-tglu-9: NOTRUN -> [SKIP][92] ([fdo#109274])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-b.html
* igt@kms_vrr@flip-dpms:
- shard-tglu-10: NOTRUN -> [SKIP][93] ([i915#3555]) +5 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@kms_vrr@flip-dpms.html
* igt@kms_writeback@writeback-invalid-parameters:
- shard-tglu-9: NOTRUN -> [SKIP][94] ([i915#2437])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@kms_writeback@writeback-invalid-parameters.html
* igt@perf@polling-small-buf:
- shard-tglu-9: NOTRUN -> [FAIL][95] ([i915#1722])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@perf@polling-small-buf.html
* igt@prime_vgem@fence-flip-hang:
- shard-tglu-9: NOTRUN -> [SKIP][96] ([fdo#109295])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@prime_vgem@fence-flip-hang.html
* igt@v3d/v3d_perfmon@get-values-invalid-perfmon:
- shard-tglu-10: NOTRUN -> [SKIP][97] ([fdo#109315] / [i915#2575]) +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@v3d/v3d_perfmon@get-values-invalid-perfmon.html
* igt@v3d/v3d_perfmon@get-values-invalid-pointer:
- shard-tglu-9: NOTRUN -> [SKIP][98] ([fdo#109315] / [i915#2575]) +1 similar issue
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@v3d/v3d_perfmon@get-values-invalid-pointer.html
* igt@vc4/vc4_purgeable_bo@mark-unpurgeable-twice:
- shard-tglu-10: NOTRUN -> [SKIP][99] ([i915#2575]) +5 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-10/igt@vc4/vc4_purgeable_bo@mark-unpurgeable-twice.html
* igt@vc4/vc4_wait_bo@used-bo-0ns:
- shard-tglu-9: NOTRUN -> [SKIP][100] ([i915#2575]) +7 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-9/igt@vc4/vc4_wait_bo@used-bo-0ns.html
#### Possible fixes ####
* igt@drm_fdinfo@virtual-idle:
- {shard-rkl}: [FAIL][101] ([i915#7742]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12818/shard-rkl-4/igt@drm_fdinfo@virtual-idle.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-rkl-2/igt@drm_fdinfo@virtual-idle.html
* igt@gem_partial_pwrite_pread@reads-uncached:
- {shard-rkl}: [SKIP][103] ([i915#3282]) -> [PASS][104] +3 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12818/shard-rkl-3/igt@gem_partial_pwrite_pread@reads-uncached.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-rkl-5/igt@gem_partial_pwrite_pread@reads-uncached.html
* igt@gem_set_tiling_vs_blt@tiled-to-untiled:
- {shard-rkl}: [SKIP][105] ([i915#3281]) -> [PASS][106] +5 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12818/shard-rkl-2/igt@gem_set_tiling_vs_blt@tiled-to-untiled.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-rkl-5/igt@gem_set_tiling_vs_blt@tiled-to-untiled.html
* igt@gen9_exec_parse@batch-invalid-length:
- {shard-rkl}: [SKIP][107] ([i915#2527]) -> [PASS][108] +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12818/shard-rkl-3/igt@gen9_exec_parse@batch-invalid-length.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-rkl-5/igt@gen9_exec_parse@batch-invalid-length.html
* igt@i915_pm_rpm@modeset-lpsp-stress-no-wait:
- {shard-tglu}: [SKIP][109] ([i915#1397]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12818/shard-tglu-6/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-1/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
* igt@i915_selftest@live@gt_pm:
- {shard-rkl}: [DMESG-FAIL][111] ([i915#4258]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12818/shard-rkl-2/igt@i915_selftest@live@gt_pm.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-rkl-5/igt@i915_selftest@live@gt_pm.html
* igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_rc_ccs:
- {shard-rkl}: [SKIP][113] ([i915#1845] / [i915#4098]) -> [PASS][114] +5 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12818/shard-rkl-3/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_rc_ccs.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-rkl-6/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_rc_ccs.html
* igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_rc_ccs_cc:
- {shard-tglu}: [SKIP][115] ([i915#1845] / [i915#7651]) -> [PASS][116] +7 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12818/shard-tglu-6/igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-1/igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- {shard-tglu}: [SKIP][117] ([i915#1845]) -> [PASS][118] +1 similar issue
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12818/shard-tglu-6/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-1/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
* igt@kms_flip@flip-vs-suspend-interruptible@b-dp1:
- shard-apl: [ABORT][119] ([i915#180]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12818/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible@b-dp1.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible@b-dp1.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
- {shard-tglu}: [SKIP][121] ([i915#1849]) -> [PASS][122] +3 similar issues
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12818/shard-tglu-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-tglu-1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-blt:
- {shard-rkl}: [SKIP][123] ([i915#1849] / [i915#4098]) -> [PASS][124] +6 similar issues
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12818/shard-rkl-3/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-blt.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-blt.html
* igt@kms_psr@cursor_plane_move:
- {shard-rkl}: [SKIP][125] ([i915#1072]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12818/shard-rkl-3/igt@kms_psr@cursor_plane_move.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-rkl-6/igt@kms_psr@cursor_plane_move.html
* igt@perf@mi-rpc:
- {shard-rkl}: [SKIP][127] ([i915#2434]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12818/shard-rkl-2/igt@perf@mi-rpc.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/shard-rkl-5/igt@perf@mi-rpc.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2232]: https://gitlab.freedesktop.org/drm/intel/issues/2232
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3547]: https://gitlab.freedesktop.org/drm/intel/issues/3547
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3639]: https://gitlab.freedesktop.org/drm/intel/issues/3639
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4879]: https://gitlab.freedesktop.org/drm/intel/issues/4879
[i915#5115]: https://gitlab.freedesktop.org/drm/intel/issues/5115
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
[i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
[i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957
[i915#8152]: https://gitlab.freedesktop.org/drm/intel/issues/8152
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8275]: https://gitlab.freedesktop.org/drm/intel/issues/8275
Build changes
-------------
* Linux: CI_DRM_12818 -> Patchwork_114735v1
CI-20190529: 20190529
CI_DRM_12818: fe02c0851ac36ad0d4e8c2a66a4dc2f45e49b91e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7181: f44a24fe9f1948a117daf3162db53df7820f9923 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_114735v1: fe02c0851ac36ad0d4e8c2a66a4dc2f45e49b91e @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114735v1/index.html
[-- Attachment #2: Type: text/html, Size: 44949 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH 1/3] drm/i915: Remove redundant check for DG1
2023-03-06 20:49 [Intel-gfx] [PATCH 1/3] drm/i915: Remove redundant check for DG1 Lucas De Marchi
` (4 preceding siblings ...)
2023-03-07 12:01 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] " Patchwork
@ 2023-03-13 9:10 ` Ville Syrjälä
2023-03-13 13:23 ` Lucas De Marchi
5 siblings, 1 reply; 12+ messages in thread
From: Ville Syrjälä @ 2023-03-13 9:10 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx, dri-devel
On Mon, Mar 06, 2023 at 12:49:52PM -0800, Lucas De Marchi wrote:
> dg1_gt_workarounds_init() is only ever called for DG1, so there is no
> point checking it again.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> index 32aa1647721a..eb6cc4867d67 100644
> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> @@ -1472,21 +1472,15 @@ gen12_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
> static void
> dg1_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
> {
> - struct drm_i915_private *i915 = gt->i915;
> -
Looks like you pushed some stale version of this patch which
didn't remove this variable. Now the CONFIG_DRM_I915_WERROR=y
build is broken.
Did you lose that from your pre-push build .config?
> gen12_gt_workarounds_init(gt, wal);
>
> /* Wa_1409420604:dg1 */
> - if (IS_DG1(i915))
> - wa_mcr_write_or(wal,
> - SUBSLICE_UNIT_LEVEL_CLKGATE2,
> - CPSSUNIT_CLKGATE_DIS);
> + wa_mcr_write_or(wal, SUBSLICE_UNIT_LEVEL_CLKGATE2,
> + CPSSUNIT_CLKGATE_DIS);
>
> /* Wa_1408615072:dg1 */
> /* Empirical testing shows this register is unaffected by engine reset. */
> - if (IS_DG1(i915))
> - wa_write_or(wal, UNSLICE_UNIT_LEVEL_CLKGATE2,
> - VSUNIT_CLKGATE_DIS_TGL);
> + wa_write_or(wal, UNSLICE_UNIT_LEVEL_CLKGATE2, VSUNIT_CLKGATE_DIS_TGL);
> }
>
> static void
> --
> 2.39.0
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH 1/3] drm/i915: Remove redundant check for DG1
2023-03-13 9:10 ` [Intel-gfx] [PATCH 1/3] " Ville Syrjälä
@ 2023-03-13 13:23 ` Lucas De Marchi
2023-03-13 13:32 ` Ville Syrjälä
0 siblings, 1 reply; 12+ messages in thread
From: Lucas De Marchi @ 2023-03-13 13:23 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx, dri-devel
On Mon, Mar 13, 2023 at 11:10:26AM +0200, Ville Syrjälä wrote:
>On Mon, Mar 06, 2023 at 12:49:52PM -0800, Lucas De Marchi wrote:
>> dg1_gt_workarounds_init() is only ever called for DG1, so there is no
>> point checking it again.
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>> ---
>> drivers/gpu/drm/i915/gt/intel_workarounds.c | 12 +++---------
>> 1 file changed, 3 insertions(+), 9 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> index 32aa1647721a..eb6cc4867d67 100644
>> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> @@ -1472,21 +1472,15 @@ gen12_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
>> static void
>> dg1_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
>> {
>> - struct drm_i915_private *i915 = gt->i915;
>> -
>
>Looks like you pushed some stale version of this patch which
>didn't remove this variable. Now the CONFIG_DRM_I915_WERROR=y
>build is broken.
>
>Did you lose that from your pre-push build .config?
no, looks like a conflict between drm-intel-gt-next and drm-intel-next
69ea87e1591a ("drm/i915/dg1: Drop support for pre-production steppings")
merged in drm-intel-next dropped the only user.
This patch was merged in drm-intel-gt-next and I didn't realize the
race was with the other branch rather than with the same branch due to
taking a long time for me to apply. Let me rebuild drm-tip to fix it up.
Lucas De Marchi
>
>> gen12_gt_workarounds_init(gt, wal);
>>
>> /* Wa_1409420604:dg1 */
>> - if (IS_DG1(i915))
>> - wa_mcr_write_or(wal,
>> - SUBSLICE_UNIT_LEVEL_CLKGATE2,
>> - CPSSUNIT_CLKGATE_DIS);
>> + wa_mcr_write_or(wal, SUBSLICE_UNIT_LEVEL_CLKGATE2,
>> + CPSSUNIT_CLKGATE_DIS);
>>
>> /* Wa_1408615072:dg1 */
>> /* Empirical testing shows this register is unaffected by engine reset. */
>> - if (IS_DG1(i915))
>> - wa_write_or(wal, UNSLICE_UNIT_LEVEL_CLKGATE2,
>> - VSUNIT_CLKGATE_DIS_TGL);
>> + wa_write_or(wal, UNSLICE_UNIT_LEVEL_CLKGATE2, VSUNIT_CLKGATE_DIS_TGL);
>> }
>>
>> static void
>> --
>> 2.39.0
>
>--
>Ville Syrjälä
>Intel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH 1/3] drm/i915: Remove redundant check for DG1
2023-03-13 13:23 ` Lucas De Marchi
@ 2023-03-13 13:32 ` Ville Syrjälä
0 siblings, 0 replies; 12+ messages in thread
From: Ville Syrjälä @ 2023-03-13 13:32 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx, dri-devel
On Mon, Mar 13, 2023 at 06:23:59AM -0700, Lucas De Marchi wrote:
> On Mon, Mar 13, 2023 at 11:10:26AM +0200, Ville Syrjälä wrote:
> >On Mon, Mar 06, 2023 at 12:49:52PM -0800, Lucas De Marchi wrote:
> >> dg1_gt_workarounds_init() is only ever called for DG1, so there is no
> >> point checking it again.
> >>
> >> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> >> ---
> >> drivers/gpu/drm/i915/gt/intel_workarounds.c | 12 +++---------
> >> 1 file changed, 3 insertions(+), 9 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> >> index 32aa1647721a..eb6cc4867d67 100644
> >> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> >> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> >> @@ -1472,21 +1472,15 @@ gen12_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
> >> static void
> >> dg1_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
> >> {
> >> - struct drm_i915_private *i915 = gt->i915;
> >> -
> >
> >Looks like you pushed some stale version of this patch which
> >didn't remove this variable. Now the CONFIG_DRM_I915_WERROR=y
> >build is broken.
> >
> >Did you lose that from your pre-push build .config?
>
> no, looks like a conflict between drm-intel-gt-next and drm-intel-next
>
> 69ea87e1591a ("drm/i915/dg1: Drop support for pre-production steppings")
> merged in drm-intel-next dropped the only user.
>
> This patch was merged in drm-intel-gt-next and I didn't realize the
> race was with the other branch rather than with the same branch due to
> taking a long time for me to apply. Let me rebuild drm-tip to fix it up.
I already fixed it. Just forgot to note that here.
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-03-13 13:33 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-06 20:49 [Intel-gfx] [PATCH 1/3] drm/i915: Remove redundant check for DG1 Lucas De Marchi
2023-03-06 20:49 ` [Intel-gfx] [PATCH 2/3] drm/i915: Move DG2 tuning to the right function Lucas De Marchi
2023-03-06 23:16 ` Matt Roper
2023-03-06 20:49 ` [Intel-gfx] [PATCH 3/3] drm/i915/dg1: Move Wa_1806527549 " Lucas De Marchi
2023-03-06 23:17 ` Matt Roper
2023-03-06 23:53 ` Lucas De Marchi
2023-03-06 23:11 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Remove redundant check for DG1 Patchwork
2023-03-06 23:15 ` [Intel-gfx] [PATCH 1/3] " Matt Roper
2023-03-07 12:01 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] " Patchwork
2023-03-13 9:10 ` [Intel-gfx] [PATCH 1/3] " Ville Syrjälä
2023-03-13 13:23 ` Lucas De Marchi
2023-03-13 13:32 ` Ville Syrjälä
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).