From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0068FC61DA3 for ; Sat, 4 Mar 2023 03:24:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D676510E027; Sat, 4 Mar 2023 03:24:33 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id E8F4010E027; Sat, 4 Mar 2023 03:24:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677900271; x=1709436271; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=1KhX4C4ue2ypwhUmXZVCM3dtb9eBp/AxvL/3g3Med/g=; b=Ty6R6XfNHXqOt1+nzSzpEcHS+ptiVw+HlcJ12lb0YmItAW88j0DijoT9 +XsjsnG6l+Bpaxph3/yLoKQ139IXTN/GbiA81MddCokhmoXY2zq4RyB2r pAM23N9lOwkMfzOEBj0hJl/Afq3oyfmEIKK4D+yMa+1bcBuZoMDng0DUx 8OO/7ltjKJFT9v5tO3Ux4MEDFykFJhMnZ0d3KXcG/EFk8EOQYexhBFrWF R0QXK3e8L2DS2oYreZUgKAasTPPav2oCZhPebu9iMuJX/Vn6WXIo9NxWv z02/EwezTgXzEnKF6FWY6qEpbLFId0hsTFIVgK02lbQhs6Cu7a0Q9cgM3 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10638"; a="319041683" X-IronPort-AV: E=Sophos;i="5.98,232,1673942400"; d="scan'208";a="319041683" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2023 19:24:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10638"; a="708056020" X-IronPort-AV: E=Sophos;i="5.98,232,1673942400"; d="scan'208";a="708056020" Received: from lgieryk-mobl1.ger.corp.intel.com (HELO intel.com) ([10.252.32.187]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2023 19:24:29 -0800 Date: Sat, 4 Mar 2023 04:24:26 +0100 From: Andi Shyti To: "Sripada, Radhakrishna" Message-ID: References: <20230301110258.2140955-1-andi.shyti@linux.intel.com> <20230301110258.2140955-2-andi.shyti@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "Patelczyk, Maciej" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Mar 01, 2023 at 09:35:33PM +0000, Sripada, Radhakrishna wrote: > I am not sure if Tiles is appropriate usage here. Since MTL does not have the concept of tiles. > Shouldn't we be using gt instead of tile in our usage? > > With s/tile/gt/g, > Reviewed-by: Radhakrishna Sripada Just one question... you reviewed twice Patch number 1. Did you mean to review patch 1 and patch 2? Thanks, Andi > > > -----Original Message----- > > From: dri-devel On Behalf Of Andi > > Shyti > > Sent: Wednesday, March 1, 2023 3:03 AM > > To: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org > > Cc: Tvrtko Ursulin ; Andi Shyti > > ; Patelczyk, Maciej ; Andi > > Shyti ; Wajdeczko, Michal > > > > Subject: [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files > > > > To support multi-GT configurations, we need to generate > > independent debug files for each GT. > > > > To achieve this create a separate directory for each GT under the > > debugfs directory. For instance, in a system with two tiles, the > > debugfs structure would look like this: > > > > /sys/kernel/debug/dri > > └── 0 > >    ├── gt0 > >    │   ├── drpc > >    │   ├── engines > >    │   ├── forcewake > >    │   ├── frequency > >    │   └── rps_boost > >    └── gt1 > >    :   ├── drpc > >    :   ├── engines > >    :   ├── forcewake > >       ├── frequency > >       └── rps_boost > > > > Signed-off-by: Andi Shyti > > Cc: Tvrtko Ursulin > > --- > > drivers/gpu/drm/i915/gt/intel_gt_debugfs.c | 4 +++- > > drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 ++ > > drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 5 ++++- > > drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c | 2 ++ > > 4 files changed, 11 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c > > b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c > > index 5fc2df01aa0df..4dc23b8d3aa2d 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c > > +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c > > @@ -83,11 +83,13 @@ static void gt_debugfs_register(struct intel_gt *gt, > > struct dentry *root) > > void intel_gt_debugfs_register(struct intel_gt *gt) > > { > > struct dentry *root; > > + char gtname[4]; > > > > if (!gt->i915->drm.primary->debugfs_root) > > return; > > > > - root = debugfs_create_dir("gt", gt->i915->drm.primary->debugfs_root); > > + snprintf(gtname, sizeof(gtname), "gt%u", gt->info.id); > > + root = debugfs_create_dir(gtname, gt->i915->drm.primary- > > >debugfs_root); > > if (IS_ERR(root)) > > return; > > > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.h > > b/drivers/gpu/drm/i915/gt/uc/intel_guc.h > > index bb4dfe707a7d0..e46aac1a41e6d 100644 > > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h > > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h > > @@ -42,6 +42,8 @@ struct intel_guc { > > /** @capture: the error-state-capture module's data and objects */ > > struct intel_guc_state_capture *capture; > > > > + struct dentry *dbgfs_node; > > + > > /** @sched_engine: Global engine used to submit requests to GuC */ > > struct i915_sched_engine *sched_engine; > > /** > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c > > b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c > > index 195db8c9d4200..55bc8b55fbc05 100644 > > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c > > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c > > @@ -542,8 +542,11 @@ static int guc_log_relay_create(struct intel_guc_log > > *log) > > */ > > n_subbufs = 8; > > > > + if (!guc->dbgfs_node) > > + return -ENOENT; > > + > > guc_log_relay_chan = relay_open("guc_log", > > - i915->drm.primary->debugfs_root, > > + guc->dbgfs_node, > > subbuf_size, n_subbufs, > > &relay_callbacks, i915); > > if (!guc_log_relay_chan) { > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c > > b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c > > index 284d6fbc2d08c..2f93cc4e408a8 100644 > > --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c > > +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c > > @@ -54,6 +54,8 @@ void intel_uc_debugfs_register(struct intel_uc *uc, struct > > dentry *gt_root) > > if (IS_ERR(root)) > > return; > > > > + uc->guc.dbgfs_node = root; > > + > > intel_gt_debugfs_register_files(root, files, ARRAY_SIZE(files), uc); > > > > intel_guc_debugfs_register(&uc->guc, root); > > -- > > 2.39.1 >