intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Nicolin Chen <nicolinc@nvidia.com>
To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
Cc: "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	"Hao, Xudong" <xudong.hao@intel.com>,
	"peterx@redhat.com" <peterx@redhat.com>,
	"Xu, Terrence" <terrence.xu@intel.com>,
	"chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
	"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
	"Liu, Yi L" <yi.l.liu@intel.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"lulu@redhat.com" <lulu@redhat.com>,
	"joro@8bytes.org" <joro@8bytes.org>,
	Jason Gunthorpe <jgg@nvidia.com>,
	"Zhao, Yan Y" <yan.y.zhao@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"eric.auger@redhat.com" <eric.auger@redhat.com>,
	"intel-gvt-dev@lists.freedesktop.org"
	<intel-gvt-dev@lists.freedesktop.org>,
	"yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
	"cohuck@redhat.com" <cohuck@redhat.com>,
	"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
	"robin.murphy@arm.com" <robin.murphy@arm.com>
Subject: Re: [Intel-gfx] [PATCH v5 00/19] Add vfio_device cdev for iommufd support
Date: Fri, 3 Mar 2023 23:00:52 -0800	[thread overview]
Message-ID: <ZALspPvvLGFuK96F@Asurada-Nvidia> (raw)
In-Reply-To: <d59a0262d5bf423c9e49ad4ac6015296@huawei.com>

On Fri, Mar 03, 2023 at 03:01:03PM +0000, Shameerali Kolothum Thodi wrote:
> External email: Use caution opening links or attachments
> 
> 
> > -----Original Message-----
> > From: Nicolin Chen [mailto:nicolinc@nvidia.com]
> > Sent: 02 March 2023 23:51
> > To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
> > Cc: Xu, Terrence <terrence.xu@intel.com>; Liu, Yi L <yi.l.liu@intel.com>;
> > Jason Gunthorpe <jgg@nvidia.com>; alex.williamson@redhat.com; Tian,
> > Kevin <kevin.tian@intel.com>; joro@8bytes.org; robin.murphy@arm.com;
> > cohuck@redhat.com; eric.auger@redhat.com; kvm@vger.kernel.org;
> > mjrosato@linux.ibm.com; chao.p.peng@linux.intel.com;
> > yi.y.sun@linux.intel.com; peterx@redhat.com; jasowang@redhat.com;
> > lulu@redhat.com; suravee.suthikulpanit@amd.com;
> > intel-gvt-dev@lists.freedesktop.org; intel-gfx@lists.freedesktop.org;
> > linux-s390@vger.kernel.org; Hao, Xudong <xudong.hao@intel.com>; Zhao,
> > Yan Y <yan.y.zhao@intel.com>
> > Subject: Re: [PATCH v5 00/19] Add vfio_device cdev for iommufd support
> >
> > On Thu, Mar 02, 2023 at 09:43:00AM +0000, Shameerali Kolothum Thodi
> > wrote:
> >
> > > Hi Nicolin,
> > >
> > > Thanks for the latest ARM64 branch. Do you have a working Qemu branch
> > corresponding to the
> > > above one?
> > >
> > > I tried the
> > https://github.com/nicolinc/qemu/tree/wip/iommufd_rfcv3%2Bnesting%2B
> > smmuv3
> > > but for some reason not able to launch the Guest.
> > >
> > > Please let me know.
> >
> > I do use that branch. It might not be that robust though as it
> > went through a big rebase.
> 
> Ok. The issue seems to be quite random in nature and only happens when there
> are multiple vCPUs. Also doesn't look like related to VFIO device assignment
> as I can reproduce Guest hang without it by only having nested-smmuv3 and
> iommufd object.
> 
> ./qemu-system-aarch64-iommuf -machine virt,gic-version=3,iommu=nested-smmuv3,iommufd=iommufd0 \
> -enable-kvm -cpu host -m 1G -smp cpus=8,maxcpus=8 \
> -object iommufd,id=iommufd0 \
> -bios QEMU_EFI.fd \
> -kernel Image-6.2-iommufd \
> -initrd rootfs-iperf.cpio \
> -net none \
> -nographic \
> -append "rdinit=init console=ttyAMA0 root=/dev/vda rw earlycon=pl011,0x9000000" \
> -trace events=events \
> -D trace_iommufd
> 
> When the issue happens, no output on terminal as if Qemu is in a locked state.
> 
>  Can you try with the followings?
> >
> > --trace "iommufd*" --trace "smmu*" --trace "vfio_*" --trace "pci_*" --trace
> > "msi_*" --trace "nvme_*"
> 
> The only trace events with above are this,
> 
> iommufd_backend_connect fd=22 owned=1 users=1 (0)
> smmu_add_mr smmuv3-iommu-memory-region-0-0
> 
> I haven't debugged this further. Please let me know if issue is reproducible
> with multiple vCPUs at your end. For now will focus on VFIO dev specific tests.

Oh. My test environment has been a single-core vCPU. So that
doesn't happen to me. Can you try a vanilla QEMU branch that
our nesting branch is rebased on? I took a branch from Yi as
the baseline, while he might take from Eric for the rfcv3.

I am guessing that it might be an issue in the common tree.

Thanks
Nicolin

  reply	other threads:[~2023-03-04  7:01 UTC|newest]

Thread overview: 131+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-27 11:11 [Intel-gfx] [PATCH v5 00/19] Add vfio_device cdev for iommufd support Yi Liu
2023-02-27 11:11 ` [Intel-gfx] [PATCH v5 01/19] vfio: Allocate per device file structure Yi Liu
2023-02-27 18:46   ` Jason Gunthorpe
2023-02-27 11:11 ` [Intel-gfx] [PATCH v5 02/19] vfio: Refine vfio file kAPIs for KVM Yi Liu
2023-02-27 18:46   ` Jason Gunthorpe
2023-02-27 11:11 ` [Intel-gfx] [PATCH v5 03/19] vfio: Accept vfio device file in the KVM facing kAPI Yi Liu
2023-02-27 18:46   ` Jason Gunthorpe
2023-02-27 11:11 ` [Intel-gfx] [PATCH v5 04/19] kvm/vfio: Rename kvm_vfio_group to prepare for accepting vfio device fd Yi Liu
2023-02-27 18:47   ` Jason Gunthorpe
2023-02-27 11:11 ` [Intel-gfx] [PATCH v5 05/19] kvm/vfio: Accept vfio device file from userspace Yi Liu
2023-02-27 18:47   ` Jason Gunthorpe
2023-02-27 11:11 ` [Intel-gfx] [PATCH v5 06/19] vfio: Pass struct vfio_device_file * to vfio_device_open/close() Yi Liu
2023-02-27 18:47   ` Jason Gunthorpe
2023-02-27 11:11 ` [Intel-gfx] [PATCH v5 07/19] vfio: Block device access via device fd until device is opened Yi Liu
2023-02-27 18:48   ` Jason Gunthorpe
2023-03-01  9:22   ` Liu, Yi L
2023-02-27 11:11 ` [Intel-gfx] [PATCH v5 08/19] vfio/pci: Update comment around group_fd get in vfio_pci_ioctl_pci_hot_reset() Yi Liu
2023-02-27 18:48   ` Jason Gunthorpe
2023-02-27 11:11 ` [Intel-gfx] [PATCH v5 09/19] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET Yi Liu
2023-02-27 18:22   ` Jason Gunthorpe
2023-02-28  2:31     ` Liu, Yi L
2023-03-02  6:07   ` Liu, Yi L
2023-03-02  9:55     ` Tian, Kevin
2023-03-02 12:35       ` Jason Gunthorpe
2023-03-02 14:20         ` Liu, Yi L
2023-03-03  6:36           ` Tian, Kevin
2023-03-03 16:55             ` Alex Williamson
2023-03-05 14:48               ` Liu, Yi L
2023-03-06  8:16                 ` Tian, Kevin
2023-03-06  8:23                   ` Tian, Kevin
2023-03-06  8:33                     ` Liu, Yi L
2023-03-06  9:59                 ` Liu, Yi L
2023-03-06 13:16               ` Jason Gunthorpe
2023-03-07  2:31                 ` Tian, Kevin
2023-03-07  2:35                   ` Liu, Yi L
2023-03-07 12:36                   ` Jason Gunthorpe
2023-03-07 13:28                     ` Liu, Yi L
2023-03-08  7:26                       ` Tian, Kevin
2023-03-08  7:47                         ` Liu, Yi L
2023-03-08  7:55                           ` Tian, Kevin
2023-03-08  8:00                             ` Liu, Yi L
2023-03-08  8:14                               ` Tian, Kevin
2023-03-08  8:15                                 ` Liu, Yi L
2023-03-08 15:08                         ` Jason Gunthorpe
2023-03-02 21:04     ` Alex Williamson
2023-02-27 11:11 ` [Intel-gfx] [PATCH v5 10/19] vfio: Add infrastructure for bind_iommufd from userspace Yi Liu
2023-02-27 18:29   ` Jason Gunthorpe
2023-02-28  2:35     ` Liu, Yi L
2023-02-28  6:58       ` Liu, Yi L
2023-02-28 12:31         ` Jason Gunthorpe
2023-02-28 12:45           ` Liu, Yi L
2023-02-28 12:52             ` Jason Gunthorpe
2023-02-28 12:56               ` Liu, Yi L
2023-02-28 12:58                 ` Jason Gunthorpe
2023-02-28 12:29       ` Jason Gunthorpe
2023-02-28 12:48         ` Liu, Yi L
2023-02-28 12:52           ` Jason Gunthorpe
2023-02-28 13:24             ` Liu, Yi L
2023-02-27 11:11 ` [Intel-gfx] [PATCH v5 11/19] vfio-iommufd: Add detach_ioas support for physical VFIO devices Yi Liu
2023-02-27 18:44   ` Jason Gunthorpe
2023-02-28  2:57     ` Liu, Yi L
2023-02-28 12:33       ` Jason Gunthorpe
2023-02-28 12:43         ` Liu, Yi L
2023-02-27 11:11 ` [Intel-gfx] [PATCH v5 12/19] vfio-iommufd: Add detach_ioas for emulated " Yi Liu
2023-02-27 18:45   ` Jason Gunthorpe
2023-02-27 11:11 ` [Intel-gfx] [PATCH v5 13/19] vfio: Add cdev_device_open_cnt to vfio_group Yi Liu
2023-02-27 19:20   ` Jason Gunthorpe
2023-02-27 11:11 ` [Intel-gfx] [PATCH v5 14/19] vfio: Make vfio_device_open() single open for device cdev path Yi Liu
2023-02-27 18:52   ` Jason Gunthorpe
2023-02-28  3:11     ` Liu, Yi L
2023-02-28 12:33       ` Jason Gunthorpe
2023-03-01 13:58         ` Liu, Yi L
2023-02-27 11:11 ` [Intel-gfx] [PATCH v5 15/19] vfio: Add cdev for vfio_device Yi Liu
2023-02-27 18:55   ` Jason Gunthorpe
2023-02-28  3:47     ` Liu, Yi L
2023-02-27 19:06   ` Jason Gunthorpe
2023-02-28  3:59     ` Liu, Yi L
2023-02-27 11:11 ` [Intel-gfx] [PATCH v5 16/19] vfio: Add VFIO_DEVICE_BIND_IOMMUFD Yi Liu
2023-02-27 19:19   ` Jason Gunthorpe
2023-02-28  4:08     ` Liu, Yi L
2023-03-01  9:19   ` Liu, Yi L
2023-03-01 17:46     ` Jason Gunthorpe
2023-03-02  4:09       ` Liu, Yi L
2023-03-03  6:57       ` Liu, Yi L
2023-03-03  7:23         ` Liu, Yi L
2023-03-07  6:38         ` Tian, Kevin
2023-03-07 12:37           ` Jason Gunthorpe
2023-03-07 13:03             ` Liu, Yi L
2023-03-08  7:17               ` Tian, Kevin
2023-03-10  2:39   ` Alexey Kardashevskiy
2023-03-10  5:49     ` Liu, Yi L
2023-02-27 11:11 ` [Intel-gfx] [PATCH v5 17/19] vfio: Add VFIO_DEVICE_AT[DE]TACH_IOMMUFD_PT Yi Liu
2023-02-27 18:39   ` Jason Gunthorpe
2023-02-28  2:51     ` Liu, Yi L
2023-02-28 12:32       ` Jason Gunthorpe
2023-02-28 12:42         ` Liu, Yi L
2023-02-28 12:53           ` Jason Gunthorpe
2023-02-28 13:22             ` Liu, Yi L
2023-02-28 13:25               ` Jason Gunthorpe
2023-02-28 13:36                 ` Liu, Yi L
2023-02-28 13:43                   ` Jason Gunthorpe
2023-02-28 14:01                     ` Liu, Yi L
2023-02-28 14:38                       ` Jason Gunthorpe
2023-03-01 14:04                         ` Liu, Yi L
2023-03-01 17:49                           ` Jason Gunthorpe
2023-03-02  3:24                             ` Liu, Yi L
2023-02-27 11:11 ` [Intel-gfx] [PATCH v5 18/19] vfio: Compile group optionally Yi Liu
2023-02-27 19:20   ` Jason Gunthorpe
2023-02-28  3:14     ` Liu, Yi L
2023-02-28  6:00   ` Liu, Yi L
2023-02-28 12:36     ` Jason Gunthorpe
2023-03-01 13:59       ` Liu, Yi L
2023-02-27 11:11 ` [Intel-gfx] [PATCH v5 19/19] docs: vfio: Add vfio device cdev description Yi Liu
2023-02-27 11:31 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Add vfio_device cdev for iommufd support (rev5) Patchwork
2023-02-27 19:21 ` [Intel-gfx] [PATCH v5 00/19] Add vfio_device cdev for iommufd support Jason Gunthorpe
2023-02-28  3:03   ` Liu, Yi L
2023-02-28 16:58     ` Xu, Terrence
2023-03-01  2:29       ` Nicolin Chen
2023-03-01  3:44         ` Liu, Yi L
2023-03-02  9:43         ` Shameerali Kolothum Thodi
2023-03-02 23:51           ` Nicolin Chen
2023-03-03 15:01             ` Shameerali Kolothum Thodi
2023-03-04  7:00               ` Nicolin Chen [this message]
2023-03-04  8:22                 ` Liu, Yi L
2023-03-08 15:54                 ` Shameerali Kolothum Thodi
2023-03-14 11:38                 ` Shameerali Kolothum Thodi
2023-03-15 23:22                   ` Nicolin Chen
2023-03-16  7:39                     ` Liu, Yi L
2023-03-03 21:29         ` Matthew Rosato
2023-03-01 21:01 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Add vfio_device cdev for iommufd support (rev6) Patchwork
2023-03-03  7:00 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Add vfio_device cdev for iommufd support (rev7) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZALspPvvLGFuK96F@Asurada-Nvidia \
    --to=nicolinc@nvidia.com \
    --cc=chao.p.peng@linux.intel.com \
    --cc=cohuck@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-gvt-dev@lists.freedesktop.org \
    --cc=jasowang@redhat.com \
    --cc=jgg@nvidia.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=lulu@redhat.com \
    --cc=mjrosato@linux.ibm.com \
    --cc=peterx@redhat.com \
    --cc=robin.murphy@arm.com \
    --cc=shameerali.kolothum.thodi@huawei.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=terrence.xu@intel.com \
    --cc=xudong.hao@intel.com \
    --cc=yan.y.zhao@intel.com \
    --cc=yi.l.liu@intel.com \
    --cc=yi.y.sun@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).