From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A17DBC61DA4 for ; Mon, 6 Mar 2023 14:21:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EA83110E262; Mon, 6 Mar 2023 14:21:12 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 72B1D10E248; Mon, 6 Mar 2023 14:21:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678112470; x=1709648470; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=+Pb6AyD5NP7ecElgY+FZDdO6Q/krNhLpqiR52gFnPko=; b=a6Mf8kAwcl4hyoxhw42733ORV3PAYrUVSw5+H04RW7OAmrifWNmNymSS PU5K3wIsldOVZrMAinWt/XAaFnpB11buiPqkabmaz6GBXMCZFxBsTDmF2 eM0kYj/VbnBnKpQSV9vzonsXbU+2kp8WLd7aUtb6PhK2TaW82cXhbPoP4 JUa3whGdiW4ZfKSnhUmTy//c1O1gZmAmi7dJXrAjnUphvZHXCN7b+Y4HG lEzptbAvz5G9rP1c4DfINjfMX3kqvIoltmnh2l8ozX3zKVLKqVO3HAY6e yMZuJ/ifgJZCjBQUoKSUYpeWtdZcGWuzGq8x/Ibg9+ACpakI4vn2YWi46 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="315959358" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="315959358" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2023 06:21:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="745073532" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="745073532" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.70]) by fmsmga004.fm.intel.com with SMTP; 06 Mar 2023 06:21:07 -0800 Received: by stinkbox (sSMTP sendmail emulation); Mon, 06 Mar 2023 16:21:06 +0200 Date: Mon, 6 Mar 2023 16:21:06 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Nirmoy Das Message-ID: References: <20230306102850.18299-1-nirmoy.das@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230306102850.18299-1-nirmoy.das@intel.com> X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH 1/3] drm/i915: Set I915_BO_ALLOC_USER for framebuffer X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Mar 06, 2023 at 11:28:48AM +0100, Nirmoy Das wrote: > Framebuffer is exposed to userspace so set I915_BO_ALLOC_USER > flag for it. This also make sure that ttm allocates offset > for lmem objects. I have no idea what that means. > > Signed-off-by: Nirmoy Das > --- > drivers/gpu/drm/i915/display/intel_dpt.c | 4 +++- > drivers/gpu/drm/i915/display/intel_fbdev.c | 3 ++- > drivers/gpu/drm/i915/display/intel_plane_initial.c | 3 ++- > 3 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dpt.c b/drivers/gpu/drm/i915/display/intel_dpt.c > index ad1a37b515fb..2e6238881860 100644 > --- a/drivers/gpu/drm/i915/display/intel_dpt.c > +++ b/drivers/gpu/drm/i915/display/intel_dpt.c > @@ -254,7 +254,9 @@ intel_dpt_create(struct intel_framebuffer *fb) > > size = round_up(size * sizeof(gen8_pte_t), I915_GTT_PAGE_SIZE); > > - dpt_obj = i915_gem_object_create_lmem(i915, size, I915_BO_ALLOC_CONTIGUOUS); > + dpt_obj = i915_gem_object_create_lmem(i915, size, > + I915_BO_ALLOC_CONTIGUOUS | > + I915_BO_ALLOC_USER); > if (IS_ERR(dpt_obj) && i915_ggtt_has_aperture(to_gt(i915)->ggtt)) > dpt_obj = i915_gem_object_create_stolen(i915, size); > if (IS_ERR(dpt_obj) && !HAS_LMEM(i915)) { > diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c > index 3659350061a7..98ae3a3a986a 100644 > --- a/drivers/gpu/drm/i915/display/intel_fbdev.c > +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c > @@ -163,7 +163,8 @@ static int intelfb_alloc(struct drm_fb_helper *helper, > obj = ERR_PTR(-ENODEV); > if (HAS_LMEM(dev_priv)) { > obj = i915_gem_object_create_lmem(dev_priv, size, > - I915_BO_ALLOC_CONTIGUOUS); > + I915_BO_ALLOC_CONTIGUOUS | > + I915_BO_ALLOC_USER); > } else { > /* > * If the FB is too big, just don't use it since fbdev is not very > diff --git a/drivers/gpu/drm/i915/display/intel_plane_initial.c b/drivers/gpu/drm/i915/display/intel_plane_initial.c > index bb6ea7de5c61..4a3680f6a3f5 100644 > --- a/drivers/gpu/drm/i915/display/intel_plane_initial.c > +++ b/drivers/gpu/drm/i915/display/intel_plane_initial.c > @@ -110,7 +110,8 @@ initial_plane_vma(struct drm_i915_private *i915, > size * 2 > i915->dsm.usable_size) > return NULL; > > - obj = i915_gem_object_create_region_at(mem, phys_base, size, 0); > + obj = i915_gem_object_create_region_at(mem, phys_base, size, > + I915_BO_ALLOC_USER); > if (IS_ERR(obj)) > return NULL; > > -- > 2.39.0 -- Ville Syrjälä Intel