From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A540C742A7 for ; Wed, 8 Mar 2023 14:36:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1102E10E0CA; Wed, 8 Mar 2023 14:36:55 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 07B2B10E0CA; Wed, 8 Mar 2023 14:36:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678286213; x=1709822213; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=INV4kkpzN84uk5AqvrBrlZEMnH3kTpcrsYKTBCKR2qA=; b=HIqm+LdmzFYzUC4/MDboAhK8+Rt+INhEqKvTpDTDIomU1ddxdz4G/qcE ZdlehhV4/+s7EvEEsvo1egRonceC8OFV5nJCk3l5COR3zw+EvBdRFXuxQ NwB6RRRDhTeKXeDe9xPvd+4diJv2zE7WOO/A7h8yaMMyjt9WZsWd8sr2o tOkmg+cBulGocRdH4/z+JXhxi0zYYlrc2UiQQVj+FrHoT7YQdEL12LrBv G30GUAa5SzolCZMMceryZJ9AdZcCckbAW0SgOsYrV963I43K4li2lGcAE qTHiXP2gHGggeML+DqMXc0PXLLJUq+HIWMpNtzzze6i/VAmTsSHLVKNGG g==; X-IronPort-AV: E=McAfee;i="6500,9779,10642"; a="337684013" X-IronPort-AV: E=Sophos;i="5.98,244,1673942400"; d="scan'208";a="337684013" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2023 06:36:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10642"; a="676993038" X-IronPort-AV: E=Sophos;i="5.98,244,1673942400"; d="scan'208";a="676993038" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.70]) by orsmga002.jf.intel.com with SMTP; 08 Mar 2023 06:36:49 -0800 Received: by stinkbox (sSMTP sendmail emulation); Wed, 08 Mar 2023 16:36:48 +0200 Date: Wed, 8 Mar 2023 16:36:48 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Maarten Lankhorst Message-ID: References: <20230306141638.196359-1-maarten.lankhorst@linux.intel.com> <073f5ef3-523a-2997-c7e9-771cce8f4c24@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [Intel-xe] [PATCH] drm/xe/display: Do not use i915 frontbuffer tracking implementation X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "dri-devel@lists.freedesktop.org" , "intel-gfx@lists.freedesktop.org" , "intel-xe@lists.freedesktop.org" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Mar 08, 2023 at 03:29:45PM +0100, Maarten Lankhorst wrote: > Hey, > > > On 2023-03-08 14:36, Ville Syrjälä wrote: > > On Wed, Mar 08, 2023 at 01:47:12PM +0100, Maarten Lankhorst wrote: > >> On 2023-03-06 21:58, Ville Syrjälä wrote: > >>> On Mon, Mar 06, 2023 at 09:23:50PM +0100, Maarten Lankhorst wrote: > >>>> Hey, > >>>> > >>>> On 2023-03-06 16:23, Souza, Jose wrote: > >>>>> On Mon, 2023-03-06 at 15:16 +0100, Maarten Lankhorst wrote: > >>>>>> As a fallback if we decide not to merge the frontbuffer tracking, allow > >>>>>> i915 to keep its own implementation, and do the right thing in Xe. > >>>>>> > >>>>>> The frontbuffer tracking for Xe is still done per-fb, while i915 can > >>>>>> keep doing the weird intel_frontbuffer + i915_active thing without > >>>>>> blocking Xe. > >>>>> Please also disable PSR and FBC with this or at least add a way for users to disable those features. > >>>>> Without frontbuffer tracker those two features will break in some cases. > >>>> FBC and PSR work completely as expected. I don't remove frontbuffer > >>>> tracking; I only remove the GEM parts. > >>>> > >>>> Explicit invalidation using pageflip or CPU rendering + DirtyFB continue > >>>> to work, as I validated on my laptop with FBC. > >>> Neither of which are relevant to the removal of the gem hooks. > >>> > >>> Like I already said ~10 times in the last meeting, we need a proper > >>> testcase. Here's a rough idea what it should do: > >>> > >>> prepare a batch with > >>> 1. spinner > >>> 2. something that clobbers the fb > >>> > >>> Then > >>> 1. grab reference crc > >>> 2. execbuffer > >>> 3. dirtyfb > >>> 4. wait long enough for fbc to recompress > >>> 5. terminate spinner > >>> 6. gem_sync > >>> 7. grab crc and compare with reference > >>> > >>> No idea what the current status of PSR+CRC is, so not sure > >>> whether we can actually test PSR or not. > >> This test doesn't make sense. DirtyFB should simply not return before > >> execbuffer finishes. > > Of course it should. It's not a blocking ioctl, and can't > > be because that will make X unusable. > > Except it actually is. > > DirtyFB blocks in its default implementation, and waits for the next vblank. > > drm_atomic_helper_dirtyfb() blocks by default as it's a synchronous > plane update. > > Considering every driver except i915 uses it, it works just fine. :) No it doesn't. We tries to use it, but that was an utter failure. -- Ville Syrjälä Intel