From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7CE5C7618E for ; Fri, 17 Mar 2023 14:38:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4445110E38B; Fri, 17 Mar 2023 14:38:00 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id BDEFB10E125 for ; Fri, 17 Mar 2023 14:37:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679063877; x=1710599877; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Y2EWhZVhqJSY/xxBBb4SKMi2v1aCfkgTEY5graL6rEA=; b=U8S4EJ1H/F3CnWyEERROUd2DAEcJssddv/wC85zXwP/XDvOBe4ZhunbH lqILZ0qHfYeLrjaIa4w3lSfB9zIF3b7YakZNsAw1LnjoHbXe8I9H6TT1S ppWoZUsLy4UmX4CuIhVxQq6EpyuoYU8+Bu2fJpQ8Bn1abHayBET5iCa7S or9gHwykv1PaV1pyFpKx3lhnWzg+fDopOdOGYC+pxkTyvuwhzCK0S6Vul 9xA5rX2xkoLqKU6Jwgw/uRBnDod/HFndKVciBgMkUnv4+Nn1Xjdh3PNXO LG9uAVIZmhHefwt+Y5hy412ij1RwGTiq1zS81xMFFEtAf5E4rhcGo/XFk g==; X-IronPort-AV: E=McAfee;i="6600,9927,10652"; a="340630871" X-IronPort-AV: E=Sophos;i="5.98,268,1673942400"; d="scan'208";a="340630871" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2023 07:37:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10652"; a="680302425" X-IronPort-AV: E=Sophos;i="5.98,268,1673942400"; d="scan'208";a="680302425" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.70]) by orsmga002.jf.intel.com with SMTP; 17 Mar 2023 07:37:55 -0700 Received: by stinkbox (sSMTP sendmail emulation); Fri, 17 Mar 2023 16:37:54 +0200 Date: Fri, 17 Mar 2023 16:37:54 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Message-ID: References: <20230317125352.198042-1-jani.nikula@intel.com> <20230317125352.198042-2-jani.nikula@intel.com> <87pm97a48q.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/debugfs: add crtc i915_pipe debugfs file X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Mar 17, 2023 at 04:30:37PM +0200, Ville Syrjälä wrote: > On Fri, Mar 17, 2023 at 03:37:09PM +0200, Jani Nikula wrote: > > On Fri, 17 Mar 2023, Ville Syrjälä wrote: > > > On Fri, Mar 17, 2023 at 02:53:52PM +0200, Jani Nikula wrote: > > >> The pipe may differ from crtc index if pipes are fused off. For testing > > >> purposes, IGT needs to know the pipe. > > >> > > >> There's already a I915_GET_PIPE_FROM_CRTC_ID IOCTL for this. However, > > >> the upcoming Xe driver won't have that IOCTL, and going forward, we'll > > >> want a unified interface for testing i915 and Xe, as they share the > > >> display code. Thus add the debugfs for i915 display. > > >> > > >> Signed-off-by: Jani Nikula > > >> --- > > >> .../gpu/drm/i915/display/intel_display_debugfs.c | 13 +++++++++++++ > > >> 1 file changed, 13 insertions(+) > > >> > > >> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c > > >> index faa44fb80aac..e85270adca95 100644 > > >> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c > > >> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c > > >> @@ -1657,6 +1657,17 @@ static int i915_current_bpc_show(struct seq_file *m, void *data) > > >> } > > >> DEFINE_SHOW_ATTRIBUTE(i915_current_bpc); > > >> > > >> +/* Pipe may differ from crtc index if pipes are fused off */ > > >> +static int intel_crtc_pipe_show(struct seq_file *m, void *unused) > > >> +{ > > >> + struct intel_crtc *crtc = m->private; > > >> + > > >> + seq_printf(m, "%d\n", crtc->pipe); > > > > > > Are we happy with an integer or should we use the actual alphabetic > > > name here? > > > > Primarily I considered the programmatic use case, and the ease of > > switching over from the ioctl. What do we gain by making IGT parse this? > > Well even the integer is represented in ascii so parsing > needs to happen anyway. But I was mainly thinking if any > human looks at it they may be confused as to what the > raw integer even means. Eg. if I just jump on some random machine an do # grep . crtc-1/* ... i915_pipe: 3 ... Now I need to most likely count with my fingers to figure out I'm actually looking at pipe D :P > > > > > > Either way, the series is: > > > Reviewed-by: Ville Syrjälä > > > > Thanks, > > Jani. > > > > > > > >> + > > >> + return 0; > > >> +} > > >> +DEFINE_SHOW_ATTRIBUTE(intel_crtc_pipe); > > >> + > > >> /** > > >> * intel_connector_debugfs_add - add i915 specific connector debugfs files > > >> * @connector: pointer to a registered drm_connector > > >> @@ -1735,4 +1746,6 @@ void intel_crtc_debugfs_add(struct intel_crtc *crtc) > > >> > > >> debugfs_create_file("i915_current_bpc", 0444, root, crtc, > > >> &i915_current_bpc_fops); > > >> + debugfs_create_file("i915_pipe", 0444, root, crtc, > > >> + &intel_crtc_pipe_fops); > > >> } > > >> -- > > >> 2.39.2 > > > > -- > > Jani Nikula, Intel Open Source Graphics Center > > -- > Ville Syrjälä > Intel -- Ville Syrjälä Intel