From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB0EFC6FD1D for ; Fri, 17 Mar 2023 12:29:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6C83710E114; Fri, 17 Mar 2023 12:29:19 +0000 (UTC) Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by gabe.freedesktop.org (Postfix) with ESMTPS id DCDDC10E114; Fri, 17 Mar 2023 12:29:17 +0000 (UTC) Received: by mail-lf1-x12b.google.com with SMTP id g17so6284403lfv.4; Fri, 17 Mar 2023 05:29:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679056156; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Z9iw9ROsVj3odzN5DXBBOp0EmWo1iW674uPMX2CrdbU=; b=it4nZ4B0NSC3oV4G3BWmiGCEa4f/iQhYt4E8DUTU+R1m1fKkIu02jDLBUZRfr1sLAg WfOEf5AVonJV/+g05SgQx6F/4vl0hdmPm0pcFjU4gSwhhFAsHyHxFjbTXmFoFoXJ6fus VoBeJPachR5Oz1WLLt1utjkMB7eaMc4jgJ0Xlj8b7NJ3z087HqT4x+XHZFSx54Zs9g1V hQ6E3950il8EPQeASOtw0il7DzQN2S6UNqhtlv3aNJi02cYTyLpAn/UqFhuVz3x6WhAK mNEbzt7SRsRV2AWcyQ5VCxl/Y9VbqPMqmPyalsneBxsAF4J9j31s4dYpR+7tz8Um2Pgz 8fqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679056156; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Z9iw9ROsVj3odzN5DXBBOp0EmWo1iW674uPMX2CrdbU=; b=n4E9AcRGDxKIX32YPYotOMsmyq3ENBfy/vxvYBjoN0KBqHXY/5yGVUzE8yprUqQpNK HdxXfe0+KJdOr72nsu+qSq0//LLAFg4vPIYMpCdoMcmp/Ziz8RcfD8I/LJ4ceoRmhw+U k939Ia2Gou/N+Kx/+4PxKeVUZ7Pb63Gqvr69pucnXGPOMK4EEyc8XXAGJamr/st6vfGC /Jvxdu+7ESomXyRZq+XI5aIFZdHmsrHkSVR+QBBOffUe/y69JzmzvILJU64JfgFAmneC Pde4CALnK6t1I9bppyCKUDLN9ab0hXz+xp0XSUjXj1rm3oDf2STGnT5o3imR/w0gx5FG 34og== X-Gm-Message-State: AO0yUKWVEihn2EbmZsrwPqiy/mrimTJZ/lEuM74Dfd7mSiXVsZtv/lJI s7qn54zizQYRXelI5znQ/Q7nEO7B2UqKkg== X-Google-Smtp-Source: AK7set+1qEfHAuCygG1LEnUSs/sWzFNGypfvmTHbU+7nT48xKG/qqSqK12WLIWt/W7e7Cpto7kmjkg== X-Received: by 2002:a05:6512:491:b0:4e8:a093:5eea with SMTP id v17-20020a056512049100b004e8a0935eeamr961889lfq.11.1679056156063; Fri, 17 Mar 2023 05:29:16 -0700 (PDT) Received: from gmail.com (host-95-193-64-255.mobileonline.telia.com. [95.193.64.255]) by smtp.gmail.com with ESMTPSA id s12-20020ac25fec000000b004dda80cabf0sm349996lfg.172.2023.03.17.05.29.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 05:29:15 -0700 (PDT) Date: Fri, 17 Mar 2023 13:29:13 +0100 From: Jonas =?iso-8859-1?Q?=C5dahl?= To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Message-ID: References: <20230208211016.7034-1-ville.syrjala@linux.intel.com> <20230313163311.11379-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [Intel-gfx] [PATCH v3 1/2] drm: Introduce plane SIZE_HINTS property X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Pekka Paalanen , Jonas =?iso-8859-1?Q?=C5dahl?= , dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Mar 17, 2023 at 01:21:43PM +0100, Jonas Ådahl wrote: > On Fri, Mar 17, 2023 at 01:33:25PM +0200, Ville Syrjälä wrote: > > On Fri, Mar 17, 2023 at 11:34:16AM +0100, Jonas Ådahl wrote: > > > On Mon, Mar 13, 2023 at 06:33:11PM +0200, Ville Syrjala wrote: > > > > From: Ville Syrjälä > > > > > > > > Add a new immutable plane property by which a plane can advertise > > > > a handful of recommended plane sizes. This would be mostly exposed > > > > by cursor planes as a slightly more capable replacement for > > > > the DRM_CAP_CURSOR_WIDTH/HEIGHT caps, which can only declare > > > > a one size fits all limit for the whole device. > > > > > > > > Currently eg. amdgpu/i915/nouveau just advertize the max cursor > > > > size via the cursor size caps. But always using the max sized > > > > cursor can waste a surprising amount of power, so a better > > > > stragey is desirable. > > > > > > > > Most other drivers don't specify any cursor size at all, in > > > > which case the ioctl code just claims that 64x64 is a great > > > > choice. Whether that is actually true is debatable. > > > > > > > > A poll of various compositor developers informs us that > > > > blindly probing with setcursor/atomic ioctl to determine > > > > suitable cursor sizes is not acceptable, thus the > > > > introduction of the new property to supplant the cursor > > > > size caps. The compositor will now be free to select a > > > > more optimal cursor size from the short list of options. > > > > > > > > Note that the reported sizes (either via the property or the > > > > caps) make no claims about things such as plane scaling. So > > > > these things should only really be consulted for simple > > > > "cursor like" use cases. > > > > > > > > v2: Try to add some docs > > > > v3: Specify that value 0 is reserved for future use (basic idea from Jonas) > > > > Drop the note about typical hardware (Pekka) > > > > > > > > Cc: Simon Ser > > > > Cc: Jonas Ådahl > > > > Cc: Daniel Stone > > > > Cc: Pekka Paalanen > > > > Acked-by: Harry Wentland > > > > Acked-by: Pekka Paalanen > > > > Signed-off-by: Ville Syrjälä > > > > --- > > > > drivers/gpu/drm/drm_mode_config.c | 7 ++++ > > > > drivers/gpu/drm/drm_plane.c | 53 +++++++++++++++++++++++++++++++ > > > > include/drm/drm_mode_config.h | 5 +++ > > > > include/drm/drm_plane.h | 4 +++ > > > > include/uapi/drm/drm_mode.h | 11 +++++++ > > > > 5 files changed, 80 insertions(+) > > > > > > > > diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c > > > > index 87eb591fe9b5..21860f94a18c 100644 > > > > --- a/drivers/gpu/drm/drm_mode_config.c > > > > +++ b/drivers/gpu/drm/drm_mode_config.c > > > > @@ -374,6 +374,13 @@ static int drm_mode_create_standard_properties(struct drm_device *dev) > > > > return -ENOMEM; > > > > dev->mode_config.modifiers_property = prop; > > > > > > > > + prop = drm_property_create(dev, > > > > + DRM_MODE_PROP_IMMUTABLE | DRM_MODE_PROP_BLOB, > > > > + "SIZE_HINTS", 0); > > > > + if (!prop) > > > > + return -ENOMEM; > > > > + dev->mode_config.size_hints_property = prop; > > > > + > > > > return 0; > > > > } > > > > > > > > diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c > > > > index 24e7998d1731..d2a6fdff1a57 100644 > > > > --- a/drivers/gpu/drm/drm_plane.c > > > > +++ b/drivers/gpu/drm/drm_plane.c > > > > @@ -140,6 +140,26 @@ > > > > * DRM_FORMAT_MOD_LINEAR. Before linux kernel release v5.1 there have been > > > > * various bugs in this area with inconsistencies between the capability > > > > * flag and per-plane properties. > > > > + * > > > > + * SIZE_HINTS: > > > > + * Blob property which contains the set of recommended plane size > > > > + * which can used for simple "cursor like" use cases (eg. no scaling). > > > > + * Using these hints frees userspace from extensive probing of > > > > + * supported plane sizes through atomic/setcursor ioctls. > > > > + * > > > > + * For optimal usage userspace should pick the smallest size > > > > + * that satisfies its own requirements. > > > > + * > > > > + * The blob contains an array of struct drm_plane_size_hint. > > > > + * > > > > + * Drivers should only attach this property to planes that > > > > + * support a very limited set of sizes. > > > > + * > > > > + * Note that property value 0 (ie. no blob) is reserved for potential > > > > + * future use. Current userspace is expected to ignore the property > > > > + * if the value is 0, and fall back to some other means (eg. > > > > + * &DRM_CAP_CURSOR_WIDTH and &DRM_CAP_CURSOR_HEIGHT) to determine > > > > + * the appropriate plane size to use. > > > > > > Does this intend to mean userspace has the kernel's blessing on choosing > > > an arbitrary size as long as it's smaller than &DRM_CAP_CURSOR_WIDTH x > > > &DRM_CAP_CURSOR_HEIGHT? > > > > > > It's a bit to vague for me to make a confident interpretation whether I > > > can, or whether I should pretend I didn't see SIZE_HINTS and apply the > > > old logic, meaning only using the exact cap size. > > > > Using the exact cap size is the only thing more or less > > guaranteed to work. But other approaches (such as probing > > the size with atomic/cursor ioctls) can also be used. > > I think you should then just disallow drivers for exposing SIZE_HINTS > with the value 0, and make it a bug if they do, to let userspace know > when the value 0 means anything. > > In other words, userspace should *not* ignore the property value being > 0, but treat it as a kernel bug if there is a SIZE_HINTS only containing > a 0, until the value 0 has gotten any meaning. Otherwise I don't see how > it'll be usable in the future, since userspace doesn't know the > difference between 'legacy 0' and 'new 0' once it's defined to mean > anything. On a second thought, userspace needs to ignore it, to not fall apart when running on never future kernels, you're right. Never mind. I guess with "is reserved" implies that it's a bug if it's used before it's defined to be anything, right? Jonas