From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD1CCC6FD18 for ; Wed, 19 Apr 2023 11:17:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D33DE10E16D; Wed, 19 Apr 2023 11:17:35 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A49710E16D; Wed, 19 Apr 2023 11:17:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681903052; x=1713439052; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=QZereRYUiZz4yyZ+kkizgJFB9KX/efKkLTB1Bz9yjn8=; b=dy9cNO33wJod/P77KK/VJfxosdCiRrmGvbIReiFlD42otNyZtd05zXzR xgPEmZCrt96MsrJlpThwG+p5qwTsCQVNXPE5vavtXuKktm/WQKqeD9L0D Fat1xOtbLA31nIgTGu8RYpboDeYylOeoKLZwhx4dO/HimEemFw2GAJdd1 dvULjU62D17vMDvDlNNhb7d4mC3vVD69BMwnRnZcbyLq5P8lesI9J61O0 oi4nSghGvVVMXE+TwLPwN01jMqhmTLmfQNTXV6Z0Fv4HK2G0pMMSRNewQ gcxcfpHuej3kqotUVCeQLplI30eLfdmFN7kRjb0r6FwXRA+yhmBzHwsvo Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10684"; a="334225558" X-IronPort-AV: E=Sophos;i="5.99,208,1677571200"; d="scan'208";a="334225558" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2023 04:17:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10684"; a="756069901" X-IronPort-AV: E=Sophos;i="5.99,208,1677571200"; d="scan'208";a="756069901" Received: from crijnder-mobl.ger.corp.intel.com (HELO intel.com) ([10.249.35.137]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2023 04:17:27 -0700 Date: Wed, 19 Apr 2023 13:17:23 +0200 From: Andi Shyti To: fei.yang@intel.com Message-ID: References: <20230417062503.1884465-1-fei.yang@intel.com> <20230417062503.1884465-7-fei.yang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230417062503.1884465-7-fei.yang@intel.com> Subject: Re: [Intel-gfx] [PATCH 6/8] drm/i915: preparation for using PAT index X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matt Roper , intel-gfx@lists.freedesktop.org, Chris Wilson , dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Fei, [...] > @@ -180,6 +182,14 @@ struct drm_i915_private *mock_gem_device(void) > I915_GTT_PAGE_SIZE_2M; > > RUNTIME_INFO(i915)->memory_regions = REGION_SMEM; > + > + double space here, otherwise: Reviewed-by: Andi Shyti Andi > + /* simply use legacy cache level for mock device */ > + i915_info = (struct intel_device_info *)INTEL_INFO(i915); > + i915_info->max_pat_index = 3; > + for (i = 0; i < I915_MAX_CACHE_LEVEL; i++) > + i915_info->cachelevel_to_pat[i] = i; > + > intel_memory_regions_hw_probe(i915); > > spin_lock_init(&i915->gpu_error.lock); > -- > 2.25.1