From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B652FC6FD18 for ; Tue, 25 Apr 2023 19:49:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C75D610E162; Tue, 25 Apr 2023 19:49:40 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5AD5110E083; Tue, 25 Apr 2023 19:49:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682452178; x=1713988178; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+A55figV2KY0Lbwx7DKL+lUi654PZn0kCZuRq6PAiTc=; b=bvFyVPQTOu4YTsHQSjIZh1WHxpBnYYhZK7a5tB/abxp1W8uB9N5mrJ9i WjMPtSIvnML8su+2Cd+z3QLM9w92fyocp6E6iBWCa5GGa9+/C6/HO6jyz nIORiGm+Tn+jfy+33iTCKaAVfBOz0wbXiv117yH34m0UZfN8iSi7YEJDi 6g5MKudr/O3LFwmrVVaHFr4dPxQDHwUvwd2miJDnITM+ezqYE0zHfiNue hcLXzorJNFOAJiwpifNjWmZSmBI+kBA+LVHzj2XE69OzCacAVXDK4ciAv IFSrdG2wbPgkDXGKeho5CJE2FnTy+8IbDt6xdK6CfiSrThDcxZLGYYVps A==; X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="374833799" X-IronPort-AV: E=Sophos;i="5.99,226,1677571200"; d="scan'208";a="374833799" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2023 12:49:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="817837806" X-IronPort-AV: E=Sophos;i="5.99,226,1677571200"; d="scan'208";a="817837806" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO intel.com) ([10.252.59.107]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2023 12:49:33 -0700 Date: Tue, 25 Apr 2023 21:49:30 +0200 From: Andi Shyti To: John.C.Harrison@intel.com Message-ID: References: <20230421224742.2357198-1-John.C.Harrison@Intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230421224742.2357198-1-John.C.Harrison@Intel.com> Subject: Re: [Intel-gfx] [PATCH] drm/i915/guc: Actually return an error if GuC version range check fails X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dan Carpenter , Alan Previn , Jani Nikula , Intel-GFX@lists.freedesktop.org, Lucas De Marchi , DRI-Devel@lists.freedesktop.org, Matthew Auld , Rodrigo Vivi Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi John, > Dan Carpenter pointed out that 'err' was not being set in the case > where the GuC firmware version range check fails. Fix that. > > Note that while this is bug fix for a previous patch (see Fixes tag is _a_ bug fix. > below). It is an exceedingly low risk bug. The range check is > asserting that the GuC firmware version is within spec. So it should > not be possible to ever have a firmware file that fails this check. If > larger version numbers are required in the future, that would be a > backwards breaking spec change and thus require a major version bump, > in which case an old i915 driver would not load that new version anyway. > > Fixes: 9bbba0667f37 ("drm/i915/guc: Use GuC submission API version number") > Reported-by: Dan Carpenter > Signed-off-by: John Harrison > Cc: John Harrison > Cc: Daniele Ceraolo Spurio > Cc: Alan Previn > Cc: Umesh Nerlige Ramappa > Cc: Rodrigo Vivi > Cc: Matthew Brost > Cc: Andi Shyti > Cc: Matthew Auld > Cc: Tvrtko Ursulin > Cc: Lucas De Marchi > Cc: Jani Nikula Reviewed-by: Andi Shyti Andi