[Intel-gfx] [PATCH 07/11] drm/i915/dp: Convert link training error to debug message on disconnected sink

Imre Deak
2023-04-26T16:53:22Z

If a sink is disconnected it's expected that link training actions will
fail on it, so downgrade the error messages about such actions to be a
debug message. Such - expected - link training failures are more
frequent after a follow up patch, after which an active TypeC link is
reset after the sink is disconnected which also involves a link
training.

Signed-off-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
drivers/gpu/drm/i915/display/intel_dp.h | 1 +
drivers/gpu/drm/i915/display/intel_dp_link_training.c | 11 +++++++++--
3 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 1d28a2560ae01..388e79f74621f 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -4171,7 +4171,7 @@ static int intel_dp_prep_link_retrain(struct intel_dp *intel_dp,
return ret;
}

-static bool intel_dp_is_connected(struct intel_dp *intel_dp)
+bool intel_dp_is_connected(struct intel_dp *intel_dp)
{
struct intel_connector *connector = intel_dp->attached_connector;

diff --git a/drivers/gpu/drm/i915/display/intel_dp.h b/drivers/gpu/drm/i915/display/intel_dp.h
index ef39e4f7a329e..488da392fafe5 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.h
+++ b/drivers/gpu/drm/i915/display/intel_dp.h
@@ -42,6 +42,7 @@ void intel_dp_set_link_params(struct intel_dp *intel_dp,
int link_rate, int lane_count);
int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
int link_rate, u8 lane_count);
+bool intel_dp_is_connected(struct intel_dp *intel_dp);
int intel_dp_retrain_link(struct intel_encoder *encoder,
struct drm_modeset_acquire_ctx *ctx);
void intel_dp_set_power(struct intel_dp *intel_dp, u8 mode);
diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
index 12f2880e474ed..a747249c409a0 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
@@ -33,6 +33,7 @@ static void lt_msg(struct intel_connector *connector, struct intel_dp *intel_dp,
struct drm_i915_private *i915 = dp_to_i915(intel_dp);
struct intel_encoder *encoder = &dp_to_dig_port(intel_dp)->base;
char conn_str[128] = {};
+ const char *discon_str = "";
struct va_format vaf;
va_list args;

@@ -44,6 +45,11 @@ static void lt_msg(struct intel_connector *connector, struct intel_dp *intel_dp,
snprintf(conn_str, sizeof(conn_str), "[CONNECTOR:%d:%s]",
connector->base.base.id, connector->base.name);

+ if (is_error && !intel_dp_is_connected(intel_dp)) {
+ discon_str = " (sink disconnected)";
+ is_error = false;
+ }
+
if (is_error)
drm_err(&i915->drm, "%s[ENCODER:%d:%s][%s] %pV\n",
conn_str,
@@ -51,11 +57,12 @@ static void lt_msg(struct intel_connector *connector, struct intel_dp *intel_dp,
drm_dp_phy_name(dp_phy),
&vaf);
else
- drm_dbg(&i915->drm, "%s[ENCODER:%d:%s][%s] %pV\n",
+ drm_dbg(&i915->drm, "%s[ENCODER:%d:%s][%s] %pV%s\n",
conn_str,
encoder->base.base.id, encoder->base.name,
drm_dp_phy_name(dp_phy),
- &vaf);
+ &vaf,
+ discon_str);
}

#define lt_err(intel_dp, dp_phy, format, ...) \
--
2.37.2