From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6A65C7EE24 for ; Tue, 6 Jun 2023 09:22:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 837F310E31D; Tue, 6 Jun 2023 09:22:37 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 36AC410E32C for ; Tue, 6 Jun 2023 09:22:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686043356; x=1717579356; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=b9VXZntpeNRoTEkueHHlfro+jLGEiHISiRUwIaILg8Y=; b=YpRSU55wBJswC/k0Dzechj1zYgwP6UZKu/0yDLlQ6nQnD3lpx/2z4+am 4Eob9m81fLeUfrk0jlBBymH1WLsYXSQOTRAEjdL5KbWtTjOMy2SFvxFAS vwpz5nN93zADIbT4oe83Ms+HkfeNk1ZmP4sczFeYN+ozKpvJaCLA5rPr6 sn0gJJTET44b3LcHB/wvphSRkcqyIshN/OBLjbBnr2pr7PjSRQ9FokWMy nq8LwztR2+J5xvSu90Eg/NYkdVGUt7Q3HZVsLgAYN4WW/PxeGmNZLvibp 1OLAherdyX+1v9a2hgerwECdjYaxvyaiOU+eBN+0H1GjFVAIopOByor4K A==; X-IronPort-AV: E=McAfee;i="6600,9927,10732"; a="336242099" X-IronPort-AV: E=Sophos;i="6.00,219,1681196400"; d="scan'208";a="336242099" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2023 02:22:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10732"; a="712136053" X-IronPort-AV: E=Sophos;i="6.00,219,1681196400"; d="scan'208";a="712136053" Received: from yuguen-mobl2.ger.corp.intel.com (HELO intel.com) ([10.252.57.68]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2023 02:22:30 -0700 Date: Tue, 6 Jun 2023 11:22:24 +0200 From: Andi Shyti To: Dan Carpenter Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix a NULL vs IS_ERR() bug X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, Suren Baghdasaryan , Matthew Auld , Daniel Vetter , Rodrigo Vivi , David Airlie , Nirmoy Das Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Dan, On Tue, Jun 06, 2023 at 11:23:56AM +0300, Dan Carpenter wrote: > The mmap_offset_attach() function returns error pointers, it doesn't > return NULL. > > Fixes: eaee1c085863 ("drm/i915: Add a function to mmap framebuffer obj") > Signed-off-by: Dan Carpenter Thanks for this series of fixes! Reviewed-by: Andi Shyti Andi