From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE47AC77B73 for ; Wed, 31 May 2023 10:49:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6B68510E4B0; Wed, 31 May 2023 10:49:35 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id CCC7310E4AC; Wed, 31 May 2023 10:49:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685530173; x=1717066173; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=P4OtVBdvXMpW1v+dbrVU/sDkueZddN43qStMW7Uj/tg=; b=g/WKUfk/s/NUWS7EN/cOZ/YVA6NokcF8kuHQ07Rk/UoDsrvOcMQqjlgp kXg3upidAfVVBOUnRJyz9CEJ9VoXKOeMDpSwL8NBh0gIPbfgqiYgfWpLW E4mbWHB3kJwBjWc2Rs7DXqq9koggvDLn//9dtsof8Hvn6KCEgOMtNsGx/ 220oh442ETKuGT0yqRiPuB/+bUJzQD9nvsk//RVXjgejAegSezkVcIk8+ Z1fjYzqcstmlY83ktAjsiHi/uWd8kMYF1jQnqI0JUG2JTmAFYU6gfAe+a /uckaTRHizHM/8pz9Im5eg2TgDucZQxZLO5v8r8RMSpUQYQShGbkyOocB w==; X-IronPort-AV: E=McAfee;i="6600,9927,10726"; a="357591208" X-IronPort-AV: E=Sophos;i="6.00,205,1681196400"; d="scan'208";a="357591208" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2023 03:49:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10726"; a="851166045" X-IronPort-AV: E=Sophos;i="6.00,205,1681196400"; d="scan'208";a="851166045" Received: from itaraban-mobl.ger.corp.intel.com (HELO intel.com) ([10.252.47.19]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2023 03:49:29 -0700 Date: Wed, 31 May 2023 12:49:26 +0200 From: Andi Shyti To: fei.yang@intel.com, Carl Zhang Message-ID: References: <20230524200255.443021-1-fei.yang@intel.com> <20230524200255.443021-2-fei.yang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230524200255.443021-2-fei.yang@intel.com> Subject: Re: [Intel-gfx] [PATCH v12 1/1] drm/i915: Allow user to set cache at BO creation X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Wilson , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, rodrigo.vivi@intel.com, Matt Roper Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Carl, On Wed, May 24, 2023 at 01:02:55PM -0700, fei.yang@intel.com wrote: > From: Fei Yang > > To comply with the design that buffer objects shall have immutable > cache setting through out their life cycle, {set, get}_caching ioctl's > are no longer supported from MTL onward. With that change caching > policy can only be set at object creation time. The current code > applies a default (platform dependent) cache setting for all objects. > However this is not optimal for performance tuning. The patch extends > the existing gem_create uAPI to let user set PAT index for the object > at creation time. > The new extension is platform independent, so UMD's can switch to using > this extension for older platforms as well, while {set, get}_caching are > still supported on these legacy paltforms for compatibility reason. > > BSpec: 45101 > > Test igt@gem_create@create_ext_set_pat posted at > https://patchwork.freedesktop.org/series/118314/ > > Tested with https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22878 > > Signed-off-by: Fei Yang > Cc: Chris Wilson > Cc: Matt Roper > Cc: Andi Shyti > Reviewed-by: Andi Shyti > Acked-by: Jordan Justen > Tested-by: Jordan Justen was it your intention to ack this patch? Thanks, Andi