From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD927EB64D7 for ; Mon, 26 Jun 2023 11:24:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E466510E1E3; Mon, 26 Jun 2023 11:24:49 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id C4DE510E1E1; Mon, 26 Jun 2023 11:24:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687778687; x=1719314687; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Hbsx9lDG0ObqAYBCH/anLudkyMjn7A+iSFPOx7MPsBM=; b=W4srQOuk8xXvEbRDrJOuRMuYPhg/cD6qFcVJYpdiGzY5/Ti0DoRuvUX7 18Ln+f/MFLuNilLCUBX6i632DLVSR2A+yLS0oVUpobQfmn0f3EfthAB0z KvaHLufRcYmkeBZ5uZHINY21wZwp9rrFrAV8Ilv/1MNitf0VNHUSZCrjA cJZxxl/PBSGovCjSzg93rIY1KnLMGDOxcOgqej4l5iceMli797VvRyemO 1Xp/NmxO1d0dZgJEjQQPhT4vfWBPKfW38KxUQ3muCbX2ozYm1zFvXWwfn mMnqrramPsEVrwCGgPq93uo+u+6Vk9+B4ABIbkwXuyP8qzP+HM/eMEC9/ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10752"; a="363790143" X-IronPort-AV: E=Sophos;i="6.01,159,1684825200"; d="scan'208";a="363790143" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2023 04:24:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10752"; a="1046477310" X-IronPort-AV: E=Sophos;i="6.01,159,1684825200"; d="scan'208";a="1046477310" Received: from csteeb-mobl2.ger.corp.intel.com (HELO intel.com) ([10.251.217.4]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2023 04:24:41 -0700 Date: Mon, 26 Jun 2023 13:24:38 +0200 From: Andi Shyti To: Thomas =?iso-8859-15?Q?Hellstr=F6m?= Message-ID: References: <20230626091450.14757-1-thomas.hellstrom@linux.intel.com> <20230626091450.14757-4-thomas.hellstrom@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230626091450.14757-4-thomas.hellstrom@linux.intel.com> Subject: Re: [Intel-gfx] [PATCH v2 3/4] drm/ttm: Don't leak a resource on eviction error X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Grodzovsky , Christian =?iso-8859-15?Q?K=F6nig?= , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Christian =?iso-8859-15?Q?K=F6nig?= , Huang Rui , dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, Nirmoy Das Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Thomas, On Mon, Jun 26, 2023 at 11:14:49AM +0200, Thomas Hellström wrote: > On eviction errors other than -EMULTIHOP we were leaking a resource. > Fix. > > v2: > - Avoid yet another goto (Andi Shyti) > > Fixes: 403797925768 ("drm/ttm: Fix multihop assert on eviction.") > Cc: Andrey Grodzovsky > Cc: Christian König > Cc: Christian Koenig > Cc: Huang Rui > Cc: dri-devel@lists.freedesktop.org > Cc: # v5.15+ > Signed-off-by: Thomas Hellström > Reviewed-by: Nirmoy Das #v1 Reviewed-by: Andi Shyti Andi