From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95867EE49A3 for ; Tue, 22 Aug 2023 12:38:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 00A2310E345; Tue, 22 Aug 2023 12:38:57 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7370810E345 for ; Tue, 22 Aug 2023 12:38:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692707935; x=1724243935; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=OQtjQJCWxtBfLoEuZsuBXmeOwoojmUd6hIQCCcThV+c=; b=X5rOMEXMj3bTMd6B5ymxeJ85g9CNUrGk9FceHz+nW/VRbG4aJ34/QqPb KL+VaSmpDqbp5tJal6FNIy+3Y5Voyi0IWrQHY1BDeZatzP/TZRyUDv7QI ewoszIeG6+/72g9qwUKMBv7toIgudauFqkq9H+sFD02obHiboykeEEZoj 3+mcAEaCxnvJsZjR103ICrUzqE/DJ/pCrCL6S5vQdYBU8Hfs86qa60nVt a5V61wIRXTkhcruelRd5EWRo9MkY4qkYtpOawbx/xbobJDzT2UihaNjR0 MvMhN3XVLN752t3bswurZEfn7OIW3Mz7dpoRJi4leKrxdxSCJBpIg2xX9 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="373846712" X-IronPort-AV: E=Sophos;i="6.01,193,1684825200"; d="scan'208";a="373846712" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2023 05:38:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="806277093" X-IronPort-AV: E=Sophos;i="6.01,193,1684825200"; d="scan'208";a="806277093" Received: from ashyti-mobl2.igk.intel.com (HELO intel.com) ([172.28.182.156]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2023 05:38:37 -0700 Date: Tue, 22 Aug 2023 14:38:35 +0200 From: Andi Shyti To: "Cavitt, Jonathan" Message-ID: References: <20230819225001.1040607-1-andi.shyti@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Intel-gfx] [CI] drm/i915/gt: Refactor hangcheck selftest to use igt_spinner X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Jonathan, > > The hangcheck live selftest contains duplicate declarations of some > > functions that already exist in igt_spinner.c, such as the creation and > > deconstruction of a spinning batch buffer (spinner) that hangs an engine. > > It's undesireable to have such code duplicated, as the requirements for > > the spinner may change with hardware updates, necessitating both > > execution paths be updated. To avoid this, have the hangcheck live > > selftest use the declaration from igt_spinner. This eliminates the need > > for the declarations in the selftest itself, as well as the associated > > local helper structures, so we can erase those. > > > > Suggested-by: Matt Roper > > Signed-off-by: Jonathan Cavitt > > > Test fails with -62 (ETIME) on intel_selftest_wait_for_rq > It looks like the cause might be me calling intel_context_put too early? > Let me move those calls to later and see if that helps. > Give me some time to implement those changes. Thanks! Andi