From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23EDCC27C40 for ; Thu, 24 Aug 2023 09:44:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8E95310E51A; Thu, 24 Aug 2023 09:44:24 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id A847010E51C for ; Thu, 24 Aug 2023 09:44:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692870261; x=1724406261; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Q1pEw1ChbatfRsqoTon+2RhSmKnD8DpxUzG+G+x+fmc=; b=WkNXC6fnbBL2wfNHWGR+G6ZcegqyMcj+RMIjyUxLmOKg5USqo2bDIE35 Tw4uuJKDcV77JSgpG30tjMDJu6KyHmcEvO/uEBgY8LYOED1nbvUJd3WUF GVOJnmA2d2fdLAvzKIWhBvDQKeGlGkKsrx4HDXtkPO8YBx0HxsDThqKef A/dA0mI0xODB/NmCy9gTdWuA2G+Z0u6Y0KsGe2zIyWrhooT1AEAflILfF ISGkitiEeBnoWWBDQJD7g+ydv6klxK12xfeU+lujZXEWVwB070qD7K0Mz 5OCuXFEQCz/fjehoaMd1aDuRt7i3Xa18n2kZs1DAfoBGM98mlnqOS9zg7 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10811"; a="405398378" X-IronPort-AV: E=Sophos;i="6.01,195,1684825200"; d="scan'208";a="405398378" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2023 02:44:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10811"; a="860640994" X-IronPort-AV: E=Sophos;i="6.01,195,1684825200"; d="scan'208";a="860640994" Received: from unknown (HELO intel.com) ([10.237.72.65]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2023 02:44:20 -0700 Date: Thu, 24 Aug 2023 12:44:16 +0300 From: "Lisovskiy, Stanislav" To: Imre Deak Message-ID: References: <20230824080517.693621-1-imre.deak@intel.com> <20230824080517.693621-20-imre.deak@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230824080517.693621-20-imre.deak@intel.com> Subject: Re: [Intel-gfx] [PATCH v2 19/22] drm/i915/dp_mst: Add missing DSC compression disabling X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Aug 24, 2023 at 11:05:14AM +0300, Imre Deak wrote: > Add the missing DSC compression disabling step for MST streams, > similarly to how this is done for SST outputs. > > Signed-off-by: Imre Deak > --- > drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c > index b6a717566e7c8..5eaf309f852f2 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c > @@ -656,6 +656,8 @@ static void intel_mst_post_disable_dp(struct intel_atomic_state *state, > > intel_ddi_disable_transcoder_func(old_crtc_state); > > + intel_dsc_disable(old_crtc_state); > + One thing that a bit I'm a bit concerned is that whether won't it conflict with that intel_ddi_post_disable hook called for the last mst stream? I see that it also calls intel_dsc_disable, however there is !mst check first, however for Bigjoiner case, there is no such check. Wondering should we add it there?.. > if (DISPLAY_VER(dev_priv) >= 9) > skl_scaler_disable(old_crtc_state); > else > -- > 2.37.2 >