From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 119A5C83F3F for ; Mon, 4 Sep 2023 06:32:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 208CB10E0DE; Mon, 4 Sep 2023 06:32:57 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0D62B10E0DE; Mon, 4 Sep 2023 06:32:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693809174; x=1725345174; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ql1SeTsT6ragrHVV+S7gG0Gx1pDdAI3ifiqhz6TY8BI=; b=VXGQNjWy6HbeULqVVzqmP3WikIuEytPdpU6tMebflIiNVGuDggEPba/4 wHdrSC6B0U5famAieX3hJ2lnDe2bzAeQ7Ag5VDGRqXnied/DKuXAzPH8H NH0ZOpy8z7jZpAVy6XgA7NxujcTSWSV3TQlT9riNPhdtHKzsYjkqrvtMk rk3rnp/LKm9hLczf6SDwmdSSL5P5hBVyeMyRQgBBY9j6LERB+0Xr7uNet veWyueWb5KTTz4/V+hGHUi79mu6EBRLMqpVlQZNW1F0L77c076k7H2P/3 kduMsKNEem1GbuToc+bBbuNezApGhoRe/uav2wEs/U6axVu5+9UzoKexw g==; X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="366750382" X-IronPort-AV: E=Sophos;i="6.02,225,1688454000"; d="scan'208";a="366750382" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2023 23:32:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="914404453" X-IronPort-AV: E=Sophos;i="6.02,225,1688454000"; d="scan'208";a="914404453" Received: from acohen8-mobl2.ger.corp.intel.com (HELO intel.com) ([10.252.59.133]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2023 23:32:44 -0700 Date: Mon, 4 Sep 2023 08:32:40 +0200 From: Andi Shyti To: Jim Cromie Message-ID: References: <20230903184607.272198-1-jim.cromie@gmail.com> <20230903184607.272198-4-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230903184607.272198-4-jim.cromie@gmail.com> Subject: Re: [Intel-gfx] [PATCH v2 3/6] drm_dbg: add trailing newlines to msgs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Jason A. Donenfeld" , daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org, Chris Wilson , Andrzej Hajda , David Airlie , Rob Clark , amd-gfx@lists.freedesktop.org, Matthew Auld , jani.nikula@intel.com, intel-gfx@lists.freedesktop.org, seanpaul@chromium.org, Rodrigo Vivi , intel-gvt-dev@lists.freedesktop.org, linux-kernel@vger.kernel.org, daniel@ffwll.ch Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Jim, On Sun, Sep 03, 2023 at 12:46:00PM -0600, Jim Cromie wrote: > By at least strong convention, a print-buffer's trailing newline says > "message complete, send it". The exception (no TNL, followed by a call > to pr_cont) proves the general rule. > > Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, > 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks. > > No functional changes. > > Signed-off-by: Jim Cromie Reviewed-by: Andi Shyti Andi