From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFEC4E7C4F0 for ; Wed, 4 Oct 2023 19:47:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7686A10E1A4; Wed, 4 Oct 2023 19:47:19 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 45BDC10E1A4 for ; Wed, 4 Oct 2023 19:47:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696448838; x=1727984838; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=arGymT7Hj3XVdu53FrOFHgmZsDyydtU1Qeorx8uo1tE=; b=OGpp1JKnm49pJWz8BvV71JV4AqZ6fpttKjrTHJcmkNkYi6eR8TCLwsrQ ME7guJvinrc/dB07XkIqY3bFNDReNanIPiyqkYyl8PmOs3znTtyY27OqT KYpdpQd7DefArpUx0JQZNmS05PbMGAzSbPR0jtni6bQ/WPA8HmXv5qUp+ ozorDGui8iAgQk2pofTzSU8pToMOgIKddldd03KbII9tAYcJVj9pPpC3r GukcgkV+oxHX7EDAsK1go0eRPzIfNcwwjbtw5AtSdrPs11E7uB7mltTXf cSBBDKvFASmhlfzw9waXzmj6k9kVqomdZAGbjtzYckn5zmBg3D4pZYopy A==; X-IronPort-AV: E=McAfee;i="6600,9927,10853"; a="383189431" X-IronPort-AV: E=Sophos;i="6.03,201,1694761200"; d="scan'208";a="383189431" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2023 12:47:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10853"; a="751458003" X-IronPort-AV: E=Sophos;i="6.03,201,1694761200"; d="scan'208";a="751458003" Received: from nurf174x-mobl.gar.corp.intel.com (HELO intel.com) ([10.213.147.206]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2023 12:47:08 -0700 Date: Wed, 4 Oct 2023 21:47:01 +0200 From: Andi Shyti To: Andi Shyti Message-ID: References: <20231004183625.1307100-1-jonathan.cavitt@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Intel-gfx] [PATCH v5 1/4] drm/i915: Add GuC TLB Invalidation pci tags X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: janusz.krzysztofik@intel.com, matthew.d.roper@intel.com, intel-gfx@lists.freedesktop.org, Jonathan Cavitt , chris.p.wilson@linux.intel.com, nirmoy.das@intel.com Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" > > > > Add pci (device info) tags for if GuC TLB Invalidation is enabled. > > > > Since GuC based TLB invalidation is only strictly necessary for MTL > > > > resently, only enable GuC based TLB invalidations for MTL. > > > > > > > > Signed-off-by: Jonathan Cavitt > > > Jani was mentioning that the pci tags is not a proper title. > > > > > > No need to resend, I think I will merge this series, so that, if > > > you agree, I can change /pci tags/pci flag/ before pushing. > > Have all the review comments been addressed? Surely it can't be pushed until > > it has at least an ack from everyone who has expressed concerns about the > > changes? and... of course... I won't push it until all the reviews and acks are in place... I just wanted to save Jonathan a v6 just for this change if, in a furtunate case, there won't be other reviews. Andi > this particular patch did not receive any comment so far, except > for the "pci tags" from Jani. > > This solution was somehow hinted by Tvrtko in one of the previous > review, I guess. > > Personally I think that having a pci flag just for this is a bit > of an overkill, but I don't have a strong opinion about it. > > Andi