Re: [Intel-gfx] [PATCH 00/19] drm/i915: Store DSC DPCD capabilities in the connector

Ville Syrjälä
2023-10-10T16:35:38Z

On Fri, Oct 06, 2023 at 04:37:08PM +0300, Imre Deak wrote:
> This patchset moves the DSC DPCD capabilities from the encoder
> (intel_dp) to the connector. This is required since in an MST topology
> each connector has its own version of these capabilities, allowing
> to configure/enable the DSC decompression for each stream separately.
>
> The changes are needed for a follow-up patchset, fixing the MST DSC
> functionality, making it also possible to enable the BW management on
> MST links. The follow-up changes are based on patches 12-25 in
>
> https://lore.kernel.org/all/20230914192659.757475-1-imre.deak@intel.com
>
> Imre Deak (19):
> drm/i915/dp: Sanitize DPCD revision check in
> intel_dp_get_dsc_sink_cap()
> drm/i915/dp: Store DSC DPCD capabilities in the connector
> drm/i915/dp_mst: Set connector DSC capabilities and decompression AUX
> drm/i915/dp: Use i915/intel connector local variables in
> i915_dsc_fec_support_show()
> drm/i915/dp: Use connector DSC DPCD in i915_dsc_fec_support_show()
> drm/i915/dp: Use connector DSC DPCD in intel_dp_dsc_compute_max_bpp()
> drm/i915/dp: Use connector DSC DPCD in intel_dp_supports_fec()
> drm/i915/dp: Use connector DSC DPCD in intel_dp_supports_dsc()
> drm/i915/dp: Use connector DSC DPCD in
> intel_dp_dsc_max_sink_compressed_bppx16()
> drm/i915/dp: Pass connector DSC DPCD to
> drm_dp_dsc_sink_supported_input_bpcs()
> drm/i915/dp: Pass only the required i915 to
> intel_dp_source_dsc_version_minor()
> drm/i915/dp: Pass only the required DSC DPCD to
> intel_dp_sink_dsc_version_minor()
> drm/i915/dp: Use connector DSC DPCD in intel_dp_dsc_compute_params()
> drm/i915/dp: Use connector DSC DPCD in intel_dp_dsc_supports_format()
> drm/i915/dp: Use connector DSC DPCD in intel_dp_dsc_get_slice_count()
> drm/i915/dp: Use connector DSC DPCD in intel_dp_mode_valid()
> drm/i915/dp: Use connector DSC DPCD in intel_dp_dsc_compute_config()
> drm/i915/dp_mst: Use connector DSC DPCD in
> intel_dp_mst_mode_valid_ctx()
> drm/i915/dp: Remove unused DSC caps from intel_dp

Looks reasonable to me. The one open question I have is how the DSC/FEC
capabilities get discovered in the MST topology, but I presume that'll
happen in some followup series.

Series is
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

>
> .../drm/i915/display/intel_display_debugfs.c | 22 +--
> .../drm/i915/display/intel_display_types.h | 8 +-
> drivers/gpu/drm/i915/display/intel_dp.c | 154 ++++++++++--------
> drivers/gpu/drm/i915/display/intel_dp.h | 8 +-
> drivers/gpu/drm/i915/display/intel_dp_mst.c | 35 +++-
> 5 files changed, 136 insertions(+), 91 deletions(-)
>
> --
> 2.39.2

--
Ville Syrjälä
Intel