Re: [Intel-gfx] [PATCH 05/19] drm/i915/dp: Use connector DSC DPCD in i915_dsc_fec_support_show()

Lisovskiy, Stanislav
2023-10-09T14:06:30Z

On Fri, Oct 06, 2023 at 04:37:13PM +0300, Imre Deak wrote:
> Use the connector's DSC DPCD capabilities in i915_dsc_fec_support_show()
> instead of the version stored in the encoder. Atm the two are identical,
> but a follow-up patch will store the (MST) connector specific version
> in the connector.
>
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>

> ---
> drivers/gpu/drm/i915/display/intel_display_debugfs.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index 834a8e50ea4fb..2836826f8c05f 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -1234,19 +1234,19 @@ static int i915_dsc_fec_support_show(struct seq_file *m, void *data)
> seq_printf(m, "DSC_Enabled: %s\n",
> str_yes_no(crtc_state->dsc.compression_enable));
> seq_printf(m, "DSC_Sink_Support: %s\n",
> - str_yes_no(drm_dp_sink_supports_dsc(intel_dp->dsc_dpcd)));
> + str_yes_no(drm_dp_sink_supports_dsc(connector->dp.dsc_dpcd)));
> seq_printf(m, "DSC_Output_Format_Sink_Support: RGB: %s YCBCR420: %s YCBCR444: %s\n",
> - str_yes_no(drm_dp_dsc_sink_supports_format(intel_dp->dsc_dpcd,
> + str_yes_no(drm_dp_dsc_sink_supports_format(connector->dp.dsc_dpcd,
> DP_DSC_RGB)),
> - str_yes_no(drm_dp_dsc_sink_supports_format(intel_dp->dsc_dpcd,
> + str_yes_no(drm_dp_dsc_sink_supports_format(connector->dp.dsc_dpcd,
> DP_DSC_YCbCr420_Native)),
> - str_yes_no(drm_dp_dsc_sink_supports_format(intel_dp->dsc_dpcd,
> + str_yes_no(drm_dp_dsc_sink_supports_format(connector->dp.dsc_dpcd,
> DP_DSC_YCbCr444)));
> seq_printf(m, "Force_DSC_Enable: %s\n",
> str_yes_no(intel_dp->force_dsc_en));
> if (!intel_dp_is_edp(intel_dp))
> seq_printf(m, "FEC_Sink_Support: %s\n",
> - str_yes_no(drm_dp_sink_supports_fec(intel_dp->fec_capable)));
> + str_yes_no(drm_dp_sink_supports_fec(connector->dp.fec_capability)));
> } while (try_again);
>
> drm_modeset_drop_locks(&ctx);
> --
> 2.39.2
>