From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 233E8E95A91 for ; Mon, 9 Oct 2023 14:05:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9BC9910E277; Mon, 9 Oct 2023 14:05:42 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8C80110E265 for ; Mon, 9 Oct 2023 14:05:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696860339; x=1728396339; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=t9fqI+yXrYvD/DqrTKkRJWwZ6zP9MNl0Yg/joyrOsYU=; b=AxhuB7x7cXIhH42BKXQ8ODk9bTwa2t5APF7LuEtZqawDezNRCY7HfaBE jNNhQvoFOO1TqX8yYSozCIYc2zFXasDex2xzNUUvjRAoSFVLaNT5htfSP X9JGBMCn0jL8qju6mAtMNzIx+y2PkxoBJ8OrN3xbT3WoBzCeWLmpuBJEM G+ayw0XcfPQ8btwVdb8wh7riZNOxJOWZC4/TyUNwCvxtmsq9shVe5B+n/ oJtfp7u8DFZSQ3pfM4U/rkJm3HYN1dgfeA70z0RL+ZzBxwck8XxQfVQSJ y0hnD0eSqqEvmSIJp4LyW3xv4UOS5sGFEBgjrLjNze2nKcJwpa8XIpvD5 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10858"; a="374479074" X-IronPort-AV: E=Sophos;i="6.03,210,1694761200"; d="scan'208";a="374479074" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2023 07:05:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10858"; a="729689666" X-IronPort-AV: E=Sophos;i="6.03,210,1694761200"; d="scan'208";a="729689666" Received: from unknown (HELO intel.com) ([10.237.72.65]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2023 07:05:37 -0700 Date: Mon, 9 Oct 2023 17:05:34 +0300 From: "Lisovskiy, Stanislav" To: Imre Deak Message-ID: References: <20231006133727.1822579-1-imre.deak@intel.com> <20231006133727.1822579-20-imre.deak@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231006133727.1822579-20-imre.deak@intel.com> Subject: Re: [Intel-gfx] [PATCH 19/19] drm/i915/dp: Remove unused DSC caps from intel_dp X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Oct 06, 2023 at 04:37:27PM +0300, Imre Deak wrote: > The previous patches converted all users of the DSC DPCD caps to look > these up from the connector, so remove the version stored in intel_dp. > > A follow-up patchset will read out the MST connector specific > capabilities in intel_dp_add_mst_connector() -> > intel_dp_mst_read_decompression_port_dsc_caps(). > > Signed-off-by: Imre Deak Reviewed-by: Stanislav Lisovskiy > --- > drivers/gpu/drm/i915/display/intel_display_types.h | 2 -- > drivers/gpu/drm/i915/display/intel_dp.c | 14 -------------- > 2 files changed, 16 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h > index d6600079bcf74..65ea37fe8cff3 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_types.h > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h > @@ -1725,10 +1725,8 @@ struct intel_dp { > u8 psr_dpcd[EDP_PSR_RECEIVER_CAP_SIZE]; > u8 downstream_ports[DP_MAX_DOWNSTREAM_PORTS]; > u8 edp_dpcd[EDP_DISPLAY_CTL_CAP_SIZE]; > - u8 dsc_dpcd[DP_DSC_RECEIVER_CAP_SIZE]; > u8 lttpr_common_caps[DP_LTTPR_COMMON_CAP_SIZE]; > u8 lttpr_phy_caps[DP_MAX_LTTPR_COUNT][DP_LTTPR_PHY_CAP_SIZE]; > - u8 fec_capable; > u8 pcon_dsc_dpcd[DP_PCON_DSC_ENCODER_CAP_SIZE]; > /* source rates */ > int num_source_rates; > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index f58940c1baf9c..9d504ce2b54a7 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -3514,15 +3514,6 @@ void intel_dp_get_dsc_sink_cap(u8 dpcd_rev, struct intel_dp *intel_dp, > drm_dbg_kms(&i915->drm, "FEC CAPABILITY: %x\n", > connector->dp.fec_capability); > } > - > - /* > - * TODO: remove the following intel_dp copies once all users > - * are converted to look up DSC DPCD/FEC capability via the > - * connector. > - */ > - memcpy(intel_dp->dsc_dpcd, connector->dp.dsc_dpcd, > - sizeof(intel_dp->dsc_dpcd)); > - intel_dp->fec_capable = connector->dp.fec_capability; > } > > static void intel_edp_mso_mode_fixup(struct intel_connector *connector, > @@ -5390,11 +5381,6 @@ intel_dp_detect(struct drm_connector *connector, > > if (status == connector_status_disconnected) { > memset(&intel_dp->compliance, 0, sizeof(intel_dp->compliance)); > - /* > - * TODO: Remove clearing the DPCD in intel_dp, once all > - * user are converted to using the DPCD in connector. > - */ > - memset(intel_dp->dsc_dpcd, 0, sizeof(intel_dp->dsc_dpcd)); > memset(intel_connector->dp.dsc_dpcd, 0, sizeof(intel_connector->dp.dsc_dpcd)); > > if (intel_dp->is_mst) { > -- > 2.39.2 >