From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CBC9CD612E for ; Mon, 9 Oct 2023 19:44:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 65F1910E19E; Mon, 9 Oct 2023 19:44:12 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id A76B610E18C; Mon, 9 Oct 2023 19:44:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696880649; x=1728416649; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=CeuEV85nO2zKrbS3SEVVUhS8o0CnWqg6FDmqanSR9N4=; b=OrO9sy91Ji95kqoa/XR+76DOKC63Hndq5vtAXnVdlyl03ngXF9hAIfts tFUWgnzaOoayhCnbR2DBW4o4uGtxVNLoRq3dMxglAievh0SQ6446mfgKx J4YDexH8uHf2QOgt1hiSBpLA7rvqbFToHVcKMDBPQ34A/DXtWQJvHlE1f 4addCSkXfdjFLjk/GP/BG9h7CzJKfMyzw4YO47+rsdWTrBgbBT0ml0wPt 5Aakr5id6oAnXxMrOHkW2B0o9xTlcAL+iC+bQSYPEJZXovUGsGhXeZUzO OKQb6od6f6/yMdbkfiv11+12GQMr2oVbKizGk4kkVyGrQk+mt86qSJ+E1 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10858"; a="470495032" X-IronPort-AV: E=Sophos;i="6.03,210,1694761200"; d="scan'208";a="470495032" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2023 12:44:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10858"; a="703032908" X-IronPort-AV: E=Sophos;i="6.03,210,1694761200"; d="scan'208";a="703032908" Received: from ibrahim2-mobl2.gar.corp.intel.com (HELO intel.com) ([10.213.42.185]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2023 12:44:01 -0700 Date: Mon, 9 Oct 2023 21:43:55 +0200 From: Andi Shyti To: John Harrison Message-ID: References: <20231006132606.810110-1-andi.shyti@linux.intel.com> <2e44254d-5243-477a-8b2b-35623967ec1f@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2e44254d-5243-477a-8b2b-35623967ec1f@intel.com> Subject: Re: [Intel-gfx] [PATCH] drm/print: Add drm_dbg_ratelimited X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Zimmermann , intel-gfx , Maxime Ripard , dri-devel , Daniel Vetter , Nirmoy Das , David Airlie , Matthew Auld Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi John, > > > From: Nirmoy Das > > > > > > Add a function for ratelimitted debug print. > > > > > > Cc: Maarten Lankhorst > > > Cc: Maxime Ripard > > > Cc: Thomas Zimmermann > > > Cc: David Airlie > > > Cc: Daniel Vetter > > > Reviewed-by: Matthew Auld > > > Reviewed-by: Andi Shyti > > > Signed-off-by: Nirmoy Das > > > Signed-off-by: Andi Shyti > > Just a kind reminder! > > > > This is the second time this patch has been sent and we have seen > > some potential use of the drm_dbg_ratelimited(). > But this patch does not actually add a user. So it is dead code at this > point, which is not allowed. > > If you have code that wants to use such a helper then the helper should be > part of the patch that adds that code. this is the kind of "Argh! If I had it!" patch. At the 3/4th "Argh! If I had it!" then you decide to send it but don't remember for which case you needed it. I'm sure that once this goes in won't be long until poeple will start using it. In any case, if it doesn't go in I will keep it ready until the case comes. Andi