From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0B6ECD6E62 for ; Wed, 11 Oct 2023 12:27:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5393E10E1E1; Wed, 11 Oct 2023 12:27:42 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A4A210E1E1; Wed, 11 Oct 2023 12:27:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697027260; x=1728563260; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=idE2oS7yVV0vjq7IU8rKIdjHqvo3RD2wbqynxjmaFBw=; b=eZR3mLCHzrdUQCb6ERRKrV0qbSH2V7QvIJnUKXSEa8rpo8MSawFqq2OV 4eCZ/BhrN1vb7fpE8uLtCztgI9XnFcdwP+iORlEKXH4J+qwNlT5IsOoku /J/J9WyTihJgPCisGG/uyvlcpjWQYa0uaetgzMQnxchts1ha6FhHmKRiv 4wzmWg8FToA6quLp0LHR82Q2Y9r4mophiW0qHF38HPiM+VvggFOqHNt8G viR0I2iJyxwZzX6BL0DrzfyhP529Ze+msL0knn1ME4zDyTqPTIGPMBPtK QXGACZ26idy3J20BEj8Wm2rH/rkECu8NI1bCH7V/O0SJxIM1CrFWkz90F Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10860"; a="369712489" X-IronPort-AV: E=Sophos;i="6.03,214,1694761200"; d="scan'208";a="369712489" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2023 05:27:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10860"; a="753799494" X-IronPort-AV: E=Sophos;i="6.03,214,1694761200"; d="scan'208";a="753799494" Received: from lyemeeki-mobl2.gar.corp.intel.com (HELO intel.com) ([10.214.156.206]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2023 05:27:35 -0700 Date: Wed, 11 Oct 2023 14:27:29 +0200 From: Andi Shyti To: Nirmoy Das Message-ID: References: <20231011122547.7085-1-nirmoy.das@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231011122547.7085-1-nirmoy.das@intel.com> Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: Prevent potential null-ptr-deref in engine_init_common X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Nirmoy, On Wed, Oct 11, 2023 at 02:25:47PM +0200, Nirmoy Das wrote: > If measure_breadcrumb_dw() returns an error and bce isn't created, > this commit ensures that intel_engine_destroy_pinned_context() > is not called with a NULL bce. > > v2: Fix the subject s/UAF/null-ptr-deref(Jani) > > Fixes: b35274993680 ("drm/i915: Create a kernel context for GGTT updates") > Cc: Oak Zeng > Cc: Andi Shyti > Cc: Jani Nikula > Signed-off-by: Nirmoy Das Reviewed-by: Andi Shyti Andi