From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ADD2CC25B47 for ; Fri, 27 Oct 2023 09:21:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4786210E959; Fri, 27 Oct 2023 09:21:27 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id E353F10E959 for ; Fri, 27 Oct 2023 09:21:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698398484; x=1729934484; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=aRPKartRYjKY1A62A9a2dmgvhlyTz9jeMaPWN10Fu4I=; b=Qw6B2NOExFKGbaMyBTwdUBbPpD6hPMDC3lGhHJMgM+X6onMg2nCGkWs+ ejfaj7WP8yC+KDwscPl/O2Vqm0tksECcV7BrnKgW7TsO9aN3RWG8Q8NNn XbhI8f95jSAHWORL/A84MkDu5iZ476pgL94R3oe6GT1LclGdRzZZOaJYs N//ZwRnDy8908jf5oo6q9CMVmm8kSgvk7FURexNsZ/cbFqi1NWtCRDnv4 Mhdkn+WXGechlxVUFUtc5bDOCTtybLLVHImaKCdIl4k/IYSI74mHwxCO/ P/kr9e2SknmA05zZOhoFN1XWFykRu8JAvJ2lgpJzFjegMFi64hlkrK4bZ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="384948666" X-IronPort-AV: E=Sophos;i="6.03,255,1694761200"; d="scan'208";a="384948666" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2023 02:21:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="788779098" X-IronPort-AV: E=Sophos;i="6.03,255,1694761200"; d="scan'208";a="788779098" Received: from unknown (HELO intel.com) ([10.237.72.65]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2023 02:21:22 -0700 Date: Fri, 27 Oct 2023 12:21:19 +0300 From: "Lisovskiy, Stanislav" To: Imre Deak Message-ID: References: <20231024010925.3949910-1-imre.deak@intel.com> <20231024010925.3949910-6-imre.deak@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231024010925.3949910-6-imre.deak@intel.com> Subject: Re: [Intel-gfx] [PATCH 05/29] drm/dp_mst: Allow DSC in any Synaptics last branch device X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Oct 24, 2023 at 04:09:01AM +0300, Imre Deak wrote: > The Synaptics MST branch deivces support DSC decompression on all their devices > output ports, provided that they are last branch devices (with their > output ports connected to the sinks). The Thinkpad 40B0 TBT dock for > instance has two such branch devices, a secondary one connected to one > of the output ports of the primary; hence the decompression needs to be > enabled in both branch devices to enable decompression for all the > sinks. > > Based on the above add support for enabling decompression in last > Synaptics branch devices. > > Cc: Lyude Paul > Signed-off-by: Imre Deak Reviewed-by: Stanislav Lisovskiy > --- > drivers/gpu/drm/display/drm_dp_mst_topology.c | 21 ++++++++++++------- > 1 file changed, 13 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c > index 5972c93615f18..cc0a8fe84d290 100644 > --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c > +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c > @@ -5994,6 +5994,7 @@ static bool drm_dp_mst_is_virtual_dpcd(struct drm_dp_mst_port *port) > struct drm_dp_aux *drm_dp_mst_dsc_aux_for_port(struct drm_dp_mst_port *port) > { > struct drm_dp_mst_port *immediate_upstream_port; > + struct drm_dp_aux *immediate_upstream_aux; > struct drm_dp_mst_port *fec_port; > struct drm_dp_desc desc = {}; > u8 endpoint_fec; > @@ -6058,21 +6059,25 @@ struct drm_dp_aux *drm_dp_mst_dsc_aux_for_port(struct drm_dp_mst_port *port) > * - Port is on primary branch device > * - Not a VGA adapter (DP_DWN_STRM_PORT_TYPE_ANALOG) > */ > - if (drm_dp_read_desc(port->mgr->aux, &desc, true)) > + if (immediate_upstream_port) > + immediate_upstream_aux = &immediate_upstream_port->aux; > + else > + immediate_upstream_aux = port->mgr->aux; > + > + if (drm_dp_read_desc(immediate_upstream_aux, &desc, true)) > return NULL; > > - if (drm_dp_has_quirk(&desc, DP_DPCD_QUIRK_DSC_WITHOUT_VIRTUAL_DPCD) && > - port->mgr->dpcd[DP_DPCD_REV] >= DP_DPCD_REV_14 && > - port->parent == port->mgr->mst_primary) { > + if (drm_dp_has_quirk(&desc, DP_DPCD_QUIRK_DSC_WITHOUT_VIRTUAL_DPCD)) { > u8 dpcd_ext[DP_RECEIVER_CAP_SIZE]; > > - if (drm_dp_read_dpcd_caps(port->mgr->aux, dpcd_ext) < 0) > + if (drm_dp_read_dpcd_caps(immediate_upstream_aux, dpcd_ext) < 0) > return NULL; > > - if ((dpcd_ext[DP_DOWNSTREAMPORT_PRESENT] & DP_DWN_STRM_PORT_PRESENT) && > + if (dpcd_ext[DP_DPCD_REV] >= DP_DPCD_REV_14 && > + ((dpcd_ext[DP_DOWNSTREAMPORT_PRESENT] & DP_DWN_STRM_PORT_PRESENT) && > ((dpcd_ext[DP_DOWNSTREAMPORT_PRESENT] & DP_DWN_STRM_PORT_TYPE_MASK) > - != DP_DWN_STRM_PORT_TYPE_ANALOG)) > - return port->mgr->aux; > + != DP_DWN_STRM_PORT_TYPE_ANALOG))) > + return immediate_upstream_aux; > } > > /* > -- > 2.39.2 >