From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 604D4C4167D for ; Thu, 2 Nov 2023 14:20:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1F26B89128; Thu, 2 Nov 2023 14:19:57 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 64DEB89128; Thu, 2 Nov 2023 14:19:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698934793; x=1730470793; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=YIoOazyZIxRBLXmipC//1yjCBmIXsr31xOo/Ttayfpw=; b=L/qu+/6P0OEbXeaLA//3+PWkfVdyJ+v7MYTKofEvtktBADnEz3DL3QOX UzUaE7NSq/MiRlxmZMX694LbCoDJSyml0GVbt2QA1CIHHV8BOe2ylV8GL CoqunAIpqT8q7gmyr52GFUX85u3UL+cS1SB7u+JRx0qTKvc5Lk0/lH8TC psPiMFRB4QDriI2qGBzT0mX/TzTovspAwjE7gTZTd+QyRQPezFR4UTjwq jpdVhYGZDqWJNxJln5QA/wtQszQNjrUo2OFYqsaIA4XayiMtR367wjY1a HBrUNke2Hj7v5LoRR7OisBs1aI0Sej7mwM5cqTIsORG8yzbNLpdLsIMH9 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10882"; a="1647428" X-IronPort-AV: E=Sophos;i="6.03,271,1694761200"; d="scan'208";a="1647428" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2023 07:19:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10882"; a="831702572" X-IronPort-AV: E=Sophos;i="6.03,271,1694761200"; d="scan'208";a="831702572" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2023 07:19:49 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC3) (envelope-from ) id 1qyYXy-0000000AhvZ-3fkX; Thu, 02 Nov 2023 16:19:46 +0200 Date: Thu, 2 Nov 2023 16:19:46 +0200 From: Andy Shevchenko To: Hans de Goede Message-ID: References: <20231024155739.3861342-1-andriy.shevchenko@linux.intel.com> <20231024155739.3861342-7-andriy.shevchenko@linux.intel.com> <16e533e2-81bb-47ba-9e23-460a626bcad7@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Subject: Re: [Intel-gfx] [PATCH v2 6/7] drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jani Nikula , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Rodrigo Vivi , David Airlie Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Nov 01, 2023 at 11:20:23AM +0100, Hans de Goede wrote: > On 11/1/23 10:32, Andy Shevchenko wrote: > > On Tue, Oct 31, 2023 at 10:15:52PM +0100, Hans de Goede wrote: > >> On 10/31/23 17:07, Hans de Goede wrote: > >>> On 10/24/23 18:11, Andy Shevchenko wrote: > >>>> On Tue, Oct 24, 2023 at 06:57:38PM +0300, Andy Shevchenko wrote: ... > Note you still need the first part of my patch which is > an unrelated bugfix: > > --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c > +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c > @@ -219,8 +219,7 @@ static void soc_exec_gpio(struct intel_connector *connector, const char *con_id, > } else { > gpio_desc = devm_gpiod_get_index(dev_priv->drm.dev, > con_id, gpio_index, > - value ? GPIOD_OUT_LOW : > - GPIOD_OUT_HIGH); > + value ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW); > if (IS_ERR(gpio_desc)) { > drm_err(&dev_priv->drm, > "GPIO index %u request failed (%pe)\n", Can you attach or send a formal submission, so I can incorporate it into one (v3) series among other changes? -- With Best Regards, Andy Shevchenko