From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA602C4707B for ; Wed, 10 Jan 2024 12:37:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2B86610E5D6; Wed, 10 Jan 2024 12:37:41 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id C582D10E5D6; Wed, 10 Jan 2024 12:37:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mD6sHMBYmecsugPR+rqNjdttLVO7dQDyLXBJHfA3g1Q=; b=OjdQmEOL6PU8ZoQsQV89vQU3uy xumb/fUI9PdT0ruLFWenL+EFY/R95394WPxc2QNSa6b9+lhiCqIZBbDzz//DCiBhiXjxszhvGAjZK lubqlfezkUxprHvhWFewYjO8MlMwV/8XU0qiMYiHWdWD93q+pm7cSJGaTmC7UhcepH6pQkziFJBwT 9zlq4Vm18d/8ENBIIzB64LPPMc7hWRT75a4nD8cKTMDPldLhwu7kCijfcbGe6gCKSr4DmF4rMUVR+ Z9wPq2/O0uuD9eCs7CXUPNcsIOiJH5ON+eRuVhc1opSoEH66EZS2OkOq4FbVIvqfaCEG4y3+dTzRO HZY7dWJg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rNXpe-00BQ5T-V6; Wed, 10 Jan 2024 12:37:18 +0000 Date: Wed, 10 Jan 2024 12:37:18 +0000 From: Matthew Wilcox To: Christoph Hellwig Subject: Re: disable large folios for shmem file used by xfs xfile Message-ID: References: <20240110092109.1950011-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240110092109.1950011-1-hch@lst.de> X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Darrick J . Wong" , dri-devel@lists.freedesktop.org, David Howells , linux-mm@kvack.org, Huang Rui , David Airlie , x86@kernel.org, Hugh Dickins , Dave Hansen , Thomas Zimmermann , intel-gfx@lists.freedesktop.org, Maxime Ripard , Rodrigo Vivi , linux-sgx@vger.kernel.org, Jarkko Sakkinen , keyrings@vger.kernel.org, Daniel Vetter , linux-fsdevel@vger.kernel.org, Andrew Morton , Christian Koenig , Chandan Babu R Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Jan 10, 2024 at 10:21:07AM +0100, Christoph Hellwig wrote: > Hi all, > > Darrick reported that the fairly new XFS xfile code blows up when force > enabling large folio for shmem. This series fixes this quickly by disabling > large folios for this particular shmem file for now until it can be fixed > properly, which will be a lot more invasive. > > I've added most of you to the CC list as I suspect most other users of > shmem_file_setup and friends will have similar issues. The graphics users _want_ to use large folios. I'm pretty sure they've been tested with this. It's just XFS that didn't know about this feature of shmem.