From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 481DBC47074 for ; Thu, 4 Jan 2024 17:17:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CCBEC10E4E5; Thu, 4 Jan 2024 17:17:39 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3B3E610E509 for ; Thu, 4 Jan 2024 17:17:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704388659; x=1735924659; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=F9Z3FynOq2E7WHFTW7uSxi7vFXuDC4sMwr7AinqZvMw=; b=X0qTuhOu0+LiKOIBfiK+QE8ELHUUFkmb0aYF4e2SbPzIPdOMdyFqMTuV pXZ0AOmPgL7Y9gdbXmWRobcyvJ7AfzCn/FRMxxyIQ15BBfh6qkjaFjIMj +HkD9I6zDmJ8Wj+lEN6H06i63q1e74VnPYadQ6j6FO9kxKY/RdoLnLER7 YyRcucYiTMcktALv0P6UIUCT1G7rmhnwB/sLAoUIf6O3MZSNObqCgySTm qclCMpGyIfVgZkiyffrou5jLdGeQ5NBgKfXYrsfhrDQvwWtQuc4Cn8NOu UxBnGg7dEPonDy+pcFEUitdZ6EEapPNaMMRJIJYkv4fjmdgZ9/KjEDEb8 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10943"; a="4413712" X-IronPort-AV: E=Sophos;i="6.04,331,1695711600"; d="scan'208";a="4413712" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2024 09:17:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10943"; a="756685882" X-IronPort-AV: E=Sophos;i="6.04,331,1695711600"; d="scan'208";a="756685882" Received: from ideak-desk.fi.intel.com ([10.237.72.78]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2024 09:17:28 -0800 Date: Thu, 4 Jan 2024 19:17:39 +0200 From: Imre Deak To: Jani Nikula Subject: Re: [PATCH] drm/i915: don't make assumptions about intel_wakeref_t type Message-ID: References: <20240104164600.783371-1-jani.nikula@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240104164600.783371-1-jani.nikula@intel.com> X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: imre.deak@intel.com Cc: Stephen Rothwell , intel-gfx@lists.freedesktop.org, Andrzej Hajda Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Jan 04, 2024 at 06:46:00PM +0200, Jani Nikula wrote: > intel_wakeref_t is supposed to be a mostly opaque cookie to its > users. It should only be checked for being non-zero and set to > zero. Debug logging its actual value is meaningless. Switch to just > debug logging whether the async_put_wakeref is non-zero. > > The issue dates back to much earlier than > commit b49e894c3fd8 ("drm/i915: Replace custom intel runtime_pm tracker > with ref_tracker library"), but this is the one that brought about a > build failure due to the printf format. > > Reported-by: Stephen Rothwell > Closes: https://lore.kernel.org/r/20240102111222.2db11208@canb.auug.org.au > Fixes: b49e894c3fd8 ("drm/i915: Replace custom intel runtime_pm tracker with ref_tracker library") > Cc: Andrzej Hajda > Cc: Imre Deak > Signed-off-by: Jani Nikula Reviewed-by: Imre Deak > --- > drivers/gpu/drm/i915/display/intel_display_power.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c > index 5f091502719b..6fd4fa52253a 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_power.c > +++ b/drivers/gpu/drm/i915/display/intel_display_power.c > @@ -405,8 +405,8 @@ print_async_put_domains_state(struct i915_power_domains *power_domains) > struct drm_i915_private, > display.power.domains); > > - drm_dbg(&i915->drm, "async_put_wakeref %lu\n", > - power_domains->async_put_wakeref); > + drm_dbg(&i915->drm, "async_put_wakeref: %s\n", > + str_yes_no(power_domains->async_put_wakeref)); > > print_power_domains(power_domains, "async_put_domains[0]", > &power_domains->async_put_domains[0]); > -- > 2.39.2 >