From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C556C48BC4 for ; Tue, 20 Feb 2024 19:41:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8786310E54F; Tue, 20 Feb 2024 19:41:34 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="M9lP/VT1"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id A806210E54C; Tue, 20 Feb 2024 19:41:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708458093; x=1739994093; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=DfJFKhyZQ/N2e0vgOg52j7ksnYxhMPQZuRpCjJttMhE=; b=M9lP/VT1c2bnJBiYkdxmLdWe50miSLqpGZdKXkNf59g34eCWFThboBnZ MNCBPJuG1j5l/LhWz7Hch7Ygkq8s1RtKLgLuqK1QGNY3kZRLX6abuMjEM VcN2hDL0ic+YsLrhT9VfFF/M+Xx4RrIVuRniTvpHnXfPIzn+jVMzLPCrQ lwzMxqteR8BSIF2NRS7cFVTifWcyOMM4ldpNnUuYjZAIG5lATOYgRw48o 72/ziEx+liVNW0RE3g0QFCzSfdyNqo03LW5T6Zki5LWX/x6CDGN5vQOnc 8a1GrOgsoECACOrj4WkxrvV3QX/v0mpJ3ax+khYg+F0ukgiqSzgsZDfzG w==; X-IronPort-AV: E=McAfee;i="6600,9927,10990"; a="13704394" X-IronPort-AV: E=Sophos;i="6.06,174,1705392000"; d="scan'208";a="13704394" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Feb 2024 11:41:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10990"; a="827202660" X-IronPort-AV: E=Sophos;i="6.06,174,1705392000"; d="scan'208";a="827202660" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.74]) by orsmga001.jf.intel.com with SMTP; 20 Feb 2024 11:41:26 -0800 Received: by stinkbox (sSMTP sendmail emulation); Tue, 20 Feb 2024 21:41:25 +0200 Date: Tue, 20 Feb 2024 21:41:25 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Abhinav Kumar Cc: Dmitry Baryshkov , dri-devel@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , robdclark@gmail.com, freedreno@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, quic_jesszhan@quicinc.com, linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org Subject: Re: [PATCH v2] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper Message-ID: References: <20240215190834.3222812-1-quic_abhinavk@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Feb 20, 2024 at 11:27:18AM -0800, Abhinav Kumar wrote: > > > On 2/20/2024 11:20 AM, Dmitry Baryshkov wrote: > > On Tue, 20 Feb 2024 at 21:05, Dmitry Baryshkov > > wrote: > >> > >> On Tue, 20 Feb 2024 at 20:53, Abhinav Kumar wrote: > >>> > >>> > >>> > >>> On 2/20/2024 10:49 AM, Dmitry Baryshkov wrote: > >>>> On Thu, 15 Feb 2024 at 21:08, Abhinav Kumar wrote: > >>>>> > >>>>> intel_dp_vsc_sdp_pack() can be re-used by other DRM drivers as well. > >>>>> Lets move this to drm_dp_helper to achieve this. > >>>>> > >>>>> changes in v2: > >>>>> - rebased on top of drm-tip > >>>>> > >>>>> Acked-by: Dmitry Baryshkov > >>>> > >>>> v1 had an explicit comment before the ack: > >>>> > >>> > >>> Yes, I remember the comment. I did not make any changes to v2 other than > >>> just rebasing it on drm-tip to get the ack from i915 folks. > >>> > >>>>> From my side, with the promise of the size fixup. > >>>> > >>>> However I observe neither a second patch removing the size argument > >>>> nor it being dropped as a part of this patch. > >>>> > >>> > >>> Yes, now that in v2 we got the ack for this patch, I can spin a v3 with > >>> the addition of the next patch to remove the size OR as another series > >>> so as to not block the main series which needs this patch. > >>> > >>> I would prefer the latter. > >> > >> It doesn't work this way. The comment should have been fixed for v2. > > > > This probably deserves some explanation. Currently there is only one > > user of this function. So it is easy to fix it. Once there are several > > users, you have to fix all of them at the same time, patching > > different drm subtrees. That complicates the life of maintainers. > > > > Yes, understood. Its easier to fix it now if its really needed. > > Actually, I think the reason the size was passed was to make sure > a valid struct dp_sdp *sdp was being passed. The size is supposed to be the size of *hardware* buffer where this gets written into. But looks like this wasn't done correctly when the code was copy-pasted from the HDMI inforframe code. -- Ville Syrjälä Intel