From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Subject: Re: [PATCH 8/8] drm/i915: Handle joined pipes inside hsw_crtc_disable()
Date: Fri, 1 Mar 2024 18:15:51 +0200 [thread overview]
Message-ID: <ZeH_N1G-_EZXRxAU@intel.com> (raw)
In-Reply-To: <20240301143600.1334-9-ville.syrjala@linux.intel.com>
On Fri, Mar 01, 2024 at 04:36:00PM +0200, Ville Syrjala wrote:
> /*
> * We need to disable pipe CRC before disabling the pipe,
> * or we race against vblank off.
> */
> - intel_crtc_disable_pipe_crc(crtc);
> + for_each_intel_crtc_in_pipe_mask(&dev_priv->drm, crtc, pipe_mask)
> + intel_crtc_disable_pipe_crc(crtc);
Oh, and the pipe crc stuff is one thing we probably should spend some
brain cells on. The pfit/plane CRCs are per-pipe, so we should either
handle it in igt somehow, or we need come up with some kind of scheme
to combine the CRCs from all the joined pipes in the kernel so that
userspace doesn't have to deal with them.
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2024-03-01 16:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 14:35 [PATCH 0/8] drm/i915: Bigjoiner stuff Ville Syrjala
2024-03-01 14:35 ` [PATCH 1/8] drm/i915: Rename the crtc/crtc_states in the top level DDI hooks/etc Ville Syrjala
2024-03-05 8:41 ` Lisovskiy, Stanislav
2024-03-05 8:50 ` Ville Syrjälä
2024-03-05 9:08 ` Lisovskiy, Stanislav
2024-03-05 9:19 ` Ville Syrjälä
2024-03-05 14:07 ` Jani Nikula
2024-03-05 14:34 ` Ville Syrjälä
2024-03-05 14:57 ` Jani Nikula
2024-03-01 14:35 ` [PATCH 2/8] drm/i915: Introduce intel_crtc_joined_pipe_mask() Ville Syrjala
2024-03-01 14:35 ` [PATCH 3/8] drm/i915: Extract intel_ddi_post_disable_hdmi_or_sst() Ville Syrjala
2024-03-05 8:47 ` Lisovskiy, Stanislav
2024-03-01 14:35 ` [PATCH 4/8] drm/i915: Utilize intel_crtc_joined_pipe_mask() more Ville Syrjala
2024-03-01 14:35 ` [PATCH 5/8] drm/i915: Precompute disable_pipes bitmask in intel_commit_modeset_disables() Ville Syrjala
2024-03-05 8:49 ` Lisovskiy, Stanislav
2024-03-01 14:35 ` [PATCH 6/8] drm/i915: Disable planes more atomically during modesets Ville Syrjala
2024-03-05 8:58 ` Lisovskiy, Stanislav
2024-03-01 14:35 ` [PATCH 7/8] drm/i915: Simplify intel_old_crtc_state_disables() calling convention Ville Syrjala
2024-03-05 8:59 ` Lisovskiy, Stanislav
2024-03-01 14:36 ` [PATCH 8/8] drm/i915: Handle joined pipes inside hsw_crtc_disable() Ville Syrjala
2024-03-01 16:04 ` Lisovskiy, Stanislav
2024-03-01 16:10 ` Ville Syrjälä
2024-03-01 16:22 ` Lisovskiy, Stanislav
2024-03-01 16:47 ` Ville Syrjälä
2024-03-04 8:55 ` Lisovskiy, Stanislav
2024-03-01 16:08 ` Lisovskiy, Stanislav
2024-03-01 16:15 ` Ville Syrjälä [this message]
2024-03-01 17:23 ` [PATCH v2 " Ville Syrjala
2024-03-04 6:44 ` Srinivas, Vidya
2024-03-04 10:20 ` Lisovskiy, Stanislav
2024-03-01 19:54 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Bigjoiner stuff (rev2) Patchwork
2024-03-01 20:12 ` ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeH_N1G-_EZXRxAU@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stanislav.lisovskiy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).