From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34E66C54E41 for ; Tue, 5 Mar 2024 14:34:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 89ADE10E13B; Tue, 5 Mar 2024 14:34:26 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="TALH68jy"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id D794510E13B for ; Tue, 5 Mar 2024 14:34:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709649265; x=1741185265; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Qj3f7FW2GrtSfyELwMQpwn6AL8eB8woMjglRE/JftVI=; b=TALH68jyEJRoTzih5fojntpf9luMtL0vWpIu/RcdNsLq2QukYoGDfwJZ SoZKTkrUFz0oql/fkvQSD/upZP1F+mJtJN8kCqC2Qs4Q04fNxeWVrcoVH dbDUjOhsPXSEl6OW0gKZf4dYs+Nf3vAlrSscL9Yy5hfgOMYw9J6EEv/Bm sAvYCxO+SkBSAv1LHHxGLQHdszrD4zg52DL4Zl35lTry7A/+J30n2JXrw Ch1+fdKwlwhg+0MCS0bfjQuKkPiFvysAPYLOX5yTBKOc6LkJhMW3Py15W Gi4EN4IPudwq5qU2Wz3I6RMZT8ydWzmgAxsqfyJu2nk/f6eCOp0Co4ZTI A==; X-IronPort-AV: E=McAfee;i="6600,9927,11003"; a="4367246" X-IronPort-AV: E=Sophos;i="6.06,205,1705392000"; d="scan'208";a="4367246" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2024 06:34:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11003"; a="827773870" X-IronPort-AV: E=Sophos;i="6.06,205,1705392000"; d="scan'208";a="827773870" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.74]) by orsmga001.jf.intel.com with SMTP; 05 Mar 2024 06:34:21 -0800 Received: by stinkbox (sSMTP sendmail emulation); Tue, 05 Mar 2024 16:34:20 +0200 Date: Tue, 5 Mar 2024 16:34:20 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Cc: "Lisovskiy, Stanislav" , intel-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/8] drm/i915: Rename the crtc/crtc_states in the top level DDI hooks/etc Message-ID: References: <20240301143600.1334-1-ville.syrjala@linux.intel.com> <20240301143600.1334-2-ville.syrjala@linux.intel.com> <87sf1422mm.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87sf1422mm.fsf@intel.com> X-Patchwork-Hint: comment X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Mar 05, 2024 at 04:07:45PM +0200, Jani Nikula wrote: > On Tue, 05 Mar 2024, Ville Syrjälä wrote: > > On Tue, Mar 05, 2024 at 10:41:49AM +0200, Lisovskiy, Stanislav wrote: > >> I also wonder whether should we really emphasize things like "master"/"slave" > >> in function names. I thought that one idea in our refactoring was to unify > >> joined pipes handling so that there are no(or at least almost no) explicit code > >> paths/function names for masters/slaves. > > > > There are no master vs. slave functions. The split is going to be > > transcoder/port vs. pipe. > > Besides, for modern platforms the spec has already been changed to use > primary/secondary terminology. When renaming or refactoring stuff, > please switch to them instead of sticking with master/slave. If the spec got updated then we should probably just do a full rename pass over the whole codebase instead of confusing things more by mixing up the terminology. Also we should probably s/bigjoiner/joiner/ to make it clear that all of it also applies to uncompressed joiner as well. -- Ville Syrjälä Intel