intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Paz Zcharya <pazz@chromium.org>
To: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Cc: intel-gfx@lists.freedesktop.org, jani.saarinen@intel.com,
	ville.syrjala@linux.intel.com
Subject: Re: [PATCH 1/2] drm/i915: Update mbus in intel_dbuf_mbus_update and do it properly
Date: Tue, 5 Mar 2024 19:52:32 +0000	[thread overview]
Message-ID: <Zed4AMj66C-pmSAK@google.com> (raw)
In-Reply-To: <20240228080213.17441-2-stanislav.lisovskiy@intel.com>

On Wed, Feb 28, 2024 at 10:02:12AM +0200, Stanislav Lisovskiy wrote:
> According to BSpec we need to do correspondent MBUS updates before
> or after DBUF reallocation, depending on whether we are reducing
> or increasing amount of pipes(typical scenario is swithing between
> multiple and single displays).
> 
> As of BSpec 49213 if we are swithing from multiple to single display
> MBUS registers should be updated with correspondent values _before_
> Dbuf reallocation happens, however if we are switching from single
> display to multiple then it should happen _after_ DDB reallocation(i.e
> plane programming).
> 
> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Thank you for this patch, Stanislav!
We tested it on a MTL-U based Chromebook (Screebo),
using different configurations (eDP, eDP + HDMI, HDMI, etc.), and
it worked well -- joined the mbus + no visual issues or i915 errors.

Tested-by: Paz Zcharya <pazz@chromium.org>

  reply	other threads:[~2024-03-05 19:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-28  8:02 [PATCH 0/2] Enable fastset for mbus_join state change Stanislav Lisovskiy
2024-02-28  8:02 ` [PATCH 1/2] drm/i915: Update mbus in intel_dbuf_mbus_update and do it properly Stanislav Lisovskiy
2024-03-05 19:52   ` Paz Zcharya [this message]
2024-02-28  8:02 ` [PATCH 2/2] drm/i915: Implement vblank synchronized MBUS join changes Stanislav Lisovskiy
2024-03-05 19:54   ` Paz Zcharya
2024-03-08 10:07   ` Ville Syrjälä
2024-03-08 13:43     ` Lisovskiy, Stanislav
2024-03-08 15:11       ` Ville Syrjälä
2024-03-11  9:41         ` Lisovskiy, Stanislav
2024-02-28  8:45 ` ✗ Fi.CI.CHECKPATCH: warning for Enable fastset for mbus_join state change Patchwork
2024-02-28  8:56 ` ✓ Fi.CI.BAT: success " Patchwork
2024-02-28 23:21 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zed4AMj66C-pmSAK@google.com \
    --to=pazz@chromium.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.saarinen@intel.com \
    --cc=stanislav.lisovskiy@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).