From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0BA4C6FD1F for ; Tue, 26 Mar 2024 16:24:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3C50B10ECDC; Tue, 26 Mar 2024 16:24:18 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="c7FNJCKa"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 588CB10ECDC; Tue, 26 Mar 2024 16:24:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711470257; x=1743006257; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=FfwX0VEtAy+auA9LmxwyTk7bWi3IdaPEomwQSo/jBEQ=; b=c7FNJCKaNhLmJ9sLuCBpQcPzFQiQUmGmq1RyidCbkWrrXvZc26IxL8gG s9gDmSptwHs4hFhU2SRMQlT20IkXyVYhFaOLvAAQ7+c/CSGgx3Eklfikl CyTsdiHUJ2BLoeaphd6N1S+M9cNdiETBGvyM/D/m7IyPMPwZM65T8XrWQ agAmUILKmzIcpUHbwSdbXlqwoFdXLEykB3d8IX64rN74AUKZfOeujhjqm DIo/zSMTwWkKbdSlG//2dRJVHV/w5X6VTjW457PHQIKNgci3qsaWP8RKj 2ea4PRNxPFu/dSX4uGvpeiotMzgF9rLfwUlU4cwqInn40USdctAhxcvpL A==; X-CSE-ConnectionGUID: ZfkmE7HjQFGF/aedjjsh9w== X-CSE-MsgGUID: fX2hANMtRg2koWDn/3ur0Q== X-IronPort-AV: E=McAfee;i="6600,9927,11025"; a="10332383" X-IronPort-AV: E=Sophos;i="6.07,156,1708416000"; d="scan'208";a="10332383" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2024 09:24:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,156,1708416000"; d="scan'208";a="47026954" Received: from unknown (HELO intel.com) ([10.247.118.204]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2024 09:24:10 -0700 Date: Tue, 26 Mar 2024 17:24:03 +0100 From: Andi Shyti To: Andi Shyti Cc: intel-gfx , dri-devel , Chris Wilson , Joonas Lahtinen , Matt Roper , John Harrison , stable@vger.kernel.org, Andi Shyti , Tvrtko Ursulin , michal.mrozek@intel.com, mark.j.buxton@intel.com Subject: Re: [PATCH v6 0/3] Disable automatic load CCS load balancing Message-ID: References: <20240313201955.95716-1-andi.shyti@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240313201955.95716-1-andi.shyti@linux.intel.com> X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Michal, Mark, can you please ack from your side this first batch of changes? Thanks, Andi On Wed, Mar 13, 2024 at 09:19:48PM +0100, Andi Shyti wrote: > Hi, > > this series does basically two things: > > 1. Disables automatic load balancing as adviced by the hardware > workaround. > > 2. Assigns all the CCS slices to one single user engine. The user > will then be able to query only one CCS engine > > >From v5 I have created a new file, gt/intel_gt_ccs_mode.c where > I added the intel_gt_apply_ccs_mode(). In the upcoming patches, > this file will contain the implementation for dynamic CCS mode > setting. > > Thanks Tvrtko, Matt, John and Joonas for your reviews! > > Andi > > Changelog > ========= > v5 -> v6 (thanks Matt for the suggestions in v6) > - Remove the refactoring and the for_each_available_engine() > macro and instead do not create the intel_engine_cs structure > at all. > - In patch 1 just a trivial reordering of the bit definitions. > > v4 -> v5 > - Use the workaround framework to do all the CCS balancing > settings in order to always apply the modes also when the > engine resets. Put everything in its own specific function to > be executed for the first CCS engine encountered. (Thanks > Matt) > - Calculate the CCS ID for the CCS mode as the first available > CCS among all the engines (Thanks Matt) > - create the intel_gt_ccs_mode.c function to host the CCS > configuration. We will have it ready for the next series. > - Fix a selftest that was failing because could not set CCS2. > - Add the for_each_available_engine() macro to exclude CCS1+ and > start using it in the hangcheck selftest. > > v3 -> v4 > - Reword correctly the comment in the workaround > - Fix a buffer overflow (Thanks Joonas) > - Handle properly the fused engines when setting the CCS mode. > > v2 -> v3 > - Simplified the algorithm for creating the list of the exported > uabi engines. (Patch 1) (Thanks, Tvrtko) > - Consider the fused engines when creating the uabi engine list > (Patch 2) (Thanks, Matt) > - Patch 4 now uses a the refactoring from patch 1, in a cleaner > outcome. > > v1 -> v2 > - In Patch 1 use the correct workaround number (thanks Matt). > - In Patch 2 do not add the extra CCS engines to the exposed > UABI engine list and adapt the engine counting accordingly > (thanks Tvrtko). > - Reword the commit of Patch 2 (thanks John). > > Andi Shyti (3): > drm/i915/gt: Disable HW load balancing for CCS > drm/i915/gt: Do not generate the command streamer for all the CCS > drm/i915/gt: Enable only one CCS for compute workload > > drivers/gpu/drm/i915/Makefile | 1 + > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 20 ++++++++--- > drivers/gpu/drm/i915/gt/intel_gt_ccs_mode.c | 39 +++++++++++++++++++++ > drivers/gpu/drm/i915/gt/intel_gt_ccs_mode.h | 13 +++++++ > drivers/gpu/drm/i915/gt/intel_gt_regs.h | 6 ++++ > drivers/gpu/drm/i915/gt/intel_workarounds.c | 30 ++++++++++++++-- > 6 files changed, 103 insertions(+), 6 deletions(-) > create mode 100644 drivers/gpu/drm/i915/gt/intel_gt_ccs_mode.c > create mode 100644 drivers/gpu/drm/i915/gt/intel_gt_ccs_mode.h > > -- > 2.43.0