From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49E5FC4345F for ; Thu, 11 Apr 2024 14:26:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 841A910F10E; Thu, 11 Apr 2024 14:26:41 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="ZuJ3BUe0"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5678110F10E for ; Thu, 11 Apr 2024 14:26:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712845599; x=1744381599; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=PpTAx56quAXUqHSgUOFtlECLGTH0tWdsnE+EHTkZ/pg=; b=ZuJ3BUe0LMClKKCJ6BZAu8+Ud9jcC7yGu+VjQWR8UaHemXZIHIeGV+SQ GrGLdsJF/QRyLPibYgL2zRXXp0D4nQvmFaioE7jBJJsrdMOphBMpuhBeF NhSZcP9b1P1NgYWMPciOn9J8M0gTVG5Gg2UgxhuJhBGv3sEbnVfvszwlG xzlTtViiEU4xD/ZOUhjV4Z36sL/m6o38L2IdNHy7xdOOH03vhys17GBLI TOZsN4y3E8cWAanxZrjyXAy256O25zec3vteoBMmSnHpryFp1OiJ8YWSi sXNzXgakGYCrhO6gJrDSVhK+AFnXj5GeBojP/dVnQDlfLAP6GJPd0nYGl w==; X-CSE-ConnectionGUID: DrT/HBD9SeKqkI0uGQVhNA== X-CSE-MsgGUID: wjum8FAMRnSnSqjCNzemEQ== X-IronPort-AV: E=McAfee;i="6600,9927,11041"; a="8113535" X-IronPort-AV: E=Sophos;i="6.07,193,1708416000"; d="scan'208";a="8113535" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2024 07:26:39 -0700 X-CSE-ConnectionGUID: edGH7NHaRbSKWYwA7bcNUA== X-CSE-MsgGUID: GEhMktrwTyepP9iZiiV3OA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,193,1708416000"; d="scan'208";a="44196486" Received: from unknown (HELO intel.com) ([10.247.119.2]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2024 07:26:34 -0700 Date: Thu, 11 Apr 2024 16:26:28 +0200 From: Andi Shyti To: Nirmoy Das Cc: Andi Shyti , intel-gfx , Chris Wilson , Nirmoy Das , Lionel Landwerlin , Andi Shyti Subject: Re: [PATCH v2 2/2] drm/i915/gem: Calculate object page offset for partial memory mapping Message-ID: References: <20240329163959.791865-1-andi.shyti@linux.intel.com> <20240329163959.791865-3-andi.shyti@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Nirmoy, On Thu, Apr 11, 2024 at 04:18:41PM +0200, Nirmoy Das wrote: > Hi Andi, > > On 3/29/2024 5:39 PM, Andi Shyti wrote: > > To enable partial memory mapping of GPU virtual memory, it's > > necessary to introduce an offset to the object's memory > > (obj->mm.pages) scatterlist. This adjustment compensates for > > instances when userspace mappings do not start from the beginning > > of the object. > > I quickly tried https://gitlab.freedesktop.org/llandwerlin/igt-gpu-tools/-/tree/wip/gem_mmap_offset-partial-unmap?ref_type=heads > that didn't work for GTT. > > Please make sure a proper IGT test is available for this as this looks very > risky change. Yes, I have igt's ready and a new v3. Thanks for trying this out. Andi