Re: [PATCH v2 12/21] drm/i915/dp: Use check link state work in the detect handler

Ville Syrjälä
2024-05-23T15:08:45Z

On Mon, May 20, 2024 at 09:58:10PM +0300, Imre Deak wrote:
> Simplify things by retraining a DP link if a bad link is detected in the
> connector detect handler from the encoder's check link state work,
> similarly to how this is done after a modeset link training failure.
>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index ff4ed6bb520d8..70b00e5ae7ad7 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -5863,11 +5863,8 @@ intel_dp_detect(struct drm_connector *connector,
> * Some external monitors do not signal loss of link synchronization
> * with an IRQ_HPD, so force a link status check.
> */
> - if (!intel_dp_is_edp(intel_dp)) {
> - ret = intel_dp_retrain_link(encoder, ctx);
> - if (ret)
> - return ret;
> - }
> + if (!intel_dp_is_edp(intel_dp))
> + intel_dp_check_link_state(intel_dp);

I would like to see this hack nuked entirely. But that
could be a followup.

>
> /*
> * Clearing NACK and defer counts to get their exact values
> --
> 2.43.3

--
Ville Syrjälä
Intel