From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DAFE8C25B7D for ; Thu, 23 May 2024 15:29:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3419310E929; Thu, 23 May 2024 15:29:43 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="cBelMDfY"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2EF7D10E93C for ; Thu, 23 May 2024 15:29:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716478179; x=1748014179; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=2OF67paVScJc6N6aOy/79libhPbPJgaupMrPZT5Rw3k=; b=cBelMDfYSO0xdm6utjE7ecAQcH+dlNmfz/dcp2CpAVDx/0PwjZoNzPWR g/FdqlcBrxY/g5cf84an14y6gBIS2XA28JmZfjogo6vEo6pcoq0G5d/e7 EQBO89Vtr8UgyLNzRKmaXVetTIQodvRdZoLzZjWyhaCpqjudyTyQ9puKm REsYHNqDKd+EgaWt4SSZ5jLJDlrWkR45h3QGYc368LfrCQ+uZ9uaeTpep X2sXFcJYMCujcq96UZE37o3m6mmyn8W8U5x9V18QVH9nWZV4BNz/nQdac nq50xVZ/u/F0DsizDcldSK/G0EAQMkRV25hprYs+me3H5Y7Mz4ImzscV/ w==; X-CSE-ConnectionGUID: sfa1QAeBQT6YAjaN4yLuXg== X-CSE-MsgGUID: aaMNpfVgRNWGdnPSkO4qyg== X-IronPort-AV: E=McAfee;i="6600,9927,11081"; a="35318595" X-IronPort-AV: E=Sophos;i="6.08,183,1712646000"; d="scan'208";a="35318595" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2024 08:29:39 -0700 X-CSE-ConnectionGUID: 23fYeW4VTFaKf+TQfojKCg== X-CSE-MsgGUID: pFjfQ4zISYq1keSMQSceQw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,183,1712646000"; d="scan'208";a="33678192" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.74]) by fmviesa008.fm.intel.com with SMTP; 23 May 2024 08:29:35 -0700 Received: by stinkbox (sSMTP sendmail emulation); Thu, 23 May 2024 18:29:34 +0300 Date: Thu, 23 May 2024 18:29:34 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Imre Deak Cc: intel-gfx@lists.freedesktop.org, Jani Nikula Subject: Re: [PATCH v2 19/21] drm/i915/dp: Add debugfs entry to force link training failure Message-ID: References: <20240520185822.3725844-1-imre.deak@intel.com> <20240520185822.3725844-20-imre.deak@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240520185822.3725844-20-imre.deak@intel.com> X-Patchwork-Hint: comment X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, May 20, 2024 at 09:58:17PM +0300, Imre Deak wrote: > Add a connector debugfs entry to force a failure during the following > 1-2 link training. The entry will auto-reset after the specified link > training events are complete. > > v2: Add the entry from intel_dp_link_training.c (Jani) > > Cc: Jani Nikula > Signed-off-by: Imre Deak > --- > .../drm/i915/display/intel_display_types.h | 1 + > .../drm/i915/display/intel_dp_link_training.c | 52 ++++++++++++++++++- > 2 files changed, 52 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h > index e1c41cece249d..dbe1468fe471d 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_types.h > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h > @@ -1770,6 +1770,7 @@ struct intel_dp { > bool retrain_disabled; > /* Sequential link training failures after a passing LT */ > int seq_train_failures; > + int force_train_failure; > } link; > bool reset_link_params; > int mso_link_count; > diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > index 764187bc42ff9..b40148a42f442 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > @@ -1489,7 +1489,10 @@ void intel_dp_start_link_train(struct intel_atomic_state *state, > else > passed = intel_dp_link_train_all_phys(intel_dp, crtc_state, lttpr_count); > > - if (passed) { > + if (intel_dp->link.force_train_failure) { > + intel_dp->link.force_train_failure--; > + lt_dbg(intel_dp, DP_PHY_DPRX, "Forcing link training failure\n"); > + } else if (passed) { > intel_dp->link.seq_train_failures = 0; > intel_ddi_queue_link_check(dig_port, 2000); > return; > @@ -1799,6 +1802,50 @@ static int i915_dp_max_lane_count_show(void *data, u64 *val) > } > DEFINE_DEBUGFS_ATTRIBUTE(i915_dp_max_lane_count_fops, i915_dp_max_lane_count_show, NULL, "%llu\n"); > > +static int i915_dp_force_link_training_failure_show(void *data, u64 *val) > +{ > + struct intel_connector *connector = to_intel_connector(data); > + struct drm_i915_private *i915 = to_i915(connector->base.dev); > + struct intel_dp *intel_dp; > + int err; > + > + err = drm_modeset_lock_single_interruptible(&i915->drm.mode_config.connection_mutex); > + if (err) > + return err; > + > + intel_dp = intel_connector_to_intel_dp(connector); > + *val = intel_dp->link.force_train_failure; > + > + drm_modeset_unlock(&i915->drm.mode_config.connection_mutex); > + > + return 0; > +} > + > +static int i915_dp_force_link_training_failure_write(void *data, u64 val) > +{ > + struct intel_connector *connector = to_intel_connector(data); > + struct drm_i915_private *i915 = to_i915(connector->base.dev); > + struct intel_dp *intel_dp; > + int err; > + > + if (val > 2) Why 2 specifically? > + return -EINVAL; > + > + err = drm_modeset_lock_single_interruptible(&i915->drm.mode_config.connection_mutex); > + if (err) > + return err; > + > + intel_dp = intel_connector_to_intel_dp(connector); > + intel_dp->link.force_train_failure = val; > + > + drm_modeset_unlock(&i915->drm.mode_config.connection_mutex); > + > + return 0; > +} > +DEFINE_DEBUGFS_ATTRIBUTE(i915_dp_force_link_training_failure_fops, > + i915_dp_force_link_training_failure_show, > + i915_dp_force_link_training_failure_write, "%llu\n"); > + > void intel_dp_link_training_debugfs_add(struct intel_connector *connector) > { > struct dentry *root = connector->base.debugfs_entry; > @@ -1818,4 +1865,7 @@ void intel_dp_link_training_debugfs_add(struct intel_connector *connector) > > debugfs_create_file("i915_dp_max_lane_count", 0444, root, > connector, &i915_dp_max_lane_count_fops); > + > + debugfs_create_file("i915_dp_force_link_training_failure", 0644, root, > + connector, &i915_dp_force_link_training_failure_fops); > } > -- > 2.43.3 -- Ville Syrjälä Intel