From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74D4EC25B75 for ; Wed, 29 May 2024 16:51:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 97702113C17; Wed, 29 May 2024 16:51:39 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="ZLMIkLb6"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0F79110F50B for ; Wed, 29 May 2024 16:51:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717001499; x=1748537499; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:content-transfer-encoding:in-reply-to; bh=/5hlxRuwXt8HgF+iJor5GR5ly7JaVMXw+7q7oBHupso=; b=ZLMIkLb6DaV08r7AXRcdXwanFFPOx5Fyv1x4E0CHGrenPKvwkWGDOvGO AFwfls5m4RBV4dULAh5fPVpjEf9KpYAuCIYgaPt5w0BEyZJS/6PeFgfRu Pgb7XpQdrjdc1Q8ouLThcgtBuxExA+5g2CSiyKKwnlAtbrVAWg0GJRzi/ 8ShF2JumTeNvGM/OfRwx8VlDbYESzrrYzk8R2/2s9PMTx94BCxrGPaXge A2MvVGfMyjZ2TAZGEHGuSt7Es8FDGUAuLrgnvbSaIec/vJsWHj5Sk4H4L 1kE54s5YEo/TO+IBcu+s9e6BqCjd1MnTV5VWuY6g3S0P74n1LoA5O5Qkk w==; X-CSE-ConnectionGUID: O/FL2XjJR5yIgPCinU4gGQ== X-CSE-MsgGUID: aZhmlOzJROi7qu2HBpw02g== X-IronPort-AV: E=McAfee;i="6600,9927,11087"; a="24553050" X-IronPort-AV: E=Sophos;i="6.08,198,1712646000"; d="scan'208";a="24553050" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2024 09:51:32 -0700 X-CSE-ConnectionGUID: jST4o/xKSn+4HzF8w2tRQw== X-CSE-MsgGUID: 6WYra3KORvuiO1dTg7l7Nw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,198,1712646000"; d="scan'208";a="35964438" Received: from ideak-desk.fi.intel.com ([10.237.72.78]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2024 09:51:29 -0700 Date: Wed, 29 May 2024 19:51:34 +0300 From: Imre Deak To: Dave Jiang Cc: "Saarinen, Jani" , Jani Nikula , Nirmal Patel , "Williams, Dan J" , =?utf-8?B?5p2OLCDmmJ/ovok=?= , Jonathan Derrick , Bjorn Helgaas , "linux-pci@vger.kernel.org" , "intel-gfx@lists.freedesktop.org" Subject: Re: Lockdep annotation introduced warn in VMD driver Message-ID: References: <20240528155228.00005850@linux.intel.com> <877cfdkpom.fsf@intel.com> <5fbf60dd-4ad1-43f1-a3e5-451e9481883e@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5fbf60dd-4ad1-43f1-a3e5-451e9481883e@intel.com> X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: imre.deak@intel.com Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, May 29, 2024 at 09:08:33AM -0700, Dave Jiang wrote: > > > On 5/29/24 8:36 AM, Saarinen, Jani wrote: > > Hi, > >> -----Original Message----- > >> From: Saarinen, Jani > >> Sent: Wednesday, 29 May 2024 16.49 > >> To: Jani Nikula ; Nirmal Patel > >> ; Deak, Imre ; Jiang, > >> Dave > >> Cc: 李, 星辉 ; Jonathan Derrick > >> ; Bjorn Helgaas ; linux- > >> pci@vger.kernel.org; intel-gfx@lists.freedesktop.org > >> Subject: RE: Lockdep annotation introduced warn in VMD driver > >> > >> Hi, > >> > >>> -----Original Message----- > >>> From: Intel-gfx On Behalf Of Jani > >>> Nikula > >>> Sent: Wednesday, 29 May 2024 11.06 > >>> To: Nirmal Patel ; Deak, Imre > >>> > >>> Cc: Jiang, Dave ; 李, 星辉 ; > >>> Jonathan Derrick ; Bjorn Helgaas > >>> ; linux-pci@vger.kernel.org; intel- > >>> gfx@lists.freedesktop.org > >>> Subject: Re: Lockdep annotation introduced warn in VMD driver > >>> > >>> On Tue, 28 May 2024, Nirmal Patel wrote: > >>>> On Tue, 28 May 2024 15:36:54 +0300 > >>>> Imre Deak wrote: > >>>> > >>>>> Hi, > >>>>> > >>>>> commit 7e89efc6e9e402839643cb297bab14055c547f07 > >>>>> Author: Dave Jiang > >>>>> Date: Thu May 2 09:57:31 2024 -0700 > >>>>> > >>>>> PCI: Lock upstream bridge for pci_reset_function() > >>>>> > >>>>> introduced the WARN below in the VMD driver, see [1] for the full log. > >>>>> Not sure if the annotation is incorrect or the VMD driver is missing > >>>>> the lock, CC'ing VMD folks. > >>>>> > >>>>> --Imre > >>>> Can you please provide repro steps and some background on the setup? > >>> > >>> Hardware name: Intel Corporation Alder Lake Client Platform/AlderLake-P > >>> LP5 RVP. > >>> > >>> Kconfig: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14842/kconfig.txt > >>> > >>> Just booting with the above commit is enough. > >> It seems fix do not fix as seen on > >> https://patchwork.freedesktop.org/series/134183/ > >> => https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_134183v1/index.html? > >> See those red not where both are red stil and also both dmesg (boot.log) look > >> still identical. > >> So eg: > >> base build: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14846/bat-dg2-13/boot0.txt > >> pw patches: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_134183v1/bat-dg2-13/boot0.txt > >> > >> Dave, thoughts? > > Also Imre tried with 2 PCI patches together https://patchwork.freedesktop.org/series/134193/ > > And still not good for those 4 systems (mtlp-9, bat-dg2-13/14 and bat-adlp-11) : > > https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_134193v1/index.html? > > Dave, Dan, thoughts? > > Can you provide the dmesg from the failure system with the 2 patches applied please? For the above 4 machines, mtlp-9 not having the originally reported WARN (at pci.c:4886) only some other lockdep issue, while the other 3 machines having both the originally reported one and the other lockdep issue: https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_134193v1/bat-mtlp-9/boot0.txt https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_134193v1/bat-dg2-13/boot0.txt https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_134193v1/bat-dg2-14/boot0.txt https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_134193v1/bat-adlp-11/boot0.txt