From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 42/65] drm/i915: pass dev_priv explicitly to _DSPBADDR
Date: Thu, 6 Jun 2024 12:08:00 -0400 [thread overview]
Message-ID: <ZmHe4KXCQKuj3HsR@intel.com> (raw)
In-Reply-To: <d480b52b454cb3bc49f4e20b8bf973f252454e3a.1717514638.git.jani.nikula@intel.com>
On Tue, Jun 04, 2024 at 06:26:00PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the _DSPBADDR register macro.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 8390294aea5b..bcaa7c5b0c40 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -2309,7 +2309,7 @@
> #define _DSPBCNTR(dev_priv) (DISPLAY_MMIO_BASE(dev_priv) + 0x71180)
> #define DISP_ALPHA_TRANS_ENABLE REG_BIT(15)
> #define DISP_SPRITE_ABOVE_OVERLAY REG_BIT(0)
> -#define _DSPBADDR (DISPLAY_MMIO_BASE(dev_priv) + 0x71184)
> +#define _DSPBADDR(dev_priv) (DISPLAY_MMIO_BASE(dev_priv) + 0x71184)
ditto
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> #define _DSPBSTRIDE (DISPLAY_MMIO_BASE(dev_priv) + 0x71188)
> #define _DSPBPOS (DISPLAY_MMIO_BASE(dev_priv) + 0x7118C)
> #define _DSPBSIZE (DISPLAY_MMIO_BASE(dev_priv) + 0x71190)
> --
> 2.39.2
>
next prev parent reply other threads:[~2024-06-06 16:09 UTC|newest]
Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 15:25 [PATCH 00/65] drm/i915: finish the job of removing implicit dev_priv Jani Nikula
2024-06-04 15:25 ` [PATCH 01/65] drm/i915: pass dev_priv explicitly to DPLL Jani Nikula
2024-06-06 14:38 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 02/65] drm/i915: pass dev_priv explicitly to DPLL_MD Jani Nikula
2024-06-06 14:39 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 03/65] drm/i915: pass dev_priv explicitly to TRANS_HTOTAL Jani Nikula
2024-06-06 14:40 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 04/65] drm/i915: pass dev_priv explicitly to TRANS_HBLANK Jani Nikula
2024-06-06 14:40 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 05/65] drm/i915: pass dev_priv explicitly to TRANS_HSYNC Jani Nikula
2024-06-06 14:41 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 06/65] drm/i915: pass dev_priv explicitly to TRANS_VTOTAL Jani Nikula
2024-06-06 15:36 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 07/65] drm/i915: pass dev_priv explicitly to TRANS_VBLANK Jani Nikula
2024-06-06 15:36 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 08/65] drm/i915: pass dev_priv explicitly to TRANS_VSYNC Jani Nikula
2024-06-06 15:37 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 09/65] drm/i915: pass dev_priv explicitly to BCLRPAT Jani Nikula
2024-06-06 15:36 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 10/65] drm/i915: pass dev_priv explicitly to TRANS_VSYNCSHIFT Jani Nikula
2024-06-06 15:38 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 11/65] drm/i915: pass dev_priv explicitly to PIPESRC Jani Nikula
2024-06-06 15:37 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 12/65] drm/i915: pass dev_priv explicitly to TRANS_MULT Jani Nikula
2024-06-06 15:38 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 13/65] drm/i915: pass dev_priv explicitly to PORT_HOTPLUG_EN Jani Nikula
2024-06-06 15:39 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 14/65] drm/i915: pass dev_priv explicitly to PORT_HOTPLUG_STAT Jani Nikula
2024-06-06 15:40 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 15/65] drm/i915: pass dev_priv explicitly to PFIT_CONTROL Jani Nikula
2024-06-06 15:40 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 16/65] drm/i915: pass dev_priv explicitly to PFIT_PGM_RATIOS Jani Nikula
2024-06-06 15:41 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 17/65] drm/i915: pass dev_priv explicitly to PFIT_AUTO_RATIOS Jani Nikula
2024-06-06 15:40 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 18/65] drm/i915: pass dev_priv explicitly to TRANSCONF Jani Nikula
2024-06-06 15:42 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 19/65] drm/i915: pass dev_priv explicitly to PIPEDSL Jani Nikula
2024-06-06 15:42 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 20/65] drm/i915: pass dev_priv explicitly to PIPEFRAME Jani Nikula
2024-06-06 15:43 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 21/65] drm/i915: pass dev_priv explicitly to PIPEFRAMEPIXEL Jani Nikula
2024-06-06 15:43 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 22/65] drm/i915: pass dev_priv explicitly to PIPESTAT Jani Nikula
2024-06-06 15:44 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 23/65] drm/i915: pass dev_priv explicitly to PIPE_ARB_CTL Jani Nikula
2024-06-06 15:44 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 24/65] drm/i915: pass dev_priv explicitly to ICL_PIPESTATUS Jani Nikula
2024-06-06 15:44 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 25/65] drm/i915: pass dev_priv explicitly to DSPARB Jani Nikula
2024-06-06 15:47 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 26/65] drm/i915: pass dev_priv explicitly to DSPFW1 Jani Nikula
2024-06-06 15:48 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 27/65] drm/i915: pass dev_priv explicitly to DSPFW2 Jani Nikula
2024-06-06 15:48 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 28/65] drm/i915: pass dev_priv explicitly to DSPFW3 Jani Nikula
2024-06-06 15:49 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 29/65] drm/i915: pass dev_priv explicitly to PIPE_FRMCOUNT_G4X Jani Nikula
2024-06-06 16:01 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 30/65] drm/i915: pass dev_priv explicitly to PIPE_FLIPCOUNT_G4X Jani Nikula
2024-06-06 16:01 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 31/65] drm/i915: pass dev_priv explicitly to CHV_BLEND Jani Nikula
2024-06-06 16:01 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 32/65] drm/i915: pass dev_priv explicitly to CHV_CANVAS Jani Nikula
2024-06-06 16:02 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 33/65] drm/i915: pass dev_priv explicitly to SWF0 Jani Nikula
2024-06-06 16:03 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 34/65] drm/i915: pass dev_priv explicitly to SWF1 Jani Nikula
2024-06-06 16:03 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 35/65] drm/i915: pass dev_priv explicitly to SWF3 Jani Nikula
2024-06-06 16:03 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 36/65] drm/i915: pass dev_priv explicitly to _PIPEBDSL Jani Nikula
2024-06-06 16:04 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 37/65] drm/i915: pass dev_priv explicitly to _TRANSBCONF Jani Nikula
2024-06-06 16:05 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 38/65] drm/i915: pass dev_priv explicitly to _PIPEBSTAT Jani Nikula
2024-06-06 16:05 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 39/65] drm/i915: pass dev_priv explicitly to _PIPEB_FRMCOUNT_G4X Jani Nikula
2024-06-06 16:05 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 40/65] drm/i915: pass dev_priv explicitly to _PIPEB_FLIPCOUNT_G4X Jani Nikula
2024-06-06 16:07 ` Rodrigo Vivi
2024-06-04 15:25 ` [PATCH 41/65] drm/i915: pass dev_priv explicitly to _DSPBCNTR Jani Nikula
2024-06-06 16:07 ` Rodrigo Vivi
2024-06-04 15:26 ` [PATCH 42/65] drm/i915: pass dev_priv explicitly to _DSPBADDR Jani Nikula
2024-06-06 16:08 ` Rodrigo Vivi [this message]
2024-06-04 15:26 ` [PATCH 43/65] drm/i915: pass dev_priv explicitly to _DSPBSTRIDE Jani Nikula
2024-06-06 16:08 ` Rodrigo Vivi
2024-06-04 15:26 ` [PATCH 44/65] drm/i915: pass dev_priv explicitly to _DSPBPOS Jani Nikula
2024-06-06 16:08 ` Rodrigo Vivi
2024-06-04 15:26 ` [PATCH 45/65] drm/i915: pass dev_priv explicitly to _DSPBSIZE Jani Nikula
2024-06-06 16:09 ` Rodrigo Vivi
2024-06-07 10:46 ` Jani Nikula
2024-06-07 10:48 ` Jani Nikula
2024-06-04 15:26 ` [PATCH 46/65] drm/i915: pass dev_priv explicitly to _DSPBSURF Jani Nikula
2024-06-06 16:10 ` Rodrigo Vivi
2024-06-04 15:26 ` [PATCH 47/65] drm/i915: pass dev_priv explicitly to _DSPBTILEOFF Jani Nikula
2024-06-06 16:10 ` Rodrigo Vivi
2024-06-04 15:26 ` [PATCH 48/65] drm/i915: pass dev_priv explicitly to _DSPBOFFSET Jani Nikula
2024-06-06 16:10 ` Rodrigo Vivi
2024-06-04 15:26 ` [PATCH 49/65] drm/i915: pass dev_priv explicitly to _DSPBSURFLIVE Jani Nikula
2024-06-06 16:10 ` Rodrigo Vivi
2024-06-04 15:26 ` [PATCH 50/65] drm/i915: pass dev_priv explicitly to PIPE_DATA_M1 Jani Nikula
2024-06-06 16:11 ` Rodrigo Vivi
2024-06-04 15:26 ` [PATCH 51/65] drm/i915: pass dev_priv explicitly to PIPE_DATA_N1 Jani Nikula
2024-06-06 16:12 ` Rodrigo Vivi
2024-06-04 15:26 ` [PATCH 52/65] drm/i915: pass dev_priv explicitly to PIPE_DATA_M2 Jani Nikula
2024-06-06 16:12 ` Rodrigo Vivi
2024-06-04 15:26 ` [PATCH 53/65] drm/i915: pass dev_priv explicitly to PIPE_DATA_N2 Jani Nikula
2024-06-06 16:12 ` Rodrigo Vivi
2024-06-04 15:26 ` [PATCH 54/65] drm/i915: pass dev_priv explicitly to PIPE_LINK_M1 Jani Nikula
2024-06-06 16:13 ` Rodrigo Vivi
2024-06-04 15:26 ` [PATCH 55/65] drm/i915: pass dev_priv explicitly to PIPE_LINK_N1 Jani Nikula
2024-06-06 16:13 ` Rodrigo Vivi
2024-06-04 15:26 ` [PATCH 56/65] drm/i915: pass dev_priv explicitly to PIPE_LINK_M2 Jani Nikula
2024-06-06 16:15 ` Rodrigo Vivi
2024-06-04 15:26 ` [PATCH 57/65] drm/i915: pass dev_priv explicitly to PIPE_LINK_N2 Jani Nikula
2024-06-06 16:14 ` Rodrigo Vivi
2024-06-04 15:26 ` [PATCH 58/65] drm/i915: pass dev_priv explicitly to HSW_STEREO_3D_CTL Jani Nikula
2024-06-06 16:17 ` Rodrigo Vivi
2024-06-04 15:26 ` [PATCH 59/65] drm/i915: pass dev_priv explicitly to TRANS_DDI_FUNC_CTL Jani Nikula
2024-06-06 16:13 ` Rodrigo Vivi
2024-06-04 15:26 ` [PATCH 60/65] drm/i915: pass dev_priv explicitly to TRANS_DDI_FUNC_CTL2 Jani Nikula
2024-06-06 16:18 ` Rodrigo Vivi
2024-06-04 15:26 ` [PATCH 61/65] drm/i915: pass dev_priv explicitly to TGL_DP_TP_CTL Jani Nikula
2024-06-06 16:14 ` Rodrigo Vivi
2024-06-04 15:26 ` [PATCH 62/65] drm/i915: pass dev_priv explicitly to TGL_DP_TP_STATUS Jani Nikula
2024-06-06 16:15 ` Rodrigo Vivi
2024-06-04 15:26 ` [PATCH 63/65] drm/i915: pass dev_priv explicitly to TRANS_MSA_MISC Jani Nikula
2024-06-06 16:15 ` Rodrigo Vivi
2024-06-04 15:26 ` [PATCH 64/65] drm/i915: pass dev_priv explicitly to TRANS_SET_CONTEXT_LATENCY Jani Nikula
2024-06-06 16:18 ` Rodrigo Vivi
2024-06-04 15:26 ` [PATCH 65/65] drm/i915: pass dev_priv explicitly to MTL_CLKGATE_DIS_TRANS Jani Nikula
2024-06-06 16:19 ` Rodrigo Vivi
2024-06-04 18:13 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: finish the job of removing implicit dev_priv Patchwork
2024-06-04 18:20 ` ✓ Fi.CI.BAT: success " Patchwork
2024-06-04 22:01 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmHe4KXCQKuj3HsR@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).