From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E974C3DA4A for ; Mon, 5 Aug 2024 09:40:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BA53710E17A; Mon, 5 Aug 2024 09:40:05 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="SiBcP8Ew"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id BF06C10E17A; Mon, 5 Aug 2024 09:40:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1722850804; x=1754386804; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=55v2HyWOHKu34T7HvxaRjNnUQfmhmPEFy3bNO/nw+Fw=; b=SiBcP8EwaBKOBM0Q+M3tyHzl4i5QLE4dqa3aJBTldAcwG6czqFUNo+bz NqbwPVQ9cTlvzVuSSFkfKi2v0ADeevk1q4FsD0hPdxUTQhsHk0qWiZDSc fEhsEGk24oSlis+A60KeQvpSThCtU1FKLdbBlAhFioSOk8G1ZD13E4mrG I4FG31i+hpSNXNk2ZZbvbHa35DJbrYPRIiOfo7NsyoxkjUTt7xMRZqVbC DX+BDlqk/RLrpRYrnNUF/FL+ILvQk2gD582xEBzkZtDdxdPzp4wh4yy0B 6JTRl4fCL95hdnVkSibeNklEov7gxVvG7VuNacHi4NnFc4GsBdDCnc8r1 g==; X-CSE-ConnectionGUID: zl55rFdnQHSapgP0vXLiPA== X-CSE-MsgGUID: jxI12BqlQvqljH0B+64RUQ== X-IronPort-AV: E=McAfee;i="6700,10204,11154"; a="31381243" X-IronPort-AV: E=Sophos;i="6.09,264,1716274800"; d="scan'208";a="31381243" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2024 02:40:04 -0700 X-CSE-ConnectionGUID: Vs6CzNIvSZOo1h+r/w0D3A== X-CSE-MsgGUID: 5F1TckUmTFWHkVmHpSWqjA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,264,1716274800"; d="scan'208";a="79388279" Received: from fpallare-mobl3.ger.corp.intel.com (HELO intel.com) ([10.245.245.249]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2024 02:39:59 -0700 Date: Mon, 5 Aug 2024 11:39:55 +0200 From: Andi Shyti To: "Cavitt, Jonathan" Cc: Andi Shyti , intel-gfx , dri-devel , Jann Horn , Jani Nikula , Joonas Lahtinen , "Vivi, Rodrigo" , Tvrtko Ursulin , Jann Horn , Chris Wilson , "Niemiec, Krzysztof" , Andi Shyti , "Auld, Matthew" Subject: Re: [PATCH 2/2] drm/i915/gem: Fix Virtual Memory mapping boundaries calculation Message-ID: References: <20240802083850.103694-1-andi.shyti@linux.intel.com> <20240802083850.103694-3-andi.shyti@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Jonathan, ... > > + set_address_limits(area, vma, obj_offset, &start, &end); > > + > > + pfn = (ggtt->gmadr.start + i915_ggtt_offset(vma)) >> PAGE_SHIFT; > > + pfn += (start - area->vm_start) >> PAGE_SHIFT; > > + pfn += obj_offset - vma->gtt_view.partial.offset; > > I don't know how viable it would be, but maybe we could > calculate pfn as a part of set_address_limits? I was a bit afraid of dumping a massive parameter list... > Just a suggestion, not blocking ... but now that I'm looking at it more carefully, it would be just two parameters more (&pfn and ggtt->gmadr.start) and would be cleaner. Will send a v2. > Reviewed-by: Jonathan Cavitt > -Jonathan Cavitt Thanks! Andi