From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F452C5321E for ; Wed, 21 Aug 2024 14:53:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 79C9210E684; Wed, 21 Aug 2024 14:53:33 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="B370cQQS"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4208110E666; Wed, 21 Aug 2024 14:53:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724252012; x=1755788012; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3a0SdQK6D0YA6byEu0/lPMYxzVJPB+w3eSkokFrQBjU=; b=B370cQQSvI66q/SCS5e/anAQPG2+lwWqeqC4ZIy++5WAdHODTaF7m3Fz dxIpxxqVIJLwJ3b5dpAoeSOJcE4/eUkztsPGPk6JjI728nEqu1Jn8JzyN 1ut0MXQ4Kq+6eLGA+NeauIETjpn7t8me6Tj1o9iuWKZ6kHa1+EN8ErX/u 3aoNc/caFJzmjrCCV067p4cSpEnzHKj2/h8etBhBtIAspUm9x4zF7HnTt XdkjlxApDJHj7y5b6Zq6OA0gN/ox9oXP5EW1BSBacQWM7XaC+JZt0RCPq 6qVBCjo6kwkCxkgVN/bt1jpvOJnrprFNI3/uDUG8XMmT5uHr4XadkzcVr g==; X-CSE-ConnectionGUID: yerB0aQjRWqr0hJNYqrVOA== X-CSE-MsgGUID: qx0s14oCSsWh29Qr9vLSRg== X-IronPort-AV: E=McAfee;i="6700,10204,11171"; a="22485374" X-IronPort-AV: E=Sophos;i="6.10,164,1719903600"; d="scan'208";a="22485374" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2024 07:53:32 -0700 X-CSE-ConnectionGUID: oUecD+0yQj+/o1QqWqbWdw== X-CSE-MsgGUID: TyIrDd9fTouo2NLbve1AkQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,164,1719903600"; d="scan'208";a="91905505" Received: from bergbenj-mobl1.ger.corp.intel.com (HELO intel.com) ([10.245.246.24]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2024 07:53:25 -0700 Date: Wed, 21 Aug 2024 16:53:21 +0200 From: Andi Shyti To: Raag Jadav Cc: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, airlied@gmail.com, daniel@ffwll.ch, linux@roeck-us.net, andi.shyti@linux.intel.com, andriy.shevchenko@linux.intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, anshuman.gupta@intel.com, badal.nilawar@intel.com, riana.tauro@intel.com, ashutosh.dixit@intel.com, karthik.poosa@intel.com Subject: Re: [PATCH v6] drm/i915/hwmon: expose fan speed Message-ID: References: <20240820062010.2000873-1-raag.jadav@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240820062010.2000873-1-raag.jadav@intel.com> X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Raag, > + /* > + * Calculate fan speed in RPM by time averaging two subsequent > + * readings in minutes. > + * RPM = number of rotations * msecs per minute / time in msecs > + */ > + *val = DIV_ROUND_UP(rotations * (MSEC_PER_SEC * 60), time); once you find the correct operator here, please feel free to add: Reviewed-by: Andi Shyti Normally these get me confused, I'm happy Andy is looking after it :-) Thanks, Andi