From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D9EACE7B1C for ; Fri, 6 Sep 2024 14:46:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0B20810EA77; Fri, 6 Sep 2024 14:46:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="mB4QvpyT"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by gabe.freedesktop.org (Postfix) with ESMTPS id E0AA210EA76 for ; Fri, 6 Sep 2024 14:46:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725633975; x=1757169975; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=eRiUsFB0mHxfIlyAvv8DyiOr7jxOKBJzfqU7IHAVw9Y=; b=mB4QvpyTgGWsInhF/boiZjTKpU1mGWEP/hfIQc9M07HRiNvHei54Uvhf IVCEUAv8ftREQjN+agEEFoZ3T4019KvYLA1NeJIY6hVpjd6ckM73VaUaG VN29oQ3wsVxW1hnwTgutVrlcCyyIFerIwXF6mKAqGgYiAMUIOI8OsR3aw R1CcJLdsMrQMqSVPIC7QBmwB5smIiAm7mOYSxyXXz4vRoPZV0Sty4T9GL r4+t9+mQ7mg3JteXNYlYxqP7PN6uZe2GC/8LXezRZt5B4hxYGp9/Ggyx0 eiaGXdZ5THr6x+ZkLfw3nx1I/ebCWlrdhaJL5ROoK/MbEzXncp170O/k7 g==; X-CSE-ConnectionGUID: q2fDhMboRnC5YdBE0xH6Pw== X-CSE-MsgGUID: MyJNPYEMQP6rX5T7PvXayw== X-IronPort-AV: E=McAfee;i="6700,10204,11187"; a="41904332" X-IronPort-AV: E=Sophos;i="6.10,208,1719903600"; d="scan'208";a="41904332" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2024 07:46:14 -0700 X-CSE-ConnectionGUID: RkxOgUjPQeqBDEHjNKsAng== X-CSE-MsgGUID: /dkT6kbzTa2LwUikaY1puQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,208,1719903600"; d="scan'208";a="66005859" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.74]) by fmviesa008.fm.intel.com with SMTP; 06 Sep 2024 07:46:12 -0700 Received: by stinkbox (sSMTP sendmail emulation); Fri, 06 Sep 2024 17:46:11 +0300 Date: Fri, 6 Sep 2024 17:46:11 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Ankit Nautiyal Cc: intel-gfx@lists.freedesktop.org, jani.saarinen@intel.com Subject: Re: [PATCH 01/14] drm/i915/display: Modify debugfs for joiner to force n pipes Message-ID: References: <20240906125807.3960642-1-ankit.k.nautiyal@intel.com> <20240906125807.3960642-2-ankit.k.nautiyal@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240906125807.3960642-2-ankit.k.nautiyal@intel.com> X-Patchwork-Hint: comment X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Sep 06, 2024 at 06:27:54PM +0530, Ankit Nautiyal wrote: > At the moment, the debugfs for joiner allows only to force enable/disable > pipe joiner for 2 pipes. Modify it to force join 'n' number of pipes, > where n is a valid pipe joiner configuration. > This will help in case of ultra joiner where 4 pipes are joined. > > v2: > -Fix commit message to state that only valid joiner config can be > forced. (Suraj) > -Rename the identifiers to have INTEL_BIG/NONE_JOINER_PIPES. (Suraj) > > Signed-off-by: Ankit Nautiyal > --- > .../drm/i915/display/intel_display_debugfs.c | 71 ++++++++++++++++++- > .../drm/i915/display/intel_display_types.h | 8 ++- > drivers/gpu/drm/i915/display/intel_dp.c | 2 +- > 3 files changed, 77 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c > index 830b9eb60976..0ef573afd8a1 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c > +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c > @@ -1504,6 +1504,73 @@ static int intel_crtc_pipe_show(struct seq_file *m, void *unused) > } > DEFINE_SHOW_ATTRIBUTE(intel_crtc_pipe); > > +static int i915_joiner_show(struct seq_file *m, void *data) > +{ > + struct intel_connector *connector = m->private; > + struct drm_i915_private *i915 = to_i915(connector->base.dev); > + int ret; > + > + ret = drm_modeset_lock_single_interruptible(&i915->drm.mode_config.connection_mutex); > + if (ret) > + return ret; What does that lock do for us? > + > + seq_printf(m, "Force_joined_pipes: %d\n", connector->force_joined_pipes); This should just be thae bare number. Adding other junk in there just complicates matters if anyone has to parse this. > + > + drm_modeset_unlock(&i915->drm.mode_config.connection_mutex); > + > + return ret; > +} > + > +static ssize_t i915_joiner_write(struct file *file, > + const char __user *ubuf, > + size_t len, loff_t *offp) > +{ > + struct seq_file *m = file->private_data; > + struct intel_connector *connector = m->private; > + struct drm_i915_private *i915 = to_i915(connector->base.dev); > + int force_join_pipes = 0; > + int ret; > + > + if (len == 0) > + return 0; > + > + drm_dbg(&i915->drm, > + "Copied %zu bytes from user to force joiner\n", len); Leftover debug junk. > + > + ret = kstrtoint_from_user(ubuf, len, 0, &force_join_pipes); > + if (ret < 0) > + return ret; > + > + drm_dbg(&i915->drm, "Got %d for force joining pipes\n", force_join_pipes); More. > + > + if (force_join_pipes < INTEL_NONE_JOINER_PIPES || > + force_join_pipes >= INTEL_INVALID_JOINER_PIPES) { > + drm_dbg(&i915->drm, "Ignoring Invalid num of pipes %d for force joining\n", > + force_join_pipes); > + connector->force_joined_pipes = INTEL_NONE_JOINER_PIPES; > + } else { > + connector->force_joined_pipes = force_join_pipes; > + } I think just something like switch (num_pipes) { case 0: /* or should 1 be the default? */ case 2: case 4: break; default: bad; } should do for validation. > + > + *offp += len; I don't suppose there's any kind of helper for creating a debugfs file with a standard type, with some kind of caller specified validation function? Would avoid having to hand roll all this read syscall cruft for what is a fairly common usecase... > + > + return len; > +} > + > +static int i915_joiner_open(struct inode *inode, struct file *file) > +{ > + return single_open(file, i915_joiner_show, inode->i_private); > +} > + > +static const struct file_operations i915_joiner_fops = { > + .owner = THIS_MODULE, > + .open = i915_joiner_open, > + .read = seq_read, > + .llseek = seq_lseek, > + .release = single_release, > + .write = i915_joiner_write > +}; > + > /** > * intel_connector_debugfs_add - add i915 specific connector debugfs files > * @connector: pointer to a registered intel_connector > @@ -1553,8 +1620,8 @@ void intel_connector_debugfs_add(struct intel_connector *connector) > if (DISPLAY_VER(i915) >= 11 && > (connector_type == DRM_MODE_CONNECTOR_DisplayPort || > connector_type == DRM_MODE_CONNECTOR_eDP)) { > - debugfs_create_bool("i915_bigjoiner_force_enable", 0644, root, > - &connector->force_bigjoiner_enable); > + debugfs_create_file("i915_joiner_force_enable", 0644, root, > + connector, &i915_joiner_fops); > } > > if (connector_type == DRM_MODE_CONNECTOR_DSI || > diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h > index 733de5edcfdb..c213fb61ceb7 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_types.h > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h > @@ -486,6 +486,12 @@ struct intel_hdcp { > enum transcoder stream_transcoder; > }; > > +enum intel_joiner_pipe_count { > + INTEL_NONE_JOINER_PIPES = 0, > + INTEL_BIG_JOINER_PIPES = 2, > + INTEL_INVALID_JOINER_PIPES, > +}; That just looks like obfuscation to me. Just a bare number should do. > + > struct intel_connector { > struct drm_connector base; > /* > @@ -524,7 +530,7 @@ struct intel_connector { > > struct intel_dp *mst_port; > > - bool force_bigjoiner_enable; > + enum intel_joiner_pipe_count force_joined_pipes; > > struct { > struct drm_dp_aux *dsc_decompression_aux; > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index a1fcedfd404b..862a460c32b7 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -1271,7 +1271,7 @@ bool intel_dp_need_joiner(struct intel_dp *intel_dp, > return false; > > return clock > i915->display.cdclk.max_dotclk_freq || hdisplay > 5120 || > - connector->force_bigjoiner_enable; > + connector->force_joined_pipes == INTEL_BIG_JOINER_PIPES; > } > > bool intel_dp_has_dsc(const struct intel_connector *connector) > -- > 2.45.2 -- Ville Syrjälä Intel