Re: [PATCH 00/31] Reconcile i915's and xe's display power mgt sequences

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Wed, Sep 25, 2024 at 01:32:03PM +0300, Jani Nikula wrote:
> On Tue, 24 Sep 2024, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> > Reconcile i915's and xe's display power management sequences.
> >
> > The main goal of this series is to ensure that the display
> > power management sequences from both drivers are fully aligned.
> > So, it needs to live under i915/display/ and xe_display_pm
> > can only be a wrapper to check for the xe's module
> > parameter before jumping in the i915/display functions.
> >
> > During this process, it was clear that the Xe's runtime pm
> > sequences for integrated gfx (non d3cold capable) was totally
> > misaligned with i915 and prune to more bugs. So, this series ends
> > up fixing this and bringing a full alignment there as well.
> >
> > The one new thing under i915 is the d3cold sequences. Apparently
> > that can be reduced, but for now this is what is validated and
> > stable on both DG2 and BMG. So, let's move that to the
> > i915/display side as well and continue on the improvements with
> > the code in the right place.
> >
> > When I started this work I was hoping that I could run more
> > conversions to intel_display struct before moving things from
> > i915_driver.c to intel_display_driver, however that was a deeper
> > task and this series is already deep enough.
> 
> Holy crap this is scary and a PITA to review but exactly what we'll
> need! Thanks for doing this. I've been shying away from this too long.

yeap! It was very painful to do this... took me much longer then
I was expecting for a refactor :/

But we need to rip the bandaid off

> 
> I'll try to put in some review effort, but at the same time just more
> eyeballs than mine would be great.

Thank you so much!
Yeap, every help is very much appreciated!

> 
> BR,
> Jani.
> 
> 
> -- 
> Jani Nikula, Intel