Re: [PATCH v2 0/9] drm/i915/display: platform identification with display->is.<PLATFORM>

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Fri, Sep 27, 2024 at 06:01:58PM +0300, Jani Nikula wrote:
> On Fri, 27 Sep 2024, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> > On Fri, Sep 27, 2024 at 03:16:23PM +0300, Jani Nikula wrote:
> >> For example, RPL-S:
> >> 
> >> 
> >> 	if (display->platform.alderlake_s_raptorlake_s)
> >> 
> >> But the main platform also matches its subplatforms:
> >> 
> >> 	if (display->platform.alderlake_s)
> >> 
> >> This is the same as with the patches at hand. Except for the
> >> uppercase/lowercase difference, and s/is/platform/.
> >
> > Yeap, let's go with that then!
> 
> Double-checking: do you want both s/is/platform *and* lowercase?
> 
> 	if (display->platform.alderlake_s_raptorlake_s)
> 
> Mulling over this I've ended up preferring lowercase. (Maybe need to do
> something to pretty print them to logs.)

I believe that I like the lowercase more too.
We could have a map for the debug prints, but I would delay this, because
that could end up in discussions with marketing brand strings... :/

> 
> And just the platform without "is_" prefix, i.e. *not*:
> 
> 	if (display->platform.is_alderlake_s_raptorlake_s)

I like the version without 'is' better...

> 
> 
> BR,
> Jani.
> 
> 
> -- 
> Jani Nikula, Intel