From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53FC5CEACEA for ; Tue, 1 Oct 2024 16:42:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7F17010E320; Tue, 1 Oct 2024 16:42:43 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="dkOynrz3"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5506010E04B; Tue, 1 Oct 2024 16:42:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727800962; x=1759336962; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=paQKL6UI6h74ZN7KdQjFmjlZlyEYpXcIsSqvXjbOeG0=; b=dkOynrz3TTklymZXO5EG02tDVSDwPBzkQ23+na9EiOy0nU6B5c0Ch2/2 HhWU/pWdAhliMV5aPVa7/3FdhjVJpsPqQNwUweLpyOGfcqjnitOdAvxju ZX5FPtuswxYxvMXAYo9D2IbvKYhMJ1F5/giWL541obTc5dZ0dHN7eGOh+ c/nRPe5AiBzj0k/f9jaMOZJ4mRICnW90lovu0Yiya35kV5xO6Wu6wrHqj sl9OWNinOoKXCYOAi6MRq4DU74vLHSb3rs4hnB3aIE68L9qVihulNBzjY G89+FiI4wXzhja98KRoX3vhZBHoUpBzH2YUInQAkSSV6BWeDVFBc3ZqG9 A==; X-CSE-ConnectionGUID: z7/Jwq+vRKGhR344m++a+w== X-CSE-MsgGUID: OYTHUd4PRsyZpf7zBRKX7w== X-IronPort-AV: E=McAfee;i="6700,10204,11212"; a="30655162" X-IronPort-AV: E=Sophos;i="6.11,169,1725346800"; d="scan'208";a="30655162" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2024 09:42:41 -0700 X-CSE-ConnectionGUID: ZyNCIIQ5S6SaED+ijazQ1g== X-CSE-MsgGUID: dgIMfPoFSCanX4JSKq2e7g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,169,1725346800"; d="scan'208";a="78472801" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2024 09:42:36 -0700 Date: Tue, 1 Oct 2024 19:42:33 +0300 From: Raag Jadav To: Andy Shevchenko Cc: airlied@gmail.com, simona@ffwll.ch, lucas.demarchi@intel.com, thomas.hellstrom@linux.intel.com, rodrigo.vivi@intel.com, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, tursulin@ursulin.net, lina@asahilina.net, intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, himal.prasad.ghimiray@intel.com, francois.dugast@intel.com, aravind.iddamsetty@linux.intel.com, anshuman.gupta@intel.com, andi.shyti@linux.intel.com, matthew.d.roper@intel.com Subject: Re: [PATCH v7 1/5] drm: Introduce device wedged event Message-ID: References: <20240930073845.347326-1-raag.jadav@intel.com> <20240930073845.347326-2-raag.jadav@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Oct 01, 2024 at 05:54:46PM +0300, Andy Shevchenko wrote: > On Tue, Oct 01, 2024 at 05:18:33PM +0300, Raag Jadav wrote: > > On Tue, Oct 01, 2024 at 03:07:59PM +0300, Andy Shevchenko wrote: > > > On Tue, Oct 01, 2024 at 08:08:18AM +0300, Raag Jadav wrote: > > > > On Mon, Sep 30, 2024 at 03:59:59PM +0300, Andy Shevchenko wrote: > > > > > On Mon, Sep 30, 2024 at 01:08:41PM +0530, Raag Jadav wrote: > > ... > > > > > > > +static const char *const drm_wedge_recovery_opts[] = { > > > > > > + [DRM_WEDGE_RECOVERY_REBIND] = "rebind", > > > > > > + [DRM_WEDGE_RECOVERY_BUS_RESET] = "bus-reset", > > > > > > + [DRM_WEDGE_RECOVERY_REBOOT] = "reboot", > > > > > > +}; > > > > > > > > > > Place for static_assert() is here, as it closer to the actual data we test... > > > > > > > > Shouldn't it be at the point of access? > > > > > > No, the idea of static_assert() is in word 'static', meaning it's allowed to be > > > used in the global space. > > > > > > > If no, why do we care about the data when it's not being used? > > > > > > What does this suppose to mean? The assertion is for enforcing the boundaries > > > that are defined by different means (constant of the size and real size of > > > an array). > > > > The point was to simply not assert without an active user of the array, which is > > not the case now but may be possible with growing functionality in the future. > > static_assert() is a compile-time check. How is it even related to this? Yes, I understand. Semantically it made more sense to me is all, since core helpers can always end up in config based ifdeffery. Anyway, I'll update. Raag