From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24F94E67487 for ; Thu, 31 Oct 2024 21:08:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 348BA10E936; Thu, 31 Oct 2024 21:08:10 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="RxfCkLDH"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id C57EA10E932; Thu, 31 Oct 2024 21:08:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730408889; x=1761944889; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=MskkAwGzR4Xb9GOIMxqvO2yFYtiuGRuTFN0lPBXNzjQ=; b=RxfCkLDHZHB5yokpKGqPO5qCQ3Hfnz2BDd04Ftvm9URetmDpJ1MNwtQk nQWDzqCmM7omD0Ht7usW9gjxj5REnPibaLVK51zk2Ms2UbMhHWfI5CGQ1 1KVhjSFIlra//LsnFqb4ki/IB1CmtvxvQFAgxaT67x4lDtIlm/SibuVP8 RA8w/4jzEYXNCIT3MfjTGk8V6qZ0VpGtB3j525xIxhrBkIBjYwFombhTX 5q1goYR4eK4hBbTfQIy1vr9aEst0ibkMF6ZXF/jVIL95kP852CXYPr5ho 6IjjX0H7h0dETZBsKo5CulcDkszPpTnSO4zajpjks5lhY1uHLXMXDm1uL w==; X-CSE-ConnectionGUID: kSFhNoZiQ0epDa8RrfdNEg== X-CSE-MsgGUID: E8t2l09gStG5GvCMIajCrA== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="30359914" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="30359914" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2024 14:08:09 -0700 X-CSE-ConnectionGUID: mIgV1Pw3Rkm58OhClUvVgQ== X-CSE-MsgGUID: YB04KzZ8SNaqJlGvMCXuNw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,247,1725346800"; d="scan'208";a="82880364" Received: from ideak-desk.fi.intel.com ([10.237.72.78]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2024 14:08:02 -0700 Date: Thu, 31 Oct 2024 23:08:35 +0200 From: Imre Deak To: Abel Vesa Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Karol Herbst , Lyude Paul , Danilo Krummrich , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , Bjorn Andersson , Konrad Dybcio , Johan Hovold , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH RFC 3/4] drm/i915/dp: Use the generic helper to control LTTPR transparent mode Message-ID: References: <20241031-drm-dp-msm-add-lttpr-transparent-mode-set-v1-0-cafbb9855f40@linaro.org> <20241031-drm-dp-msm-add-lttpr-transparent-mode-set-v1-3-cafbb9855f40@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241031-drm-dp-msm-add-lttpr-transparent-mode-set-v1-3-cafbb9855f40@linaro.org> X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: imre.deak@intel.com Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Oct 31, 2024 at 05:12:47PM +0200, Abel Vesa wrote: > LTTPRs operating modes are defined by the DisplayPort standard and the > generic framework now provides a helper to switch between them. > So use the drm generic helper instead as it makes the code a bit cleaner. > > Signed-off-by: Abel Vesa Acked-by: Imre Deak > --- > drivers/gpu/drm/i915/display/intel_dp_link_training.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > index 397cc4ebae526a416fcda9c74f57a8f9f803ce3b..0038608d29219ff1423a649089a38980e95b87e4 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > @@ -118,7 +118,7 @@ intel_dp_set_lttpr_transparent_mode(struct intel_dp *intel_dp, bool enable) > u8 val = enable ? DP_PHY_REPEATER_MODE_TRANSPARENT : > DP_PHY_REPEATER_MODE_NON_TRANSPARENT; > > - if (drm_dp_dpcd_write(&intel_dp->aux, DP_PHY_REPEATER_MODE, &val, 1) != 1) > + if (drm_dp_lttpr_set_transparent_mode(&intel_dp->aux, enable) != 1) > return false; > > intel_dp->lttpr_common_caps[DP_PHY_REPEATER_MODE - > > -- > 2.34.1 >