From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16E61E67480 for ; Thu, 31 Oct 2024 21:05:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8DAA310E931; Thu, 31 Oct 2024 21:05:26 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="g5tUIXLj"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1149810E429; Thu, 31 Oct 2024 21:05:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730408725; x=1761944725; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=OO4A1ZXhvnE/2XJOeAiNO8KhYr/w+ARRaSfPUdDCdws=; b=g5tUIXLjKMlEKJKrUIEI56m30caJy7Cw/dUSZw9XSPcBToimKXVQqPFg wbz0CGxjbDQqY/aLLdQj8hSrW8hf5JF0acIze4IXzrfh/PYfNS0S7MfHL 92Tnu12yNVpfS5MoUKkNJqFVZsKehPCBVedQECznsUKP2vI9fytv7VQYv 8d8xlKCM62zNngt/pesnUkfOTw2F8lzZ+4Y5rvxUbqtuvm0n5SHPHEjwx c7uFcytmVQkW+7eN0uRu9R+3ZISjLtK5HOtY9zKY5AJmICzI1b2buZGm6 HvugE8bDKrOB5KGzNJ73tTq9xW+HbTEUS8Cl9ueA74WZruVZQcrju5+Hg A==; X-CSE-ConnectionGUID: gWq/lWfORq+xU/lB18t9cA== X-CSE-MsgGUID: gw1eD6dbRFSWWhR5ElH9TQ== X-IronPort-AV: E=McAfee;i="6700,10204,11242"; a="55575490" X-IronPort-AV: E=Sophos;i="6.11,247,1725346800"; d="scan'208";a="55575490" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2024 14:05:25 -0700 X-CSE-ConnectionGUID: 5foGy5bPQLqQElX3moR8kA== X-CSE-MsgGUID: EkRWfefLSq27SEFwoMicWA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,247,1725346800"; d="scan'208";a="83566317" Received: from ideak-desk.fi.intel.com ([10.237.72.78]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2024 14:05:18 -0700 Date: Thu, 31 Oct 2024 23:05:50 +0200 From: Imre Deak To: Abel Vesa Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Karol Herbst , Lyude Paul , Danilo Krummrich , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , Bjorn Andersson , Konrad Dybcio , Johan Hovold , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH RFC 1/4] drm/dp: Add helper to set LTTPRs in transparent mode Message-ID: References: <20241031-drm-dp-msm-add-lttpr-transparent-mode-set-v1-0-cafbb9855f40@linaro.org> <20241031-drm-dp-msm-add-lttpr-transparent-mode-set-v1-1-cafbb9855f40@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241031-drm-dp-msm-add-lttpr-transparent-mode-set-v1-1-cafbb9855f40@linaro.org> X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: imre.deak@intel.com Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Oct 31, 2024 at 05:12:45PM +0200, Abel Vesa wrote: > According to the DisplayPort standard, LTTPRs have two operating > modes: > - non-transparent - it replies to DPCD LTTPR field specific AUX > requests, while passes through all other AUX requests > - transparent - it passes through all AUX requests. > > Switching between this two modes is done by the DPTX by issuing > an AUX write to the DPCD PHY_REPEATER_MODE register. > > Add a generic helper that allows switching between these modes. > > Signed-off-by: Abel Vesa > --- > drivers/gpu/drm/display/drm_dp_helper.c | 17 +++++++++++++++++ > include/drm/display/drm_dp_helper.h | 1 + > 2 files changed, 18 insertions(+) > > diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c > index 6ee51003de3ce616c3a52653c2f1979ad7658e21..38d612345986ad54b42228902ea718a089d169c4 100644 > --- a/drivers/gpu/drm/display/drm_dp_helper.c > +++ b/drivers/gpu/drm/display/drm_dp_helper.c > @@ -2694,6 +2694,23 @@ int drm_dp_lttpr_max_link_rate(const u8 caps[DP_LTTPR_COMMON_CAP_SIZE]) > } > EXPORT_SYMBOL(drm_dp_lttpr_max_link_rate); > > +/** > + * drm_dp_lttpr_set_transparent_mode - set the LTTPR in transparent mode > + * @aux: DisplayPort AUX channel > + * @enable: Enable or disable transparent mode > + * > + * Returns 0 on success or a negative error code on failure. Should be "Returns 1 on success". > + */ > + > +int drm_dp_lttpr_set_transparent_mode(struct drm_dp_aux *aux, bool enable) > +{ > + u8 val = enable ? DP_PHY_REPEATER_MODE_TRANSPARENT : > + DP_PHY_REPEATER_MODE_NON_TRANSPARENT; > + > + return drm_dp_dpcd_writeb(aux, DP_PHY_REPEATER_MODE, val); > +} > +EXPORT_SYMBOL(drm_dp_lttpr_set_transparent_mode); > + > /** > * drm_dp_lttpr_max_lane_count - get the maximum lane count supported by all LTTPRs > * @caps: LTTPR common capabilities > diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h > index 279624833ea9259809428162f4e845654359f8c9..8821ab2d36b0e04d38ccbdddcb703b34de7ed680 100644 > --- a/include/drm/display/drm_dp_helper.h > +++ b/include/drm/display/drm_dp_helper.h > @@ -625,6 +625,7 @@ int drm_dp_read_lttpr_phy_caps(struct drm_dp_aux *aux, > u8 caps[DP_LTTPR_PHY_CAP_SIZE]); > int drm_dp_lttpr_count(const u8 cap[DP_LTTPR_COMMON_CAP_SIZE]); > int drm_dp_lttpr_max_link_rate(const u8 caps[DP_LTTPR_COMMON_CAP_SIZE]); > +int drm_dp_lttpr_set_transparent_mode(struct drm_dp_aux *aux, bool enable); > int drm_dp_lttpr_max_lane_count(const u8 caps[DP_LTTPR_COMMON_CAP_SIZE]); > bool drm_dp_lttpr_voltage_swing_level_3_supported(const u8 caps[DP_LTTPR_PHY_CAP_SIZE]); > bool drm_dp_lttpr_pre_emphasis_level_3_supported(const u8 caps[DP_LTTPR_PHY_CAP_SIZE]); > > -- > 2.34.1 >