From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH 2/3] drm/i915: Protect dev_priv->atomic_cdclk_freq with all the crtc locks Date: Fri, 18 Nov 2016 11:26:18 +0100 Message-ID: References: <1479141311-11904-1-git-send-email-ville.syrjala@linux.intel.com> <1479141311-11904-3-git-send-email-ville.syrjala@linux.intel.com> <20161115134127.GJ31595@intel.com> <9a7aed68-2228-c0f1-2661-ae81daa6155f@linux.intel.com> <20161117150651.GX31595@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 467D36E93A for ; Fri, 18 Nov 2016 10:26:20 +0000 (UTC) In-Reply-To: <20161117150651.GX31595@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMTctMTEtMTYgb20gMTY6MDYgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6Cj4gT24gVHVlLCBO b3YgMTUsIDIwMTYgYXQgMDI6NTM6MDBQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6 Cj4+IE9wIDE1LTExLTE2IG9tIDE0OjQxIHNjaHJlZWYgVmlsbGUgU3lyasOkbMOkOgo+Pj4gT24g VHVlLCBOb3YgMTUsIDIwMTYgYXQgMTE6MTQ6MjlBTSArMDEwMCwgTWFhcnRlbiBMYW5raG9yc3Qg d3JvdGU6Cj4+Pj4gT3AgMTQtMTEtMTYgb20gMTc6MzUgc2NocmVlZiB2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbToKPj4+Pj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxh QGxpbnV4LmludGVsLmNvbT4KPj4+Pj4KPj4+Pj4gQSBtb2Rlc2V0IG9uIG9uZSBwaXBlIGNhbiB1 cGRhdGUgZGV2X3ByaXYtPmF0b21pY19jZGNsa19mcmVxIHdpdGhvdXQKPj4+Pj4gYWN0dWFsbHkg dG91Y2hpbmcgdGhlIGhhcmR3YXJlLCBpbiB3aGljaCBjYXNlIHdlIHdvbid0IGZvcmNlIGEgbW9k ZXNldAo+Pj4+PiBvbiBhbGwgdGhlIHBpcGVzLCBhbmQgdGh1cyB3b24ndCBsb2NrIGFueSBvZiB0 aGUgb3RoZXIgcGlwZXMgZWl0aGVyLgo+Pj4+PiBUaGF0IG1lYW5zIGEgcGFyYWxsZWwgcGxhbmUg dXBkYXRlIG9uIGFub3RoZXIgcGlwZSBjb3VsZCBiZSBsb29raW5nIGF0Cj4+Pj4+IGEgc3RhbGUg ZGV2X3ByaXYtPmF0b21pY19jZGNkbGtfZnJlcSBhbmQgdGh1cyBmYWlsIHRvIG5vdGljZSB3aGVu IHRoZQo+Pj4+PiBwbGFuZSBjb25maWd1cmF0aW9uIGlzIGludmFsaWQsIG9yIHBvdGVudGlhbGx5 IHJlamVjdCBhIHZhbGlkIHVwZGF0ZS4KPj4+Pj4KPj4+Pj4gVG8gb3ZlcmNvbWUgdGhpcyB3ZSBt dXN0IHByb3RlY3Qgd3JpdGVzIHRvIGF0b21pY19jZGNsa19mcmVxIHdpdGgKPj4+Pj4gYWxsIHRo ZSBjcnRjIGxvY2tzLCBhbmQgdGh1cyBmb3IgcmVhZHMgYW55IHNpbmdsZSBjcnRjIGxvY2sgd2ls bAo+Pj4+PiBiZSBzdWZmaWNpZW50IHByb3RlY3Rpb24uCj4+Pj4+Cj4+Pj4+IENjOiBNYWFydGVu IExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+Pj4+PiBTaWdu ZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29t Pgo+Pj4+PiAtLS0KPj4+Pj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICAgICB8 ICA5ICsrKysrKystCj4+Pj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMg fCA0MSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0KPj4+Pj4gIDIgZmlsZXMg Y2hhbmdlZCwgNDQgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPj4+Pj4KPj4+Pj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2Rydi5oCj4+Pj4+IGluZGV4IGMwZjFkZmM3MTE5ZS4uNjZkMjk1MGRjNjU3 IDEwMDY0NAo+Pj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+Pj4+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPj4+Pj4gQEAgLTE4NzQsNyAr MTg3NCwxNCBAQCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSB7Cj4+Pj4+ICAKPj4+Pj4gIAl1bnNp Z25lZCBpbnQgZnNiX2ZyZXEsIG1lbV9mcmVxLCBpc19kZHIzOwo+Pj4+PiAgCXVuc2lnbmVkIGlu dCBza2xfcHJlZmVycmVkX3Zjb19mcmVxOwo+Pj4+PiAtCXVuc2lnbmVkIGludCBjZGNsa19mcmVx LCBtYXhfY2RjbGtfZnJlcSwgYXRvbWljX2NkY2xrX2ZyZXE7Cj4+Pj4+ICsJdW5zaWduZWQgaW50 IGNkY2xrX2ZyZXEsIG1heF9jZGNsa19mcmVxOwo+Pj4+PiArCj4+Pj4+ICsJLyoKPj4+Pj4gKwkg KiBGb3IgcmVhZGluZyBob2xkaW5nIGFueSBjcnRjIGxvY2sgaXMgc3VmZmljaWVudCwKPj4+Pj4g KwkgKiBmb3Igd3JpdGluZyBtdXN0IGhvbGQgYWxsIG9mIHRoZW0uCj4+Pj4+ICsJICovCj4+Pj4+ ICsJdW5zaWduZWQgaW50IGF0b21pY19jZGNsa19mcmVxOwo+Pj4+PiArCj4+Pj4+ICAJdW5zaWdu ZWQgaW50IG1heF9kb3RjbGtfZnJlcTsKPj4+Pj4gIAl1bnNpZ25lZCBpbnQgcmF3Y2xrX2ZyZXE7 Cj4+Pj4+ICAJdW5zaWduZWQgaW50IGhwbGxfZnJlcTsKPj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYwo+Pj4+PiBpbmRleCA3MGYzZjBiNzAyNjMuLmQ3YTRiYzYzYjA1YiAxMDA2 NDQKPj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+Pj4+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+Pj4+PiBAQCAtMTM5 NDYsMTMgKzEzOTQ2LDMyIEBAIHN0YXRpYyBpbnQgaGFzd2VsbF9tb2RlX3NldF9wbGFuZXNfd29y a2Fyb3VuZChzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4+Pj4+ICAJcmV0dXJuIDA7 Cj4+Pj4+ICB9Cj4+Pj4+ICAKPj4+Pj4gK3N0YXRpYyBpbnQgaW50ZWxfbG9ja19hbGxfcGlwZXMo c3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+Pj4+PiArewo+Pj4+PiArCXN0cnVjdCBk cm1fY3J0YyAqY3J0YzsKPj4+Pj4gKwo+Pj4+PiArCS8qIEFkZCBhbGwgcGlwZXMgdG8gdGhlIHN0 YXRlICovCj4+Pj4+ICsJZm9yX2VhY2hfY3J0YyhzdGF0ZS0+ZGV2LCBjcnRjKSB7Cj4+Pj4+ICsJ CXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPj4+Pj4gKwo+Pj4+PiArCQljcnRj X3N0YXRlID0gZHJtX2F0b21pY19nZXRfY3J0Y19zdGF0ZShzdGF0ZSwgY3J0Yyk7Cj4+Pj4+ICsJ CWlmIChJU19FUlIoY3J0Y19zdGF0ZSkpCj4+Pj4+ICsJCQlyZXR1cm4gUFRSX0VSUihjcnRjX3N0 YXRlKTsKPj4+Pj4gKwl9Cj4+Pj4+ICsKPj4+Pj4gKwlyZXR1cm4gMDsKPj4+Pj4gK30KPj4+Pj4g Kwo+Pj4+PiAgc3RhdGljIGludCBpbnRlbF9tb2Rlc2V0X2FsbF9waXBlcyhzdHJ1Y3QgZHJtX2F0 b21pY19zdGF0ZSAqc3RhdGUpCj4+Pj4+ICB7Cj4+Pj4+ICAJc3RydWN0IGRybV9jcnRjICpjcnRj Owo+Pj4+PiAgCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPj4+Pj4gIAlpbnQg cmV0ID0gMDsKPj4+Pj4gIAo+Pj4+PiAtCS8qIGFkZCBhbGwgYWN0aXZlIHBpcGVzIHRvIHRoZSBz dGF0ZSAqLwo+Pj4+PiArCS8qCj4+Pj4+ICsJICogQWRkIGFsbCBwaXBlcyB0byB0aGUgc3RhdGUs IGFuZCBmb3JjZQo+Pj4+PiArCSAqIGEgbW9kZXNldCBvbiBhbGwgdGhlIGFjdGl2ZSBvbmVzLgo+ Pj4+PiArCSAqLwo+Pj4+PiAgCWZvcl9lYWNoX2NydGMoc3RhdGUtPmRldiwgY3J0Yykgewo+Pj4+ PiAgCQljcnRjX3N0YXRlID0gZHJtX2F0b21pY19nZXRfY3J0Y19zdGF0ZShzdGF0ZSwgY3J0Yyk7 Cj4+Pj4+ICAJCWlmIChJU19FUlIoY3J0Y19zdGF0ZSkpCj4+Pj4+IEBAIC0xNDAxOCwxMiArMTQw MzcsMjQgQEAgc3RhdGljIGludCBpbnRlbF9tb2Rlc2V0X2NoZWNrcyhzdHJ1Y3QgZHJtX2F0b21p Y19zdGF0ZSAqc3RhdGUpCj4+Pj4+ICAJCWlmIChyZXQgPCAwKQo+Pj4+PiAgCQkJcmV0dXJuIHJl dDsKPj4+Pj4gIAo+Pj4+PiArCQkvKgo+Pj4+PiArCQkgKiBXcml0ZXMgdG8gZGV2X3ByaXYtPmF0 b21pY19jZGNsa19mcmVxIG11c3QgcHJvdGVjdGVkIGJ5Cj4+Pj4+ICsJCSAqIGhvbGRpbmcgYWxs IHRoZSBjcnRjIGxvY2tzLCBldmVuIGlmIHdlIGRvbid0IGVuZCB1cAo+Pj4+PiArCQkgKiB0b3Vj aGluZyB0aGUgaGFyZHdhcmUKPj4+Pj4gKwkJICovCj4+Pj4+ICsJCWlmIChpbnRlbF9zdGF0ZS0+ Y2RjbGsgIT0gZGV2X3ByaXYtPmF0b21pY19jZGNsa19mcmVxKSB7Cj4+Pj4+ICsJCQlyZXQgPSBp bnRlbF9sb2NrX2FsbF9waXBlcyhzdGF0ZSk7Cj4+Pj4+ICsJCQlpZiAocmV0IDwgMCkKPj4+Pj4g KwkJCQlyZXR1cm4gcmV0Owo+Pj4+PiArCQl9Cj4+Pj4+ICsKPj4+PiBXb3VsZCBpdCBiZSB0ZXJy aWJsZSB0byBqdXN0IHVzZSBpbnRlbF9tb2Rlc2V0X2FsbF9waXBlcyBoZXJlPyBTaW5jZSB0aGlz IGNhbiBvbmx5IGJlIGRpZmZlcmVudCBpbiB0aGUgYWxsIGNydGMncyBkaXNhYmxlZCBjYXNlCj4+ Pj4gaXQgd29uJ3QgbWF0dGVyIG11Y2guCj4+PiBJcyB0aGVyZSBhbnkgYmVuZWZpdCBpbiBkb2lu ZyB0aGF0PyBBIGJpdCBjb25mdXNpbmcgSU1PIHRvIGZvcmNlIGEKPj4+IG1vZGVzZXQgd2hlbiB5 b3UgZG9uJ3QgaGF2ZSB0by4KPj4+Cj4+IFRoZSBjYXNlIHdoZXJlIGF0b21pYyBjZGNsayBjaGFu Z2VzLCBidXQgZGV2X2NkY2xrIHN0YXlzIHRoZSBzYW1lIGNhbiBvbmx5IGhhcHBlbgo+PiBpZiB5 b3UgY29uZmlndXJlIGEgY3J0YywgYnV0IGFsbCBjcnRjJ3Mgc3RheSAhYWN0aXZlLiBJbiBhbGwg b3RoZXIgY2FzZXMgZGV2X2NkY2xrCj4+IHdpbGwgY2hhbmdlIHRvby4KPj4KPj4gaW50ZWxfbW9k ZXNldF9hbGxfcGlwZXMgd2lsbCBvbmx5IHNldCBtb2RlX2NoYW5nZWQgb24gYWN0aXZlIGNydGMn cywgYnV0IGl0IHdpbGwKPj4gYWRkIGFsbCBjcnRjJ3MgdG8gdGhlIGF0b21pYyBzdGF0ZSByZWdh cmRsZXNzIHRvIG1ha2Ugc3VyZSB0aGUgY2RjbGsgc3RheXMgY29uc2lzdGVudC4KPiBJIHN0aWxs IGRvbid0IHNlZSB3aGF0IHRoZSBiZW5lZml0IGlzLiBJTU8gaXQncyBqdXN0IGNvbmZ1c2luZyB0 byBzYXkKPiB0aGF0IHdlJ3JlIGdvaW5nIHRvIGZvcmNlIGEgbW9kZXNldCBvbiBhIGRpc2FibGVk IHBpcGUuCj4KaWYgKCFhY3RpdmUgfHwgbmVlZHNfbW9kZXNldChjcnRjX3N0YXRlKSkgY29udGlu dWU7IGNydGNfc3RhdGUtPm1vZGVfY2hhbmdlZD0gdHJ1ZTsgSXQncyBub3QgZG9pbmcgYSBtb2Rl c2V0IG9uIGEgZGlzYWJsZWQgcGlwZSwgaXQgb25seSBtYWtlcyBzdXJlIGl0J3MgcGFydCBvZiB0 aGUgc3RhdGUuCgp+TWFhcnRlbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==