From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30A4FC433EF for ; Thu, 30 Sep 2021 02:16:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7EF4610E6 for ; Thu, 30 Sep 2021 02:16:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B7EF4610E6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 24E2A6EB23; Thu, 30 Sep 2021 02:16:17 +0000 (UTC) X-Greylist: delayed 440 seconds by postgrey-1.36 at gabe; Thu, 30 Sep 2021 02:16:15 UTC Received: from smtprelay.hostedemail.com (smtprelay0219.hostedemail.com [216.40.44.219]) by gabe.freedesktop.org (Postfix) with ESMTPS id CBB246EB22; Thu, 30 Sep 2021 02:16:15 +0000 (UTC) Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave04.hostedemail.com (Postfix) with ESMTP id DFB6618113636; Thu, 30 Sep 2021 02:08:55 +0000 (UTC) Received: from omf10.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 7938418059B50; Thu, 30 Sep 2021 02:08:54 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf10.hostedemail.com (Postfix) with ESMTPA id 7F78F2351F3; Thu, 30 Sep 2021 02:08:53 +0000 (UTC) Message-ID: From: Joe Perches To: Jim Cromie , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Wed, 29 Sep 2021 19:08:51 -0700 In-Reply-To: <20210930014427.14239-3-jim.cromie@gmail.com> References: <20210930014427.14239-1-jim.cromie@gmail.com> <20210930014427.14239-3-jim.cromie@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.0-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspamout01 X-Rspamd-Queue-Id: 7F78F2351F3 X-Stat-Signature: anmt6jx4t6f7u5gh4einmjsx1txe8h6k X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX18kGVBu/5EFA7vPk09h4PPRUG51zMWAUwg= X-HE-Tag: 1632967733-854858 Subject: Re: [Intel-gfx] [PATCH 2/4] amdgpu_ucode: reduce number of pr_debug calls X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 2021-09-29 at 19:44 -0600, Jim Cromie wrote: > There are blocks of DRM_DEBUG calls, consolidate their args into > single calls. With dynamic-debug in use, each callsite consumes 56 > bytes of callsite data, and this patch removes about 65 calls, so > it saves ~3.5kb. > > no functional changes. No functional change, but an output logging content change. > RFC: this creates multi-line log messages, does that break any syslog > conventions ? It does change the output as each individual DRM_DEBUG is a call to __drm_dbg which is effectively: printk(KERN_DEBUG "[" DRM_NAME ":%ps] %pV", __builtin_return_address(0), &vaf); > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c [] > @@ -30,17 +30,26 @@ >   > >  static void amdgpu_ucode_print_common_hdr(const struct common_firmware_header *hdr) >  { > - DRM_DEBUG("size_bytes: %u\n", le32_to_cpu(hdr->size_bytes)); > - DRM_DEBUG("header_size_bytes: %u\n", le32_to_cpu(hdr->header_size_bytes)); [] > + DRM_DEBUG("size_bytes: %u\n" > + "header_size_bytes: %u\n" etc...